From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web09.5819.1641900888784504379
 for <devel@edk2.groups.io>;
 Tue, 11 Jan 2022 03:34:49 -0800
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: pierre.gondois@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 73BAB1FB;
	Tue, 11 Jan 2022 03:34:48 -0800 (PST)
Received: from [192.168.1.10] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 396B73F766;
	Tue, 11 Jan 2022 03:34:47 -0800 (PST)
From: "PierreGondois" <pierre.gondois@arm.com>
Subject: Re: [edk2-devel] [PATCH 2/3] DynamicTablesPkg: Remove redundant cast in AmlCodeGenReturn
To: devel@edk2.groups.io, quic_rcran@quicinc.com,
 Sami Mujawar <Sami.Mujawar@arm.com>, Alexei Fedorov
 <Alexei.Fedorov@arm.com>, Leif Lindholm <quic_llinhol@quicinc.com>
References: <20220108215748.2173-1-quic_rcran@quicinc.com>
 <20220108215748.2173-3-quic_rcran@quicinc.com>
Message-ID: <c5316e1e-6858-b55d-0032-66a570df400b@arm.com>
Date: Tue, 11 Jan 2022 12:35:05 +0100
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.14.0
MIME-Version: 1.0
In-Reply-To: <20220108215748.2173-3-quic_rcran@quicinc.com>
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
Content-Language: en-US

Hello Rebecca,

The patch looks good to me,

Reviewed-by: Pierre Gondois <pierre.gondois@arm.com>


On 1/8/22 10:57 PM, Rebecca Cran via groups.io wrote:
> In AmlCodeGenReturn, the cast to AML_NODE_HEADER* in the call to
> AmlSetFixedArgument is redundant because ReturnNode is already a
> AML_NODE_HEADER* .
>
> Signed-off-by: Rebecca Cran <quic_rcran@quicinc.com>
> ---
>  DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> index d245848ce3fa..838a892c6b58 100644
> --- a/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> +++ b/DynamicTablesPkg/Library/Common/AmlLib/CodeGen/AmlCodeGen.c
> @@ -1564,7 +1564,7 @@ AmlCodeGenReturn (
>    Status = AmlSetFixedArgument (
>               ObjectNode,
>               EAmlParseIndexTerm0,
> -             (AML_NODE_HEADER *)ReturnNode
> +             ReturnNode
>               );
>    if (EFI_ERROR (Status)) {
>      ASSERT (0);