From: "Rebecca Cran" <rebecca@bsdio.com>
To: gua.guo@intel.com, devel@edk2.groups.io
Cc: Liming Gao <gaoliming@byosoft.com.cn>,
Bob Feng <bob.c.feng@intel.com>,
Yuwei Chen <yuwei.chen@intel.com>
Subject: Re: [PATCH v1] BaseTools: toolsetup.bat always execute PYTHON_HOME
Date: Fri, 26 May 2023 10:29:30 -0600 [thread overview]
Message-ID: <c546972e-9348-7895-c835-aa6e81f990cf@bsdio.com> (raw)
In-Reply-To: <20230526000948.1862-1-gua.guo@intel.com>
On 5/25/23 6:09 PM, gua.guo@intel.com wrote:
>
> -%PYTHON_COMMAND% %BASE_TOOLS_PATH%\Tests\PythonTest.py %PYTHON_VER_MAJOR% %PYTHON_VER_MINOR% >NUL 2>NUL
> -if %ERRORLEVEL% EQU 1 (
> - echo.
> - echo !!! ERROR !!! Python %PYTHON_VER_MAJOR%.%PYTHON_VER_MINOR% or newer is required.
> - echo.
> - goto end
> + %PYTHON_COMMAND% %BASE_TOOLS_PATH%\Tests\PythonTest.py %PYTHON_VER_MAJOR% %PYTHON_VER_MINOR% >NUL 2>NUL
> + if %ERRORLEVEL% EQU 1 (
> + echo.
> + echo !!! ERROR !!! Python %PYTHON_VER_MAJOR%.%PYTHON_VER_MINOR% or newer is required.
> + echo.
> + goto end
> + )
> )
If PYTHON_COMMAND is already defined we do still want to check it's a
version we can use. So I don't think this part of the change is correct.
--
Rebecca Cran
next prev parent reply other threads:[~2023-05-26 16:29 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-05-26 0:09 [PATCH v1] BaseTools: toolsetup.bat always execute PYTHON_HOME Guo, Gua
2023-05-26 16:29 ` Rebecca Cran [this message]
2023-05-26 16:56 ` Guo, Gua
2023-05-26 17:12 ` Rebecca Cran
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c546972e-9348-7895-c835-aa6e81f990cf@bsdio.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox