From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out4-smtp.messagingengine.com (out4-smtp.messagingengine.com [66.111.4.28]) by mx.groups.io with SMTP id smtpd.web11.1669.1685118573697218562 for ; Fri, 26 May 2023 09:29:34 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=Yg5WRvF3; spf=pass (domain: bsdio.com, ip: 66.111.4.28, mailfrom: rebecca@bsdio.com) Received: from compute4.internal (compute4.nyi.internal [10.202.2.44]) by mailout.nyi.internal (Postfix) with ESMTP id E1EEF5C0199; Fri, 26 May 2023 12:29:32 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute4.internal (MEProxy); Fri, 26 May 2023 12:29:32 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm2; t= 1685118572; x=1685204972; bh=0OWqr3bBbTAwoOhGK3h4jMp/AxqjWnlVUMK QckETOSQ=; b=Yg5WRvF3LzHI57rZYiMEPMgpPfIrG6usLz07yK6omWnGAnkb330 J3kacBPRc6GjnGDTXiR1cqukDzIeoygKw3k4Ber0apcimkRHgGc3VaOYKkG/oJBC myqtLMUvJRYfW7oCLalgFCihNZSf/sAXf3cg2s/NK5kwPD4xxMLHZ087S7coesm8 Vsphrr6ybuReRzaR98r9d9R9TxksIQr8DU9YkgBA+C91WPe0n3vu1HMiC/CYzJRT ZxIcYqGTPO1HVg3EUcRN4Al6iVQTKgHg4SE6zaYiG/MbuuuPNMz5HFuMz7oGdxQG r0GNmFdAxLJtRdKg7IsJZcqsbRfCRvwTmIQ== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm1; t= 1685118572; x=1685204972; bh=0OWqr3bBbTAwoOhGK3h4jMp/AxqjWnlVUMK QckETOSQ=; b=gyYEsW5lz0NOEflB9+Yvv42L4ykOLkA9f6loagjawetB4F8f1G7 mu0uH4iLzr2gXm1RORVpVlSh3kQFRcvGthfcNBDtFuJgonzXlbZvmThMnlR542OR nPkPaactQ9cF4fIv43gFVnann6DcXyosVdF08a/3cC/4BUwE5Tvw4Xir7cE8eoay I5WFaJZePrXk6c4L90Mqi4daxTSEfPBKh1tsWMNBk/dRq4hKD4xZI91EQZFgOSQV noEJyFINJQhpJABu5f6Wf1CrLllMuJxDSRRyvYZqfA9C8bWIF7SmdZ9GlM4H9vDK jOGdyJQg3poMkMM501s+xddxILCvIBKsL0Q== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrfeejledguddttdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefkffggfgfuvfevfhfhjggtgfesthejredttdefjeenucfhrhhomheptfgv sggvtggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrf grthhtvghrnhepheelkefgudetudegheegfffghfetfefhhfetteefveehgfdvjeehtdfh ffeiffelnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomh eprhgvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Fri, 26 May 2023 12:29:31 -0400 (EDT) Message-ID: Date: Fri, 26 May 2023 10:29:30 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v1] BaseTools: toolsetup.bat always execute PYTHON_HOME To: gua.guo@intel.com, devel@edk2.groups.io Cc: Liming Gao , Bob Feng , Yuwei Chen References: <20230526000948.1862-1-gua.guo@intel.com> From: "Rebecca Cran" In-Reply-To: <20230526000948.1862-1-gua.guo@intel.com> Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 5/25/23 6:09 PM, gua.guo@intel.com wrote: > > -%PYTHON_COMMAND% %BASE_TOOLS_PATH%\Tests\PythonTest.py %PYTHON_VER_MAJOR% %PYTHON_VER_MINOR% >NUL 2>NUL > -if %ERRORLEVEL% EQU 1 ( > - echo. > - echo !!! ERROR !!! Python %PYTHON_VER_MAJOR%.%PYTHON_VER_MINOR% or newer is required. > - echo. > - goto end > + %PYTHON_COMMAND% %BASE_TOOLS_PATH%\Tests\PythonTest.py %PYTHON_VER_MAJOR% %PYTHON_VER_MINOR% >NUL 2>NUL > + if %ERRORLEVEL% EQU 1 ( > + echo. > + echo !!! ERROR !!! Python %PYTHON_VER_MAJOR%.%PYTHON_VER_MINOR% or newer is required. > + echo. > + goto end > + ) > ) If PYTHON_COMMAND is already defined we do still want to check it's a version we can use. So I don't think this part of the change is correct. -- Rebecca Cran