From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [205.139.110.120]) by mx.groups.io with SMTP id smtpd.web11.18536.1597162419404419601 for ; Tue, 11 Aug 2020 09:13:39 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=HlC0yG+3; spf=pass (domain: redhat.com, ip: 205.139.110.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1597162418; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=HY1nRDcIS4SXBHNpb/mV/m2q0ZLKiMC73rIyOImbl+U=; b=HlC0yG+3/PoRGHyKBuh+wv9m9irnEsPNrM9pwZ4zXH/TohCEaMGtVnjTm+N1tlxEUu7Lhx VJx/1LFUu/uqTIB7kjQsXHnSkBtzy4VaX9MRVSwUcsaYnoH+Cm/Kk/6UVoEJS7XxztqH+7 NTE24ahDdpa5AQEIIXB5Knwk1jyyiNY= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-196-wek5hUxFMbmuYQ-K9nuPow-1; Tue, 11 Aug 2020 12:13:34 -0400 X-MC-Unique: wek5hUxFMbmuYQ-K9nuPow-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6A54E106B243; Tue, 11 Aug 2020 16:13:33 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-113-221.ams2.redhat.com [10.36.113.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 63C4E65C6E; Tue, 11 Aug 2020 16:13:32 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 4/5] ArmVirtPkg: Add RngLib based on TimerLib for CryptoPkg To: devel@edk2.groups.io, matthewfcarlson@gmail.com Cc: Ard Biesheuvel , Leif Lindholm References: <20200811022200.1087-1-matthewfcarlson@gmail.com> <20200811022200.1087-5-matthewfcarlson@gmail.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 11 Aug 2020 18:13:31 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Firefox/52.0 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20200811022200.1087-5-matthewfcarlson@gmail.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit On 08/11/20 04:21, Matthew Carlson wrote: > From: Matthew Carlson > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Matthew Carlson > --- > ArmVirtPkg/ArmVirt.dsc.inc | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index cf44fc73890b..ddfcd0cf9eee 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -42,6 +42,7 @@ > DebugPrintErrorLevelLib|MdePkg/Library/BaseDebugPrintErrorLevelLib/BaseDebugPrintErrorLevelLib.inf > > BaseLib|MdePkg/Library/BaseLib/BaseLib.inf > + RngLib|MdePkg/Library/BaseRngLibTimerLib/BaseRngLibTimerLib.inf > SafeIntLib|MdePkg/Library/BaseSafeIntLib/BaseSafeIntLib.inf > BmpSupportLib|MdeModulePkg/Library/BaseBmpSupportLib/BaseBmpSupportLib.inf > SynchronizationLib|MdePkg/Library/BaseSynchronizationLib/BaseSynchronizationLib.inf > In addition to the documentation updates requested by Ard and myself under the OvmfPkg patch (non-empty commit message body, BZ reference), I'd like to request that we add the RngLib resolution near the OpensslLib resolution(s). For example, right after: !if $(NETWORK_TLS_ENABLE) == TRUE OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLib.inf !else OpensslLib|CryptoPkg/Library/OpensslLib/OpensslLibCrypto.inf !endif Thanks! Laszlo