From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mout.gmx.net (mout.gmx.net [212.227.15.19]) by mx.groups.io with SMTP id smtpd.web11.29762.1620642628200107346 for ; Mon, 10 May 2021 03:30:28 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@gmx.net header.s=badeba3b8450 header.b=B6DYnWXg; spf=pass (domain: gmx.de, ip: 212.227.15.19, mailfrom: xypron.glpk@gmx.de) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=gmx.net; s=badeba3b8450; t=1620642599; bh=PRSLdgeD9mh5S2uKe2Z6pVGZ3O6wnofb36KMoV9r1pw=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=B6DYnWXgSvvAoDZhgWAfVvGY/BK1XBq6+ZLKy6Y0BNh9YoY53BQ8UgZJND/7Uytbj xRRiZwFZaBOI3zAZ/Wgr8rkE0QOcOb2qNNLrAq20rijyxQwANr8Np+I5CKBSzdkPTP YO2pTk3iDYpXodYIR2Fd4O59fahVedDx+66hWaNU= X-UI-Sender-Class: 01bb95c1-4bf8-414a-932a-4f6e2808ef9c Received: from [192.168.123.35] ([62.143.247.63]) by mail.gmx.net (mrgmx004 [212.227.17.190]) with ESMTPSA (Nemesis) id 1N5VDE-1lRRtd2KiI-016zfB; Mon, 10 May 2021 12:29:59 +0200 Subject: Re: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: IHV: type mismatch in SimpleTextOut test To: Sunny Wang , "devel@edk2.groups.io" Cc: Eric Jin , G Edhaya Chandran , Barton Gao , Arvin Chen , Samer El-Haj-Mahmoud References: <20210330150831.91846-1-xypron.glpk@gmx.de> From: "Heinrich Schuchardt" Message-ID: Date: Mon, 10 May 2021 12:29:57 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: X-Provags-ID: V03:K1:ivorKBtGwU023iki0h81v4Or+lqBmM/5kDan0e+Y8afUy+g+CU3 MT6y6dVB6EsMAOrzVqV6PRsbW3Y6oCT8YOljbzdPJyxHqYbwfC01dkV4dvP+tNwPcIi9YiT t8ZLz54AXGXUwc3RwD9duxx2aEQIYWOf9IcP58DyHQz3Nc1vxqP6k9ha4VkEFuyW8QsZAWb VFGzSbgsoT+Ud+eQl9uEA== X-Spam-Flag: NO X-UI-Out-Filterresults: notjunk:1;V03:K0:b1VUyg9vLnE=:VXMbmPwMbsMYcQKDP0u/d3 Hnip9FTRI/4JGSIeV4L5FB1vB+HUj2F/pqwVlx99BjTuUWkcsEW9937GiFdUF1n1kcJo9hJxi VXXCHUiMZvHg5IOiu5SQxtdLgn5/aT0RnMKHhcmNTjcMz37kOn1Lc+Wd+2ii9EMkPbYZU/t6I HoqDcHl4X9YFwzwXKP7uldiUEV9YXstdvYT7E4SgYdvZP9bu9IbkvLb1fVmz4OjBH3Sb4Ojg5 nrmHvEbdQ3ZYYsYVEWlU2Tnd7Lsuh1+LcELgu7w6XN4siyEC1PnMx3Q+KU6mqam1VBLRjbyga AJDIf4SoEarxWiOBcqWOQtxaFmVqaQ0a8RgIxfCwLOt7i07RPbp0AoFTC0IyNySe+Mu3pzGrq LDDclYqupk3xlTTb92J4P0O0mIJjEUhc/tpcv6xaIa0zUCWSacrQ72OWnw7mDIEQiRAVr2YnB 8paMe5YEHfJlpZupTUl8RzNExqEQIkfRHkMAaMmD2RKlWyi9I1dxCOUpOJbdi+pmaqSzeTBFE kYY0P6b8xcGe4BJLvJE5gRoA4hdjHMTELoPJA2jR7uMvxu/yCzfoPKxyHbZBABI+qi5DTRwXL rBebWZb/mewsXwociCjZArnxrPZYfuR1THFODnNPnvRZagoKHppEQejJ921K4N6PBvOm4SS7m t5BmbbCI5k+8yMYSWCzDZK3/ex/kQvvBFOPV0Kd8qEdWaOlQ0AMWEKEKHGnMYvi0+DvmsyW3u dLF+JBhMDXhiEswXK9jq1Xpohtdd6OpJ8nKRFjJvPAFyZt8/em9YbHdzI2ipU63QSpH2mzl91 pNWxV8iyu9t+9mYoyHKWKEOYhyH5+PCKO3EpMMgdJR/9/vwfwwjTcqhtw1flGlvjeUkgUK65o eR42Dd2dNFHMIYLU7Np9l12qFgacI09qT9HV7nA6zLjg708EVHJptTyIDRFG7F9gV5yxICEA5 tMopBVXIQooNoMvyGMbzP9IbMRabunE/jOP/+XZgV2kSQ2Lz9b4zU7U6ChRa9dfEqASiia+oY sUjft+UqpibrIDm7Y0zf9Auc7ssTecGFnUIAZs7SXB1y3+xgPAEscGlyv/4AikkO3ptFx/RIB zsg0NemO532ZJOcPJINJJAW/9+6OhMjnnGqgAybrGFszrJmWF+dq514KipHSGji7ShkXupXeE uIKgZHgyHNhAfeDCjksLl7Vv2jNhXM3jbNx3S6TTAJCspjG3XmqogMIMFEluNYyczEfGw= Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: quoted-printable On 5/10/21 11:24 AM, Sunny Wang wrote: > Looks good. However, I'm thinking about if this is a UEFI specification = issue. It looks like we should change the parameter type in EFI_SIMPLE_TEX= T_OUTPUT_MODE data structure instead of doing typecasting. > Morevover, we may also need to check the files below: > - uefi-sct\SctPkg\TestCase\UEFI\EFI\Protocol\SimpleTextOut\Black= BoxTest\SimpleTextOutBBTestConformance_efi.c > - uefi-sct\SctPkg\TestCase\UEFI\EFI\Protocol\SimpleTextOut\Black= BoxTest\SimpleTextOutBBTestConformance_uefi.c > - uefi-sct\SctPkg\TestCase\UEFI\EFI\Protocol\SimpleTextOut\Black= BoxTest\SimpleTextOutBBTestFunction_efi.c > - uefi-sct\SctPkg\TestCase\UEFI\IHV\Protocol\SimpleTextOut\Black= BoxTest\SimpleTextOutBBTestConformance_uefi.c > > Reviewed-by: Sunny Wang Thank you for reviewing. I had a look into the UEFI spec 2.9: Structure SIMPLE_TEXT_OUTPUT_MODE is defined with Mode and MaxMode as INT3= 2. EDK II uses the structure name EFI_SIMPLE_TEXT_OUTPUT_MODE instead of SIMPLE_TEXT_OUTPUT_MODE. Changing the component types in SIMPLE_TEXT_OUTPUT_MODE would break forward and backward compatibility of UEFI applications. I see no value in such a change. Best regards Heinrich > > Best Regards, > Sunny Wang > > -----Original Message----- > From: devel@edk2.groups.io On Behalf Of Heinrich = Schuchardt via groups.io > Sent: Tuesday, March 30, 2021 11:09 PM > To: EDK II Development > Cc: Eric Jin ; G Edhaya Chandran ; Barton Gao ; Arvin Chen ; Samer El-Haj-Mahmoud ; Heinrich Schuch= ardt ; G Edhaya Chandran > Subject: [edk2-devel] [PATCH edk2-test 1/1] uefi-sct/SctPkg: IHV: type m= ismatch in SimpleTextOut test > > REF: https://bugzilla.tianocore.org/show_bug.cgi?id=3D3253 > > SctPrint() requires that %d refers to an UINTN parameter. > > SimpleTextOutBBTestFunction_uefi.c has a lot of > StandardLib->RecordAssertion() calls where an INT32 is passed > as argument for a '%d' print code. > > This leads to incorrect output like: > > MaxMode=3D-549755813885, > > -549755813885 is 0x0xFFFFFF8000000003. So MaxMode actually is an INT32 w= ith value 3 in this example. > > Convert the parameters to UINTN. > > Signed-off-by: Heinrich Schuchardt > Reviewed-by: G Edhaya Chandran > --- > .../SimpleTextOutBBTestFunction_uefi.c | 624 +++++++++--------- > 1 file changed, 312 insertions(+), 312 deletions(-) > > diff --git a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/Bl= ackBoxTest/SimpleTextOutBBTestFunction_uefi.c b/uefi-sct/SctPkg/TestCase/U= EFI/IHV/Protocol/SimpleTextOut/BlackBoxTest/SimpleTextOutBBTestFunction_ue= fi.c > index 2bc9bcdb51f9..a833498c2816 100644 > --- a/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxT= est/SimpleTextOutBBTestFunction_uefi.c > +++ b/uefi-sct/SctPkg/TestCase/UEFI/IHV/Protocol/SimpleTextOut/BlackBoxT > +++ est/SimpleTextOutBBTestFunction_uefi.c > @@ -176,12 +176,12 @@ BBTestResetFunctionManualTest ( > L" Expected:Cursor Position(%d x %d), MaxMode=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->MaxMode, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.MaxMode > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.MaxMode > ); > > // > @@ -272,12 +272,12 @@ BBTestResetFunctionManualTest ( > L" Expected:Cursor Position(%d x %d), MaxMode=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->MaxMode, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.MaxMode > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.MaxMode > ); > > // > @@ -505,12 +505,12 @@ BBTestResetFunctionAutoTest ( > L"Expected:Cursor Position(%d x %d), MaxMode=3D%d."= , > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->MaxMode, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.MaxMode > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.MaxMode > ); > > // > @@ -582,12 +582,12 @@ BBTestResetFunctionAutoTest ( > L" Expected:Cursor Position(%d x %d), MaxMode=3D%d.= ", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->MaxMode, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.MaxMode > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.MaxMode > ); > > // > @@ -850,18 +850,18 @@ BBTestOutputStringFunctionAutoTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -987,18 +987,18 @@ BBTestOutputStringFunctionAutoTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -1094,18 +1094,18 @@ BBTestOutputStringFunctionAutoTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -1217,18 +1217,18 @@ BBTestOutputStringFunctionAutoTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -1469,18 +1469,18 @@ BBTestOutputStringFunctionManualTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -1626,18 +1626,18 @@ BBTestOutputStringFunctionManualTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -1754,18 +1754,18 @@ BBTestOutputStringFunctionManualTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -1897,18 +1897,18 @@ BBTestOutputStringFunctionManualTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -2240,18 +2240,18 @@ BBTestTestStringFunctionAutoTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, MaxM= ode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -2433,18 +2433,18 @@ BBTestQueryModeFunctionAutoTest ( > __FILE__, > (UINTN)__LINE__, > Index, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > if ( EFI_UNSUPPORTED =3D=3D Status && 1 =3D=3D Index ) { @@ -2720,= 18 +2720,18 @@ BBTestSetModeFunctionManualTest ( > __FILE__, > (UINTN)__LINE__, > Index, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -2968,18 +2968,18 @@ BBTestSetModeFunctionAutoTest ( > __FILE__, > (UINTN)__LINE__, > Index, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -3193,18 +3193,18 @@ BBTestSetAttributeFunctionManualTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d= , MaxMode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > Result =3D FALSE; > } > @@ -3451,18 +3451,18 @@ BBTestSetAttributeFunctionAutoTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D= %d, MaxMode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > Result =3D FALSE; > } > @@ -3653,18 +3653,18 @@ BBTestClearScreenFunctionManualTest ( > L" Expected: Cursor Position(%d x %d), Mode=3D%d, Max= Mode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -3896,18 +3896,18 @@ BBTestClearScreenFunctionAutoTest ( > L"Expected:Cursor Position(%d x %d), Mode=3D%d, Max= Mode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -4143,18 +4143,18 @@ BBTestSetCursorPositionFunctionManualTest ( > L"Expected:Cursor Position(%d x %d), Mode=3D%d,= MaxMode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > Result =3D FALSE; > } > @@ -4434,18 +4434,18 @@ BBTestSetCursorPositionFunctionAutoTest ( > L"Expected:Cursor Position(%d x %d), Mode=3D%= d, MaxMode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > Result =3D FALSE; > } > @@ -4669,18 +4669,18 @@ BBTestEnableCursorFunctionManualTest ( > L"Expected:Cursor Position(%d x %d), Mode=3D%d, Max= Mode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -4739,18 +4739,18 @@ BBTestEnableCursorFunctionManualTest ( > L"Expected:Cursor Position(%d x %d), Mode=3D%d, Max= Mode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > } else { > // > @@ -4803,18 +4803,18 @@ BBTestEnableCursorFunctionManualTest ( > L"Expected:Cursor Position(%d x %d), Mode=3D%d, Max= Mode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > // > @@ -4888,18 +4888,18 @@ BBTestEnableCursorFunctionManualTest ( > L"Expected:Cursor Position(%d x %d), Mode=3D%d, Max= Mode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > } else { > // > @@ -5128,18 +5128,18 @@ BBTestEnableCursorFunctionAutoTest ( > L"Expected:Cursor Position(%d x %d), Mode=3D%d, Max= Mode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > AssertionType =3D EFI_TEST_ASSERTION_PASSED; @@ -5212,18 +5212,18 = @@ BBTestEnableCursorFunctionAutoTest ( > L" Expected:Cursor Position(%d x %d), Mode=3D%d, Ma= xMode=3D%d, Attribute=3D%d, CursorVisible=3D%d.", > __FILE__, > (UINTN)__LINE__, > - SimpleOut->Mode->CursorColumn, > - SimpleOut->Mode->CursorRow, > - SimpleOut->Mode->Mode, > - SimpleOut->Mode->MaxMode, > - SimpleOut->Mode->Attribute, > - SimpleOut->Mode->CursorVisible, > - ModeExpected.CursorColumn, > - ModeExpected.CursorRow, > - ModeExpected.Mode, > - ModeExpected.MaxMode, > - ModeExpected.Attribute, > - ModeExpected.CursorVisible > + (UINTN)SimpleOut->Mode->CursorColumn, > + (UINTN)SimpleOut->Mode->CursorRow, > + (UINTN)SimpleOut->Mode->Mode, > + (UINTN)SimpleOut->Mode->MaxMode, > + (UINTN)SimpleOut->Mode->Attribute, > + (UINTN)SimpleOut->Mode->CursorVisible, > + (UINTN)ModeExpected.CursorColumn, > + (UINTN)ModeExpected.CursorRow, > + (UINTN)ModeExpected.Mode, > + (UINTN)ModeExpected.MaxMode, > + (UINTN)ModeExpected.Attribute, > + (UINTN)ModeExpected.CursorVisible > ); > > > -- > 2.30.2 > > > > -=3D-=3D-=3D-=3D-=3D-=3D > Groups.io Links: You receive all messages sent to this group. > View/Reply Online (#73535): https://edk2.groups.io/g/devel/message/73535 > Mute This Topic: https://groups.io/mt/81724304/5985097 > Group Owner: devel+owner@edk2.groups.io > Unsubscribe: https://edk2.groups.io/g/devel/unsub [Sunny.Wang@arm.com] -= =3D-=3D-=3D-=3D-=3D-=3D > > > IMPORTANT NOTICE: The contents of this email and any attachments are con= fidential and may also be privileged. If you are not the intended recipien= t, please notify the sender immediately and do not disclose the contents t= o any other person, use it for any purpose, or store or copy the informati= on in any medium. Thank you. >