public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Rebecca Cran" <rebecca@bsdio.com>
To: devel@edk2.groups.io, rebecca@bsdio.com
Cc: "Leif Lindholm" <quic_llindhol@quicinc.com>,
	"Michael D Kinney" <michael.d.kinney@intel.com>,
	"Ard Biesheuvel" <ardb+tianocore@kernel.org>,
	"Abner Chang" <abner.chang@amd.com>,
	"Abdul Lateef Attar" <AbdulLateef.Attar@amd.com>,
	"Paul Grimes" <paul.grimes@amd.com>,
	"Eric Xing" <eric.xing@amd.com>, "Ken Yao" <ken.yao@amd.com>,
	"Duke Zhai" <duke.zhai@amd.com>,
	"Igniculus Fu" <igniculus.fu@amd.com>,
	"Nhi Pham" <nhi@os.amperecomputing.com>,
	"Chuong Tran" <chuong@os.amperecomputing.com>,
	"Thomas Abraham" <thomas.abraham@arm.com>,
	"Sami Mujawar" <sami.mujawar@arm.com>,
	"Ray Ni" <ray.ni@intel.com>,
	"Ilias Apalodimas" <ilias.apalodimas@linaro.org>,
	"Andy Hayes" <andy.hayes@displaylink.com>,
	"Wenyi Xie" <xiewenyi2@huawei.com>,
	"Pedro Falcato" <pedro.falcato@gmail.com>,
	"Marvin Häuser" <mhaeuser@posteo.de>,
	"Sai Chaganty" <rangasai.v.chaganty@intel.com>,
	"Nate DeSimone" <nathaniel.l.desimone@intel.com>,
	"Liming Gao" <gaoliming@byosoft.com.cn>,
	"Eric Dong" <eric.dong@intel.com>,
	"Dandan Bi" <dandan.bi@intel.com>,
	"Nickle Wang" <nicklew@nvidia.com>,
	"Kelly Steele" <kelly.steele@intel.com>,
	"Zailiang Sun" <zailiang.sun@intel.com>,
	"Yi Qian" <yi.qian@intel.com>,
	"Chasel Chiu" <chasel.chiu@intel.com>,
	"Benjamin Doron" <benjamin.doron00@gmail.com>,
	"Jeremy Soller" <jeremy@system76.com>,
	"Daniel Schaefer" <git@danielschaefer.me>,
	"Sunil V L" <sunilvl@ventanamicro.com>,
	"Yuwei Chen" <yuwei.chen@intel.com>,
	"Jeremy Linton" <jeremy.linton@arm.com>,
	"Marcin Juszkiewicz" <marcin.juszkiewicz@linaro.org>,
	"Graeme Gregory" <graeme@xora.org.uk>
Subject: Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests
Date: Wed, 3 Jul 2024 08:19:58 -0600	[thread overview]
Message-ID: <c571ff49-6706-4c6a-80bb-474dc0c552d9@bsdio.com> (raw)
In-Reply-To: <71e26999-15bb-4b74-b884-e20480ba92f6@bsdio.com>

On 7/1/24 13:16, Rebecca Cran via groups.io wrote:
> Now that edk2 has been using PRs for a few weeks, I'd like to propose 
> enabling the same workflow for edk2-platfoms.
> 
> As maintainers or reviewers of platforms in the edk2-platforms repo, I'd 
> like to get any feedback on moving from email-based reviews to GitHub 
> Pull Requests and any concerns or issues people might have with it.
As Leif pointed out, the other question is around assigning reviewers.

Would people be okay with moving to CODEOWNERS as a method of assigning 
reviewers, moving away from Maintainers.txt?
It's less flexible because it doesn't have the concept of maintainers vs 
reviewers, so the idea would be to add both to CODEOWNERS but only allow 
maintainers to set the 'push' label or otherwise write to the repository.

-- 
Rebecca Cran


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#119787): https://edk2.groups.io/g/devel/message/119787
Mute This Topic: https://groups.io/mt/106986207/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-



  parent reply	other threads:[~2024-07-03 14:20 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-07-01 19:16 [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests Rebecca Cran
2024-07-01 19:19 ` Paul via groups.io
2024-07-02  1:14   ` Chang, Abner via groups.io
2024-07-01 20:13 ` Leif Lindholm
2024-07-02 10:20 ` Marvin Häuser
2024-07-03 14:19 ` Rebecca Cran [this message]
2024-07-04  3:21   ` Chang, Abner via groups.io

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c571ff49-6706-4c6a-80bb-474dc0c552d9@bsdio.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox