From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 08686D8118F for ; Wed, 3 Jul 2024 14:20:09 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=htfkCOm7BxakuCwnu9k2UXfeX7rnFelXlI+wszeAc7Y=; c=relaxed/simple; d=groups.io; h=Feedback-ID:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240206; t=1720016409; v=1; b=fp9+rY/BjKJ2Y++chjZ90A2qicIweawj9MSguHdViLEePOkenfcWtkZdCJE0Pec06LR6X6Kv GuFnwoqq79nhpeti8TMtAv2tNpAwB2fHruZ5+WFhuUJQdV0oYgxpCsd+TxHV2w8SwoMQnaAnYHJ YylrcuNl1kNmldOodc5veno/eHlqh3LzwpNkWy3uYa+i69TJ4bmwYGQ/VrEDaqLX6i5iXsIm4Ng OC7RhOLKhVr4yn+x6TZTO828ZAyel8YDbUhcKnD9Mc4S5+lx8aYwDuhbyOxepY7iuXXKEvVLFG0 YLUg0FclxBKDPqJ8xtnj7az0AGzF+LbLHG9oyfPbJs5Sw== X-Received: by 127.0.0.2 with SMTP id P5WzYY7687511xeZPpJk4BD9; Wed, 03 Jul 2024 07:20:08 -0700 X-Received: from fhigh5-smtp.messagingengine.com (fhigh5-smtp.messagingengine.com [103.168.172.156]) by mx.groups.io with SMTP id smtpd.web11.52275.1720016407447490735 for ; Wed, 03 Jul 2024 07:20:07 -0700 X-Received: from compute2.internal (compute2.nyi.internal [10.202.2.46]) by mailfhigh.nyi.internal (Postfix) with ESMTP id AC82711401A4; Wed, 3 Jul 2024 10:20:06 -0400 (EDT) X-Received: from mailfrontend1 ([10.202.2.162]) by compute2.internal (MEProxy); Wed, 03 Jul 2024 10:20:06 -0400 X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeeftddrudejgdejhecutefuodetggdotefrodftvf curfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfghnecu uegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmdenuc fjughrpefkffggfgfuvfevfhfhjggtgfesthejredttddvjeenucfhrhhomheptfgvsggv tggtrgcuvehrrghnuceorhgvsggvtggtrgessghsughiohdrtghomheqnecuggftrfgrth htvghrnhephfekvdekvdfhtddvteehueeuleetjefhieehjeeuhfdtuddtvdeguddtkeev lefhnecuvehluhhsthgvrhfuihiivgeptdenucfrrghrrghmpehmrghilhhfrhhomheprh gvsggvtggtrgessghsughiohdrtghomh X-ME-Proxy: Feedback-ID: i5b994698:Fastmail X-Received: by mail.messagingengine.com (Postfix) with ESMTPA; Wed, 3 Jul 2024 10:19:59 -0400 (EDT) Message-ID: Date: Wed, 3 Jul 2024 08:19:58 -0600 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] Moving edk2-platforms reviews to GitHub Pull Requests To: devel@edk2.groups.io, rebecca@bsdio.com Cc: Leif Lindholm , Michael D Kinney , Ard Biesheuvel , Abner Chang , Abdul Lateef Attar , Paul Grimes , Eric Xing , Ken Yao , Duke Zhai , Igniculus Fu , Nhi Pham , Chuong Tran , Thomas Abraham , Sami Mujawar , Ray Ni , Ilias Apalodimas , Andy Hayes , Wenyi Xie , Pedro Falcato , =?UTF-8?Q?Marvin_H=C3=A4user?= , Sai Chaganty , Nate DeSimone , Liming Gao , Eric Dong , Dandan Bi , Nickle Wang , Kelly Steele , Zailiang Sun , Yi Qian , Chasel Chiu , Benjamin Doron , Jeremy Soller , Daniel Schaefer , Sunil V L , Yuwei Chen , Jeremy Linton , Marcin Juszkiewicz , Graeme Gregory References: <71e26999-15bb-4b74-b884-e20480ba92f6@bsdio.com> From: "Rebecca Cran" In-Reply-To: <71e26999-15bb-4b74-b884-e20480ba92f6@bsdio.com> Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Wed, 03 Jul 2024 07:20:07 -0700 Resent-From: rebecca@bsdio.com Reply-To: devel@edk2.groups.io,rebecca@bsdio.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: hjYcygvYiOqf9mz5f4HM5Dhxx7686176AA= Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b="fp9+rY/B"; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none On 7/1/24 13:16, Rebecca Cran via groups.io wrote: > Now that edk2 has been using PRs for a few weeks, I'd like to propose=20 > enabling the same workflow for edk2-platfoms. >=20 > As maintainers or reviewers of platforms in the edk2-platforms repo, I'd= =20 > like to get any feedback on moving from email-based reviews to GitHub=20 > Pull Requests and any concerns or issues people might have with it. As Leif pointed out, the other question is around assigning reviewers. Would people be okay with moving to CODEOWNERS as a method of assigning=20 reviewers, moving away from Maintainers.txt? It's less flexible because it doesn't have the concept of maintainers vs=20 reviewers, so the idea would be to add both to CODEOWNERS but only allow=20 maintainers to set the 'push' label or otherwise write to the repository. --=20 Rebecca Cran -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#119787): https://edk2.groups.io/g/devel/message/119787 Mute This Topic: https://groups.io/mt/106986207/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-