From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web09.1585.1626855641030280353 for ; Wed, 21 Jul 2021 01:20:41 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=X6xcJDbt; spf=pass (domain: redhat.com, ip: 170.10.133.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626855640; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=/SPhSjlDWHxR0nlQmv5Pw4WvCoGZbK6aBYCX24BYPQ8=; b=X6xcJDbtILYgXZfSctLV5y10723P+VrqhB8dksPOt6UyoaglkOA6J0ev4VZCxir9324soB qYcCxaEYf8ui5xrsVr1pYLPQl40IFqhYuRAP8cEJO6fR3mY7qwT2n+VjondijSJcfCy55u +4k/UqCj0kxmHjuNUlSUZI8+gUxFFnE= Received: from mail-wr1-f69.google.com (mail-wr1-f69.google.com [209.85.221.69]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-416-jXD4Qs-dPSuKTfK6QLJFXA-1; Wed, 21 Jul 2021 04:20:39 -0400 X-MC-Unique: jXD4Qs-dPSuKTfK6QLJFXA-1 Received: by mail-wr1-f69.google.com with SMTP id i12-20020adffc0c0000b0290140ab4d8389so642008wrr.10 for ; Wed, 21 Jul 2021 01:20:39 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=/SPhSjlDWHxR0nlQmv5Pw4WvCoGZbK6aBYCX24BYPQ8=; b=Ec1NnZFziQUP31gMSCVrf2KvkHjc1m9dOw9huBqWrZKDuJ1/F3y9hJyd5J163lDemt 9gePjyNw9ODgH+pqoBVjfzxc9jbnR1B0xAIaIlM2zlrRtXoHfnqGy8KJrFtVAXO1j7gf T7GGkPU8T8xYWANjc9eVSk5YsxDMB/wzDXYuIHqmbwNxFuXbbLPXarVrDfLjx33qq3P1 4P6vkWmuTNrBsv8utKN+AFC0ZO4XmLNT6bU5iUH5FoMy3QWy29lE6WeHLirRxFnKNL4H 2OeVBplTfcWmLJ/TryhEbHCyhM7pJpxECImLZi0A0KBHvQtbxYu6TTdaN43afpVS0NZL 500A== X-Gm-Message-State: AOAM531+cdYhXDolNsJ60yaJTwmbMuOoa719JuXp4sz50kOYZUsg84HE v4hPATaYsuLYO238I9MSNoAsBh5q6IemOXf+JqrtgHxmP200jAn8eksjIU5DK5DncGI65WvKnDn LzMJ0s251n8jnBA== X-Received: by 2002:a05:600c:4e8f:: with SMTP id f15mr36803249wmq.174.1626855637898; Wed, 21 Jul 2021 01:20:37 -0700 (PDT) X-Google-Smtp-Source: ABdhPJw1hk5+3abMRYP4lyaBtFTTPRnZBAm13qE8K4R0l8L/Gw4OnY3AjmQfLiyPJoWH0QgcdQNc/Q== X-Received: by 2002:a05:600c:4e8f:: with SMTP id f15mr36803233wmq.174.1626855637731; Wed, 21 Jul 2021 01:20:37 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (122.red-83-42-66.dynamicip.rima-tde.net. [83.42.66.122]) by smtp.gmail.com with ESMTPSA id l2sm19996297wms.21.2021.07.21.01.20.36 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 21 Jul 2021 01:20:37 -0700 (PDT) Subject: Re: [PATCH v3] OvmfPkg: Remove unused print service driver (PrintDxe) To: devel@edk2.groups.io, Jiewen Yao Cc: Laszlo Ersek , Ard Biesheuvel , Jordan Justen , Brijesh Singh , Erdem Aktas , James Bottomley , Min Xu , Tom Lendacky References: <20210707180221.1490414-1-philmd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Wed, 21 Jul 2021 10:20:36 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210707180221.1490414-1-philmd@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Ping? On 7/7/21 8:02 PM, Philippe Mathieu-Daudé wrote: > From: Philippe Mathieu-Daude > > PrintDxe produces gEfiPrint2ProtocolGuid and gEfiPrint2SProtocolGuid, > and those are consumed by the following PrintLib instance: > > MdeModulePkg/Library/DxePrintLibPrint2Protocol/DxePrintLibPrint2Protocol.inf > > However, none of the OVMF DSC files contain such a PrintLib class > resolution, so none of the OVMF platforms need PrintDxe. > > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Brijesh Singh > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Tom Lendacky > Suggested-by: Laszlo Ersek > Signed-off-by: Philippe Mathieu-Daude > --- > OvmfPkg/AmdSev/AmdSevX64.dsc | 1 - > OvmfPkg/Bhyve/BhyveX64.dsc | 1 - > OvmfPkg/OvmfPkgIa32.dsc | 1 - > OvmfPkg/OvmfPkgIa32X64.dsc | 1 - > OvmfPkg/OvmfPkgX64.dsc | 1 - > OvmfPkg/OvmfXen.dsc | 1 - > OvmfPkg/AmdSev/AmdSevX64.fdf | 1 - > OvmfPkg/Bhyve/BhyveX64.fdf | 1 - > OvmfPkg/OvmfPkgIa32.fdf | 1 - > OvmfPkg/OvmfPkgIa32X64.fdf | 1 - > OvmfPkg/OvmfPkgX64.fdf | 1 - > OvmfPkg/OvmfXen.fdf | 1 - > 12 files changed, 12 deletions(-) > > diff --git a/OvmfPkg/AmdSev/AmdSevX64.dsc b/OvmfPkg/AmdSev/AmdSevX64.dsc > index 1d487befae08..d1974b4a6873 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.dsc > +++ b/OvmfPkg/AmdSev/AmdSevX64.dsc > @@ -722,7 +722,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/Bhyve/BhyveX64.dsc b/OvmfPkg/Bhyve/BhyveX64.dsc > index 006831449518..c08fa9bdbf5b 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.dsc > +++ b/OvmfPkg/Bhyve/BhyveX64.dsc > @@ -673,7 +673,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.dsc b/OvmfPkg/OvmfPkgIa32.dsc > index f53efeae7986..dff4b97b37c0 100644 > --- a/OvmfPkg/OvmfPkgIa32.dsc > +++ b/OvmfPkg/OvmfPkgIa32.dsc > @@ -816,7 +816,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.dsc b/OvmfPkg/OvmfPkgIa32X64.dsc > index b3662e17f256..f3df655c990e 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.dsc > +++ b/OvmfPkg/OvmfPkgIa32X64.dsc > @@ -830,7 +830,6 @@ [Components.X64] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.dsc b/OvmfPkg/OvmfPkgX64.dsc > index 0a237a905866..dc9a2720f9b2 100644 > --- a/OvmfPkg/OvmfPkgX64.dsc > +++ b/OvmfPkg/OvmfPkgX64.dsc > @@ -828,7 +828,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfXen.dsc b/OvmfPkg/OvmfXen.dsc > index 3c1ca6bfd493..aee91a61e7c3 100644 > --- a/OvmfPkg/OvmfXen.dsc > +++ b/OvmfPkg/OvmfXen.dsc > @@ -610,7 +610,6 @@ [Components] > DevicePathLib|MdePkg/Library/UefiDevicePathLib/UefiDevicePathLib.inf > PcdLib|MdePkg/Library/BasePcdLibNull/BasePcdLibNull.inf > } > - MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/AmdSev/AmdSevX64.fdf b/OvmfPkg/AmdSev/AmdSevX64.fdf > index 9977b0f00a18..42f120d016e1 100644 > --- a/OvmfPkg/AmdSev/AmdSevX64.fdf > +++ b/OvmfPkg/AmdSev/AmdSevX64.fdf > @@ -234,7 +234,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/Bhyve/BhyveX64.fdf b/OvmfPkg/Bhyve/BhyveX64.fdf > index b3b4d44cef34..e8227f865f75 100644 > --- a/OvmfPkg/Bhyve/BhyveX64.fdf > +++ b/OvmfPkg/Bhyve/BhyveX64.fdf > @@ -233,7 +233,6 @@ [FV.DXEFV] > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32.fdf b/OvmfPkg/OvmfPkgIa32.fdf > index 04b41445ca34..031eb4225c53 100644 > --- a/OvmfPkg/OvmfPkgIa32.fdf > +++ b/OvmfPkg/OvmfPkgIa32.fdf > @@ -254,7 +254,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgIa32X64.fdf b/OvmfPkg/OvmfPkgIa32X64.fdf > index 02fd8f0c413e..7194f08e6024 100644 > --- a/OvmfPkg/OvmfPkgIa32X64.fdf > +++ b/OvmfPkg/OvmfPkgIa32X64.fdf > @@ -255,7 +255,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfPkgX64.fdf b/OvmfPkg/OvmfPkgX64.fdf > index 5fa8c0895808..b304e3149d4f 100644 > --- a/OvmfPkg/OvmfPkgX64.fdf > +++ b/OvmfPkg/OvmfPkgX64.fdf > @@ -267,7 +267,6 @@ [FV.DXEFV] > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF OvmfPkg/QemuKernelLoaderFsDxe/QemuKernelLoaderFsDxe.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > diff --git a/OvmfPkg/OvmfXen.fdf b/OvmfPkg/OvmfXen.fdf > index aeb9336fd5b7..d109341d2890 100644 > --- a/OvmfPkg/OvmfXen.fdf > +++ b/OvmfPkg/OvmfXen.fdf > @@ -325,7 +325,6 @@ [FV.DXEFV] > INF MdeModulePkg/Universal/BdsDxe/BdsDxe.inf > INF MdeModulePkg/Application/UiApp/UiApp.inf > INF MdeModulePkg/Universal/DevicePathDxe/DevicePathDxe.inf > -INF MdeModulePkg/Universal/PrintDxe/PrintDxe.inf > INF MdeModulePkg/Universal/Disk/DiskIoDxe/DiskIoDxe.inf > INF MdeModulePkg/Universal/Disk/PartitionDxe/PartitionDxe.inf > INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf >