Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg

["Laszlo Ersek" <lersek@redhat.com>]

On 04/06/20 12:11, Ard Biesheuvel wrote:
> On 4/5/20 8:39 AM, Sean via groups.io wrote:
>> Platform and Core CI patches are ready for review.  I have 14 commits
>> here.
>> https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages
>>
>>
>> This adds support for "Platform CI" for ArmVirtPkg, OvmfPkg, and
>> EmulatorPkg.
>> Each readme has live status and links to the builds as well as details
>> of how to build and run the same way the CI server will.
>> ArmVirt:
>> https://github.com/spbrogan/edk2/blob/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages/ArmVirtPkg/README-pytools.md
>>
>> Emulator:
>> https://github.com/spbrogan/edk2/blob/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages/EmulatorPkg/README-pytools.md
>>
>> OvmfPkg:
>> https://github.com/spbrogan/edk2/blob/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages/OvmfPkg/README-pytools.md
>>
>>
>> It also adds ArmVirtPkg, OvmfPkg, and EmulatorPkg to Core CI just for
>> the code evaluation tests (not compiling).  Details of those tests are
>> here:
>> https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmulatorPackages/.pytool
>>
>>
>> ArmVirtPkg, OvmfPkg, and EmulatorPkg maintainers please review and let
>> me know what the next step for you package is.  This is ready to
>> commit from my perspective and has already caught a few issues in the
>> last couple of weeks.
>>
> 
> Thanks Sean. This is all looking really good. I think this stuff is
> ready to be sent to the mailing list for wider review.
> 
>> Finally there are a few pending bugs that should get fixed and at
>> least a couple of gaps I have identified. These are not fixed in the
>> above 14 commits.
>>
>>  1. OvmfPkg
>>      1. https://bugzilla.tianocore.org/show_bug.cgi?id=2662 -- Blocking
>>         Core CI
>>      2. https://bugzilla.tianocore.org/show_bug.cgi?id=2661 -- Blocking

Thanks Sean!

I've posted a patch for 2662, and commented on 2661.

>>         Platform CI
>>      3. Spell check in audit mode
>>  2. EmulatorPkg
>>      1. https://bugzilla.tianocore.org/show_bug.cgi?id=2663 -- Ignore
>>         added to Core CI
>>      2. https://bugzilla.tianocore.org/show_bug.cgi?id=2639 -- Feature
>>         in Platform CI turned off
>>      3. https://bugzilla.tianocore.org/show_bug.cgi?id=2638 -- Feature
>>         in Platform CI turned off
>>      4. Spell check in audit mode
>>  3. ArmVirtPkg
>>      1. No builds on Windows or with VS toolchain -- Feature in Platform
>>         CI turned off

For the ArmVirtPkg "README-pytools.md" file, I have a superficial comment:

The "E1000_ENABLE" reference may not be the best example (I understand
it's an example) with ArmVirtPkg, as E1000_ENABLE isn't actually used in
the ArmVirtPkg DSC/FDF files.

Thanks
Laszlo

> 
> Leif has looked into this in the past. As I understand it, it is simply
> a lack of .asm versions of the various assembler source files in ArmLib,
> ArmMmuLib and the startup code in ArmPlatformPkg.
> 
> 
>