From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.120]) by mx.groups.io with SMTP id smtpd.web12.8784.1586265716854740425 for ; Tue, 07 Apr 2020 06:21:57 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=SRzX9H6w; spf=pass (domain: redhat.com, ip: 207.211.31.120, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1586265716; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=ZIrxgbfV9igwfN+RX3F3Av9pQeQrYFY56BMPrut1MXw=; b=SRzX9H6wQDr3kscPoUh+7yVQpuTpmU+crICC3GXpyTHZIjJKUiN6mS4iYSKDDdl0KBkE58 h8wBJ9/ZULD892C1E9ShugI26Wdh1WVybFwbwxH4wvSb9MPBSKcsm2+190a6+FN5vBEg11 u8KCSnQ/aCPhq+cLPD4T9wZXwNNAGlI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-453-N7CHcOwzO9-FT4gbjrHO2w-1; Tue, 07 Apr 2020 09:21:47 -0400 X-MC-Unique: N7CHcOwzO9-FT4gbjrHO2w-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A53098018A4; Tue, 7 Apr 2020 13:21:46 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-240.ams2.redhat.com [10.36.112.240]) by smtp.corp.redhat.com (Postfix) with ESMTP id 2EE24B19D7; Tue, 7 Apr 2020 13:21:45 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH] .azurepipelines: Enable CI for OvmfPkg and EmulatorPkg To: devel@edk2.groups.io, ard.biesheuvel@arm.com, sean.brogan@microsoft.com Cc: Leif Lindholm References: <14537.1585602191842859281@groups.io> <22879.1586068785483835499@groups.io> <5d642758-d8f1-ef6d-8ca8-229ff496a893@arm.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 7 Apr 2020 15:21:44 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <5d642758-d8f1-ef6d-8ca8-229ff496a893@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 04/06/20 12:11, Ard Biesheuvel wrote: > On 4/5/20 8:39 AM, Sean via groups.io wrote: >> Platform and Core CI patches are ready for review.=C2=A0 I have 14 commi= ts >> here. >> https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmu= latorPackages >> >> >> This adds support for "Platform CI" for ArmVirtPkg, OvmfPkg, and >> EmulatorPkg. >> Each readme has live status and links to the builds as well as details >> of how to build and run the same way the CI server will. >> ArmVirt: >> https://github.com/spbrogan/edk2/blob/PlatformAndCoreCIForOvmfArmVirtEmu= latorPackages/ArmVirtPkg/README-pytools.md >> >> Emulator: >> https://github.com/spbrogan/edk2/blob/PlatformAndCoreCIForOvmfArmVirtEmu= latorPackages/EmulatorPkg/README-pytools.md >> >> OvmfPkg: >> https://github.com/spbrogan/edk2/blob/PlatformAndCoreCIForOvmfArmVirtEmu= latorPackages/OvmfPkg/README-pytools.md >> >> >> It also adds ArmVirtPkg, OvmfPkg, and EmulatorPkg to Core CI just for >> the code evaluation tests (not compiling).=C2=A0 Details of those tests = are >> here: >> https://github.com/spbrogan/edk2/tree/PlatformAndCoreCIForOvmfArmVirtEmu= latorPackages/.pytool >> >> >> ArmVirtPkg, OvmfPkg, and EmulatorPkg maintainers please review and let >> me know what the next step for you package is.=C2=A0 This is ready to >> commit from my perspective and has already caught a few issues in the >> last couple of weeks. >> >=20 > Thanks Sean. This is all looking really good. I think this stuff is > ready to be sent to the mailing list for wider review. >=20 >> Finally there are a few pending bugs that should get fixed and at >> least a couple of gaps I have identified. These are not fixed in the >> above 14 commits. >> >> =C2=A01. OvmfPkg >> =C2=A0=C2=A0=C2=A0=C2=A0 1. https://bugzilla.tianocore.org/show_bug.cgi?= id=3D2662=C2=A0-- Blocking >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Core CI >> =C2=A0=C2=A0=C2=A0=C2=A0 2. https://bugzilla.tianocore.org/show_bug.cgi?= id=3D2661=C2=A0-- Blocking Thanks Sean! I've posted a patch for 2662, and commented on 2661. >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 Platform CI >> =C2=A0=C2=A0=C2=A0=C2=A0 3. Spell check in audit mode >> =C2=A02. EmulatorPkg >> =C2=A0=C2=A0=C2=A0=C2=A0 1. https://bugzilla.tianocore.org/show_bug.cgi?= id=3D2663=C2=A0-- Ignore >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 added to Core CI >> =C2=A0=C2=A0=C2=A0=C2=A0 2. https://bugzilla.tianocore.org/show_bug.cgi?= id=3D2639=C2=A0-- Feature >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 in Platform CI turned off >> =C2=A0=C2=A0=C2=A0=C2=A0 3. https://bugzilla.tianocore.org/show_bug.cgi?= id=3D2638=C2=A0-- Feature >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 in Platform CI turned off >> =C2=A0=C2=A0=C2=A0=C2=A0 4. Spell check in audit mode >> =C2=A03. ArmVirtPkg >> =C2=A0=C2=A0=C2=A0=C2=A0 1. No builds on Windows or with VS toolchain --= Feature in Platform >> =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 CI turned off For the ArmVirtPkg "README-pytools.md" file, I have a superficial comment: The "E1000_ENABLE" reference may not be the best example (I understand it's an example) with ArmVirtPkg, as E1000_ENABLE isn't actually used in the ArmVirtPkg DSC/FDF files. Thanks Laszlo >=20 > Leif has looked into this in the past. As I understand it, it is simply > a lack of .asm versions of the various assembler source files in ArmLib, > ArmMmuLib and the startup code in ArmPlatformPkg. >=20 >=20 >=20