From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out2-smtp.messagingengine.com (out2-smtp.messagingengine.com [66.111.4.26]) by mx.groups.io with SMTP id smtpd.web09.370.1651608492398446675 for ; Tue, 03 May 2022 13:08:12 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm2 header.b=EK393BIk; spf=pass (domain: bsdio.com, ip: 66.111.4.26, mailfrom: rebecca@bsdio.com) Received: from compute3.internal (compute3.nyi.internal [10.202.2.43]) by mailout.nyi.internal (Postfix) with ESMTP id B81835C0189; Tue, 3 May 2022 16:08:11 -0400 (EDT) Received: from mailfrontend2 ([10.202.2.163]) by compute3.internal (MEProxy); Tue, 03 May 2022 16:08:11 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:date:date:from:from :in-reply-to:in-reply-to:message-id:mime-version:references :reply-to:sender:subject:subject:to:to; s=fm2; t=1651608491; x= 1651694891; bh=PIJIuw02whfhVYm5W3ZYsb8Qj44Gklcxm/Rn7+IrnVc=; b=E K393BIkyocJ9DcwUqbKoCcXUIX8wyIzwXKbfnNoixviI3CrivS9BV37JmxuxklbL VsVTXZ13VFZQsV4Rro9zuxyovw07lpLIfmP9JRMdH8UdbytxnZ3xkqjfsnucdhcH SUtrPGXOHW2nBeFnklajsX3z1OYwymHqdw0ypfQ1Gtc/SkgaiMDHgvEUyuo7OvLg DCPFwKp8Zx+JwefnmCuRjmaVcqk86InUkZ5JC7ppGuteBPQdPYRs2itFBhi+kqC7 ha/aS6pmbv/oqk6zlzr45qZ+2DodkGLfOnwg1xFNI91FwjPMG5lPWUX9MEY3yUdM wN8IoIv7cM22l+l99IYxA== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:date:date:from:from:in-reply-to:in-reply-to :message-id:mime-version:references:reply-to:sender:subject :subject:to:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm1; t=1651608491; x=1651694891; bh=PIJIuw02whfhV Ym5W3ZYsb8Qj44Gklcxm/Rn7+IrnVc=; b=dT6Zu3O8jMjjUu5bxcCldvW/t0V9h gUPyMB5Oj0h5ZyJfJga9BIa0y3NWidlYpIgZktowxV0RKFTVTXm0NPyoMto0lJpi 4Rw4RXiM+nafXtSht36P2nxlQbMjJUKlafMfRI9oH+eQSuPkOxptTi29A+4XhFAr M0iPGUuxLij6Xm02GfYbx1w6itdSAY6bpY6sNn3Lb/X/ptbI01619F+AXDVOEMvt gaupPenkNzwFg/FW418aqcohWwMCXAMVDnfov5llgDLICMdeZ8inViEJ3ymwNxut WNMsbKdqO11OLr5dFxHgynYVUFsyp8EWzu17ha2GxCyh5lBWru9EEoezw== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvfedrvdejgddugeeiucetufdoteggodetrfdotf fvucfrrhhofhhilhgvmecuhfgrshhtofgrihhlpdfqfgfvpdfurfetoffkrfgpnffqhgen uceurghilhhouhhtmecufedttdenucesvcftvggtihhpihgvnhhtshculddquddttddmne cujfgurhepkfffgggfuffvvehfhfgjtgfgsehtjeertddtfeejnecuhfhrohhmpeftvggs vggttggrucevrhgrnhcuoehrvggsvggttggrsegsshguihhordgtohhmqeenucggtffrrg htthgvrhhnpeegteelffelleettdeuleeuhfejheejhfefkeekjeelteehheefgeffleet gfeuveenucffohhmrghinhepghhrohhuphhsrdhiohenucevlhhushhtvghrufhiiigvpe dtnecurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 3 May 2022 16:08:11 -0400 (EDT) Message-ID: Date: Tue, 3 May 2022 14:08:10 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [edk2-devel] [PATCH 1/1] ArmPlatformPkg: Comment out overly verbose DEBUG lines in LcdGraphicsBlt To: Ard Biesheuvel , edk2-devel-groups-io Cc: Leif Lindholm , Ard Biesheuvel References: <20220503193106.9394-1-rebecca@bsdio.com> From: "Rebecca Cran" In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit I think with the PL111 being such old technology now it should be safe to just remove them. -- Rebecca Cran On 5/3/22 13:43, Ard Biesheuvel wrote: > Hi Rebecca, > > On Tue, 3 May 2022 at 21:31, Rebecca Cran wrote: >> The DEBUG output in LcdGraphicsBlt is overly verbose, and makes using >> the console difficult, for example when using the UiApp. >> >> To allow for easy inclusion for future debugging, comment out but don't >> remove the DEBUG lines. >> > I'd suggest to either demote the debug level to DEBUG_VERBOSE, or > simply remove them, instead of using comments like this. > >> Signed-off-by: Rebecca Cran >> --- >> ...utBlt.c | 22 +++--- >> 1 file changed, 11 insertions(+), 11 deletions(-) >> >> diff --git a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c >> index 01ec6f68bd93..4766d72cef28 100644 >> --- a/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c >> +++ b/ArmPlatformPkg/Drivers/LcdGraphicsOutputDxe/LcdGraphicsOutputBlt.c >> @@ -815,17 +815,17 @@ LcdGraphicsBlt ( >> HorizontalResolution = This->Mode->Info->HorizontalResolution; >> VerticalResolution = This->Mode->Info->VerticalResolution; >> >> - DEBUG (( >> - DEBUG_INFO, >> - "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n", >> - BltOperation, >> - DestinationX, >> - DestinationY, >> - Width, >> - Height, >> - HorizontalResolution, >> - VerticalResolution >> - )); >> +// DEBUG (( >> +// DEBUG_INFO, >> +// "LcdGraphicsBlt (BltOperation:%d,DestX:%d,DestY:%d,Width:%d,Height:%d) res(%d,%d)\n", >> +// BltOperation, >> +// DestinationX, >> +// DestinationY, >> +// Width, >> +// Height, >> +// HorizontalResolution, >> +// VerticalResolution >> +// )); >> >> // Check we have reasonable parameters >> if ((Width == 0) || (Height == 0)) { >> -- >> 2.25.1 >> >> >> >> >> >>