From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web10.30280.1601885959597738318 for ; Mon, 05 Oct 2020 01:19:19 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=Fm2gy+do; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1601885958; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:autocrypt:autocrypt; bh=5rhYawvRS+4UeI1C5L5XU+PaRJBmYHIEUzX9jS9VUgg=; b=Fm2gy+doeIJ+O5PLZCyC9fZrK4m3jnzBan1O0li9+pR5UjkXzOI+7m3jyyu/b3IeU2C1IT jgPc5WGmhZOk5LhwR1BFLbUtdRdoclOT3C4OeUF7/1KpSlvIMS9/dasVbHifDO5WmRbs0r lp0HLinZmwLXiOO4VNzxRYQI8hv4Guo= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-490-posOY3-cN5yI9v6IiePE8Q-1; Mon, 05 Oct 2020 04:19:17 -0400 X-MC-Unique: posOY3-cN5yI9v6IiePE8Q-1 Received: by mail-wm1-f72.google.com with SMTP id f2so1475009wml.6 for ; Mon, 05 Oct 2020 01:19:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:autocrypt :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=5rhYawvRS+4UeI1C5L5XU+PaRJBmYHIEUzX9jS9VUgg=; b=AvwnDm9IVMMlUyt9ki4HJZwHqhqssobcPLHIrfofNKDGQQ49xqEhmDp1zoxHmOGRC0 DF5RV3XJxzfhLGGqtWoHmJPUiuh67RTyStqm9O0Whb+HVpi7X6ayTaGrKbAsmtpfPqRH zqyNFjrm/ekNyKFCWzzHWt2qyzFUUWZNRe9JcttcZZJJs3piTmz/NCmevFMCtX2jnhv0 Vjxq0bg30IkwSz5Ie8s0jax66Zrqy8of1DOAXI0/qloW8rvmDubDcMTOTWYYWDVHxWc8 8BJlziBgNgb9ZSp7JKdkMFShog3EYiHjcAFYSE3oizClaWhU+xeDBPGm17SZym9RzmwF 7rdQ== X-Gm-Message-State: AOAM5319YhGstxHOZ8qb5uhmHtdHS+K2TByUxobWTcTXHw3oH9zarh2a wt9rEdK2bIQjemxWnYUV2BZZSchhT6s+aMt3Y+TJYKdHE/WrC6dJEfcRgEnn1yGVpmtfdgCyDQs HdXL61j3ViWUq4Q== X-Received: by 2002:a1c:8056:: with SMTP id b83mr10720631wmd.124.1601885956135; Mon, 05 Oct 2020 01:19:16 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx/3FoJJTpRFTs/ULKr0TGekXLuGniSrXfdvn47YOKgIll6dIS8h43ScvH22BAv0eDw0Pm9WQ== X-Received: by 2002:a1c:8056:: with SMTP id b83mr10720604wmd.124.1601885955923; Mon, 05 Oct 2020 01:19:15 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (106.red-83-59-162.dynamicip.rima-tde.net. [83.59.162.106]) by smtp.gmail.com with ESMTPSA id s19sm7885471wmc.41.2020.10.05.01.19.14 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 05 Oct 2020 01:19:15 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH 4/5] MdePkg/BaseLib: correct register sizes in AArch64 SetJump/LongJump To: devel@edk2.groups.io, leif@nuviainc.com Cc: Ard Biesheuvel , Michael D Kinney , Liming Gao , Zhiguang Liu References: <20201001183712.1738-1-leif@nuviainc.com> <20201001183712.1738-5-leif@nuviainc.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Autocrypt: addr=philmd@redhat.com; keydata= mQINBDXML8YBEADXCtUkDBKQvNsQA7sDpw6YLE/1tKHwm24A1au9Hfy/OFmkpzo+MD+dYc+7 bvnqWAeGweq2SDq8zbzFZ1gJBd6+e5v1a/UrTxvwBk51yEkadrpRbi+r2bDpTJwXc/uEtYAB GvsTZMtiQVA4kRID1KCdgLa3zztPLCj5H1VZhqZsiGvXa/nMIlhvacRXdbgllPPJ72cLUkXf z1Zu4AkEKpccZaJspmLWGSzGu6UTZ7UfVeR2Hcc2KI9oZB1qthmZ1+PZyGZ/Dy+z+zklC0xl XIpQPmnfy9+/1hj1LzJ+pe3HzEodtlVA+rdttSvA6nmHKIt8Ul6b/h1DFTmUT1lN1WbAGxmg CH1O26cz5nTrzdjoqC/b8PpZiT0kO5MKKgiu5S4PRIxW2+RA4H9nq7nztNZ1Y39bDpzwE5Sp bDHzd5owmLxMLZAINtCtQuRbSOcMjZlg4zohA9TQP9krGIk+qTR+H4CV22sWldSkVtsoTaA2 qNeSJhfHQY0TyQvFbqRsSNIe2gTDzzEQ8itsmdHHE/yzhcCVvlUzXhAT6pIN0OT+cdsTTfif MIcDboys92auTuJ7U+4jWF1+WUaJ8gDL69ThAsu7mGDBbm80P3vvUZ4fQM14NkxOnuGRrJxO qjWNJ2ZUxgyHAh5TCxMLKWZoL5hpnvx3dF3Ti9HW2dsUUWICSQARAQABtDJQaGlsaXBwZSBN YXRoaWV1LURhdWTDqSAoUGhpbCkgPHBoaWxtZEByZWRoYXQuY29tPokCVQQTAQgAPwIbDwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4AWIQSJweePYB7obIZ0lcuio/1u3q3A3gUCXsfWwAUJ KtymWgAKCRCio/1u3q3A3ircD/9Vjh3aFNJ3uF3hddeoFg1H038wZr/xi8/rX27M1Vj2j9VH 0B8Olp4KUQw/hyO6kUxqkoojmzRpmzvlpZ0cUiZJo2bQIWnvScyHxFCv33kHe+YEIqoJlaQc JfKYlbCoubz+02E2A6bFD9+BvCY0LBbEj5POwyKGiDMjHKCGuzSuDRbCn0Mz4kCa7nFMF5Jv piC+JemRdiBd6102ThqgIsyGEBXuf1sy0QIVyXgaqr9O2b/0VoXpQId7yY7OJuYYxs7kQoXI 6WzSMpmuXGkmfxOgbc/L6YbzB0JOriX0iRClxu4dEUg8Bs2pNnr6huY2Ft+qb41RzCJvvMyu gS32LfN0bTZ6Qm2A8ayMtUQgnwZDSO23OKgQWZVglGliY3ezHZ6lVwC24Vjkmq/2yBSLakZE 6DZUjZzCW1nvtRK05ebyK6tofRsx8xB8pL/kcBb9nCuh70aLR+5cmE41X4O+MVJbwfP5s/RW 9BFSL3qgXuXso/3XuWTQjJJGgKhB6xXjMmb1J4q/h5IuVV4juv1Fem9sfmyrh+Wi5V1IzKI7 RPJ3KVb937eBgSENk53P0gUorwzUcO+ASEo3Z1cBKkJSPigDbeEjVfXQMzNt0oDRzpQqH2vp apo2jHnidWt8BsckuWZpxcZ9+/9obQ55DyVQHGiTN39hkETy3Emdnz1JVHTU0Q== Message-ID: Date: Mon, 5 Oct 2020 10:19:14 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 MIME-Version: 1.0 In-Reply-To: <20201001183712.1738-5-leif@nuviainc.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/1/20 8:37 PM, Leif Lindholm wrote: > Both in SetJump and in InternalLongJump, 32-bit w register views were > used for the UINTN return value. In SetJump, this did not cause errors; > it was only counterintuitive. But in InternalLongJump, it meant the top Typo "counter-intuitive". > 32 bits of Value were stripped off. > > Change all of these to use the 64-bit x register views. > > Signed-off-by: Leif Lindholm > --- > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.S | 8 ++++---- > MdePkg/Library/BaseLib/AArch64/SetJumpLongJump.asm | 8 ++++---- > 2 files changed, 8 insertions(+), 8 deletions(-) Reviewed-by: Philippe Mathieu-Daude