Hi Gerd,


Thanks,
Chao
On 2024/3/14 18:52, Gerd Hoffmann wrote:
>    Hi,
>
>>   [LibraryClasses]
>>     BaseLib
>> +  CcExitLib
>> +  CpuLib
>> +  DebugAgentLib
>> +  HobLib
>>     LocalApicLib
>>     MemoryAllocationLib
>> -  HobLib
>> +  MicrocodeLib
>>     MtrrLib
>> -  CpuLib
>> -  UefiBootServicesTableLib
>> -  DebugAgentLib
>> -  SynchronizationLib
>>     PcdLib
>> -  CcExitLib
>> -  MicrocodeLib
>> +  SynchronizationLib
>> +  UefiBootServicesTableLib
>>   [LibraryClasses.X64]
>>     CpuPageTableLib
> While being at it you could also add an empty line
> before the new section.
Ok, I will add an empty line next time.
>
>> -  Microcode.c
>>     MpHandOff.h
>> +  PeiMpLib.c
>>   [Packages]
>>     MdePkg/MdePkg.dec
> Same here.
OK.
>
> Not a bug in this patch but a pre-existing issue, so:
> Acked-by: Gerd Hoffmann<kraxel@redhat.com>
>
> take care,
>    Gerd
>
>
>
> 
>


-=-=-=-=-=-=-=-=-=-=-=-
Groups.io Links: You receive all messages sent to this group.
View/Reply Online (#116781): https://edk2.groups.io/g/devel/message/116781
Mute This Topic: https://groups.io/mt/104859868/7686176
Group Owner: devel+owner@edk2.groups.io
Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io]
-=-=-=-=-=-=-=-=-=-=-=-