From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id 527BCD811C0 for ; Fri, 15 Mar 2024 06:16:20 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=yxzGjKvouQdhHqwn72Nlhs1qUBJV1UglaRu6mZkTQgE=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type; s=20240206; t=1710483378; v=1; b=i58OUeovHL62eTPAC9wafSCYzUNtwiH83UZg5TwHmKpqvfyyImMwMSjxPVlf+ZgKrcL6/EQv pvTp5S0saVYDuYA9cwGNXybZrtOSDebsmAuMqfVGpfEdyaJGpQLJ6GE6gHuhJMD1dxjeHWB2I2r +x2uST+/X+nubI7p0ruB5pElZcrA5XRE/HNe+BFLgQ7ZWDv+EJ97J/cMyrQL6Su+1kH116pDnCQ iUWgBMrOeW+bbl60Vp1Uo2gZaT7EykAzoARKydK5nnMvsEUBgQjDR++nyxtW5b7QW+eczUn/M6v D5bfiAdDPxle6+b4kiyKnih60njDnAXX24TjqSCvScrIQ== X-Received: by 127.0.0.2 with SMTP id YDSGYY7687511xio2mSCQwKT; Thu, 14 Mar 2024 23:16:18 -0700 X-Received: from mail.loongson.cn (mail.loongson.cn [114.242.206.163]) by mx.groups.io with SMTP id smtpd.web11.14244.1710483376867408336 for ; Thu, 14 Mar 2024 23:16:17 -0700 X-Received: from loongson.cn (unknown [10.40.24.149]) by gateway (Coremail) with SMTP id _____8AxOOir5_NlSV8ZAA--.41585S3; Fri, 15 Mar 2024 14:16:11 +0800 (CST) X-Received: from [10.40.24.149] (unknown [10.40.24.149]) by localhost.localdomain (Coremail) with SMTP id AQAAf8CxrhOm5_NlNbtaAA--.52146S3; Fri, 15 Mar 2024 14:16:06 +0800 (CST) Message-ID: Date: Fri, 15 Mar 2024 14:16:06 +0800 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [PATCH v1 03/26] UefiCpuPkg/MpInitLib: Reorder the INF files alphabetically To: devel@edk2.groups.io, kraxel@redhat.com Cc: Ray Ni , Rahul Kumar References: <20240311093631.1251466-1-lichao@loongson.cn> <20240311093740.1252661-1-lichao@loongson.cn> From: "Chao Li" In-Reply-To: X-CM-TRANSID: AQAAf8CxrhOm5_NlNbtaAA--.52146S3 X-CM-SenderInfo: xolfxt3r6o00pqjv00gofq/1tbiAQARCGXytWcNeAAAso X-Coremail-Antispam: 1Uk129KBj9xXoWrtFy3Kr4DJw4DKr4rWr48uFX_yoWkArX_Gr yUXrW7A3Wktr17Wr4jqF1ftFsakwsrZ345J39Fqan3AFWvka1DAas3J3yjgr18J343ur15 GrykKa1FyryrtosvyTuYvTs0mTUanT9S1TB71UUUUU7qnTZGkaVYY2UrUUUUj1kv1TuYvT s0mT0YCTnIWjDUYxn0WfASr-VFAUDa7-sFnT9fnUUIcSsGvfJTRUUUbzkYFVCjjxCrM7AC 8VAFwI0_Jr0_Gr1l1xkIjI8I6I8E6xAIw20EY4v20xvaj40_Wr0E3s1l1IIY67AEw4v_Jr v_JF1l8cAvFVAK0II2c7xJM28CjxkF64kEwVA0rcxSw2x7M28EF7xvwVC0I7IYx2IY67AK xVWUJVWUCwA2z4x0Y4vE2Ix0cI8IcVCY1x0267AKxVWUJVW8JwA2z4x0Y4vEx4A2jsIE14 v26r4UJVWxJr1l84ACjcxK6I8E87Iv6xkF7I0E14v26r4UJVWxJr1le2I262IYc4CY6c8I j28IcVAaY2xG8wAqjxCEc2xF0cIa020Ex4CE44I27wAv7VC0I7IYx2IY67AKxVWUGVWUXw Av7VC2z280aVAFwI0_Jr0_Gr1lOx8S6xCaFVCjc4AY6r1j6r4UM4x0Y48IcVAKI48JMx8G jcxK6IxK0xIIj40E5I8CrwCF04k20xvY0x0EwIxGrwCFx2IqxVCFs4IE7xkEbVWUJVW8Jw C20s026c02F40E14v26r106r1rMI8I3I0E7480Y4vE14v26r106r1rMI8E67AF67kF1VAF wI0_JF0_Jw1lIxkGc2Ij64vIr41lIxAIcVC0I7IYx2IY67AKxVWUJVWUCwCI42IY6xIIjx v20xvEc7CjxVAFwI0_Jr0_Gr1lIxAIcVCF04k26cxKx2IYs7xG6r1j6r1xMIIF0xvEx4A2 jsIE14v26r1j6r4UMIIF0xvEx4A2jsIEc7CjxVAFwI0_Gr0_Gr1UYxBIdaVFxhVjvjDU0x ZFpf9x07UAWrXUUUUU= Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Thu, 14 Mar 2024 23:16:17 -0700 Reply-To: devel@edk2.groups.io,lichao@loongson.cn List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: 4DWtn0UU0cMaGyOhVsv2ieGkx7686176AA= Content-Type: multipart/alternative; boundary="------------EwjbDZ2jlG0KD3QeCoL5D4qh" X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240206 header.b=i58OUeov; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io; dmarc=none --------------EwjbDZ2jlG0KD3QeCoL5D4qh Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: quoted-printable Hi Gerd, Thanks, Chao On 2024/3/14 18:52, Gerd Hoffmann wrote: > Hi, > >> [LibraryClasses] >> BaseLib >> + CcExitLib >> + CpuLib >> + DebugAgentLib >> + HobLib >> LocalApicLib >> MemoryAllocationLib >> - HobLib >> + MicrocodeLib >> MtrrLib >> - CpuLib >> - UefiBootServicesTableLib >> - DebugAgentLib >> - SynchronizationLib >> PcdLib >> - CcExitLib >> - MicrocodeLib >> + SynchronizationLib >> + UefiBootServicesTableLib >> [LibraryClasses.X64] >> CpuPageTableLib > While being at it you could also add an empty line > before the new section. Ok, I will add an empty line next time. > >> - Microcode.c >> MpHandOff.h >> + PeiMpLib.c >> [Packages] >> MdePkg/MdePkg.dec > Same here. OK. > > Not a bug in this patch but a pre-existing issue, so: > Acked-by: Gerd Hoffmann > > take care, > Gerd > > > >=20 > -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#116781): https://edk2.groups.io/g/devel/message/116781 Mute This Topic: https://groups.io/mt/104859868/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- --------------EwjbDZ2jlG0KD3QeCoL5D4qh Content-Type: text/html; charset=UTF-8 Content-Transfer-Encoding: quoted-printable

Hi Gerd,


=
Thanks,
Chao
On 2024/3/14 18:52, Gerd Hoffmann wrote:
  Hi,


 [LibraryClasses]
   BaseLib
+  CcExitLib
+  CpuLib
+  DebugAgentLib
+  HobLib
   LocalApicLib
   MemoryAllocationLib
-  HobLib
+  MicrocodeLib
   MtrrLib
-  CpuLib
-  UefiBootServicesTableLib
-  DebugAgentLib
-  SynchronizationLib
   PcdLib
-  CcExitLib
-  MicrocodeLib
+  SynchronizationLib
+  UefiBootServicesTableLib
 [LibraryClasses.X64]
   CpuPageTableLib

While being at it you could also add an empty line
before the new section.
Ok, I will add an empty line next time.


-  Microcode.c
   MpHandOff.h
+  PeiMpLib.c
 [Packages]
   MdePkg/MdePkg.dec

Same here.
OK.

Not a bug in this patch but a pre-existing issue, so:
Acked-by: Gerd Hoffmann <kraxel@redhat.com>

take care,
  Gerd
_._,_._,_
Groups.io Links:

=20 You receive all messages sent to this group. =20 =20

View/Reply Online (#116781) | =20 | Mute= This Topic | New Topic
Your Subscriptio= n | Contact Group Owner | Unsubscribe [rebecca@openfw.io]

_._,_._,_
--------------EwjbDZ2jlG0KD3QeCoL5D4qh--