public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: Zhiguang Liu <zhiguang.liu@intel.com>, devel@edk2.groups.io
Cc: Liming Gao <liming.gao@intel.com>,
	Jian J Wang <jian.j.wang@intel.com>,
	Hao A Wu <hao.a.wu@intel.com>,
	Leif Lindholm <leif.lindholm@linaro.org>
Subject: Re: [Patch V3 1/2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore
Date: Mon, 25 Nov 2019 09:06:10 +0100	[thread overview]
Message-ID: <c5dcde15-3b39-a4eb-1e0a-48df6b4a9ded@redhat.com> (raw)
In-Reply-To: <20191125015732.35208-1-zhiguang.liu@intel.com>

On 11/25/19 2:57 AM, Zhiguang Liu wrote:
> After unifying the definition of size_t, EBC compiler has failure.
> So don't compile this inf file for EBC
> 
> REF:https://bugzilla.tianocore.org/show_bug.cgi?id=2338
> 
> Cc: Liming Gao <liming.gao@intel.com>
> Cc: Jian J Wang <jian.j.wang@intel.com>
> Cc: Hao A Wu <hao.a.wu@intel.com>
> Cc: Leif Lindholm <leif.lindholm@linaro.org>
> Cc: Philippe Mathieu-Daudé <philmd@redhat.com>
> Reviewed-by: Liming Gao <liming.gao@intel.com>
> 
> Signed-off-by: Zhiguang Liu <zhiguang.liu@intel.com>
> ---
>   MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf | 2 +-
>   MdeModulePkg/MdeModulePkg.dsc                                            | 2 +-
>   2 files changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> index 42b741c64b..e8061f54f9 100644
> --- a/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> +++ b/MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
> @@ -25,7 +25,7 @@
>   #
>   # The following information is for reference only and not required by the build tools.
>   #
> -#  VALID_ARCHITECTURES           = IA32 X64 EBC
> +#  VALID_ARCHITECTURES           = IA32 X64
>   #
>   
>   [Sources]
> diff --git a/MdeModulePkg/MdeModulePkg.dsc b/MdeModulePkg/MdeModulePkg.dsc
> index 4320839abf..f7dbb27ce2 100644
> --- a/MdeModulePkg/MdeModulePkg.dsc
> +++ b/MdeModulePkg/MdeModulePkg.dsc
> @@ -299,7 +299,6 @@
>     MdeModulePkg/Library/PeiDebugPrintHobLib/PeiDebugPrintHobLib.inf
>     MdeModulePkg/Library/CpuExceptionHandlerLibNull/CpuExceptionHandlerLibNull.inf
>     MdeModulePkg/Library/PlatformHookLibSerialPortPpi/PlatformHookLibSerialPortPpi.inf
> -  MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>     MdeModulePkg/Library/PeiDxeDebugLibReportStatusCode/PeiDxeDebugLibReportStatusCode.inf
>     MdeModulePkg/Library/PeiDebugLibDebugPpi/PeiDebugLibDebugPpi.inf
>     MdeModulePkg/Library/UefiBootManagerLib/UefiBootManagerLib.inf
> @@ -433,6 +432,7 @@
>   
>   [Components.IA32, Components.X64, Components.ARM, Components.AARCH64]
>     MdeModulePkg/Library/BrotliCustomDecompressLib/BrotliCustomDecompressLib.inf
> +  MdeModulePkg/Library/LzmaCustomDecompressLib/LzmaCustomDecompressLib.inf
>     MdeModulePkg/Library/VarCheckUefiLib/VarCheckUefiLib.inf
>     MdeModulePkg/Core/Dxe/DxeMain.inf {
>       <LibraryClasses>
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


  reply	other threads:[~2019-11-25  8:06 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25  1:57 [Patch V3 1/2] MdeModulePkg: LzmaCustomDecompressLib.inf don't support EBC anymore Zhiguang Liu
2019-11-25  8:06 ` Philippe Mathieu-Daudé [this message]
2019-12-03  7:58 ` [edk2-devel] " Liming Gao

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c5dcde15-3b39-a4eb-1e0a-48df6b4a9ded@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox