Re: [PATCH 2/3] OvmfPkg: introduce FD_SIZE_4MB (mainly) for Windows HCK

[Laszlo Ersek <lersek@redhat.com>]

On 05/02/17 01:38, Jordan Justen wrote:
> On 2017-05-01 16:07:48, Laszlo Ersek wrote:
>> On 05/01/17 21:20, Jordan Justen wrote:
>>>
>>> At this I'd just like figure out what to do about the 4MB layout, so
>>> can we stop getting worked up over this side show?
>>
>> Thanks for calling it a side show, real friendly.
> 
> Ok, I apologize. The 'side show' comment applies equally to me. Can we
> please just move on? We obviously disagree how to determine how full
> 2MB is, but it doesn't much matter since you'll soon be abandoning it
> entirely. We have too much room in the 4MB fridge to be concerned
> about this.

OK.

I wouldn't mind if we made more room for the varstore in the 2MB build,
even at the expense of FVMAIN_COMPACT, if we also kept the current 2MB
build the default, so that the "new" (incompatible) 2MB build doesn't
come as a surprise to unsuspecting downstreams.

Regarding the 4MB build:
- we can discuss that on top of the above "new" 2MB build,
- we can discuss it instead of the above "new" 2MB build,
- we can postpone it for now, for upstream.

If you do agree that a 4MB build should be offered in upstream, then I'm
proposing my proposal (obviously :) ). If your main focus is the "new"
2MB build, and beause mine is the 4MB build, perhaps we aren't even
disagreeing as much, since this doesn't have to be an either-or. If you
have specific observations for the 4MB structure I proposed, I'd be glad
to hear those as well.

> 
>> The only email (that I can see) in this thread that I haven't reacted to is:
>>
>> http://mid.mail-archive.com/149365894632.25909.11739243410891079091@jljusten-skl
>>
>> where you wrote "I'd rather go with 128k, and I'd also rather stay with
>> 2MB".
> 
> You dropped my ":)" :)
> 
> Ok, me adding that was a poor choice, despite including a smiley. I
> meant to convey was: "Ok, fine, let's figure out the 4MB layout, but I
> still want to whine about it a little more."

I'm sorry that my irony-meter failed (I hope this isn't a poor choice of
words); the downstream deadlines are really close, I'd been working day
and night over the weekend, and I mistook the smiley for "I'll never
agree with you on this, but here's a smiley to take the edge off".

Thanks,
Laszlo