From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail05.groups.io (mail05.groups.io [45.79.224.7]) by spool.mail.gandi.net (Postfix) with ESMTPS id 6AC4AAC1B8F for ; Tue, 28 Jan 2025 22:06:45 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=pHLbpjgb/+f+2k6f++8b44jQ/N0Nez9O99AN0fZs8Og=; c=relaxed/simple; d=groups.io; h=Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc:References:From:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Resent-Date:Resent-From:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Language:Content-Type:Content-Transfer-Encoding; s=20240830; t=1738102005; v=1; x=1738361204; b=Qd78LLTX0koXohkCEMeyFxxLuBo5zuM0PLgSNm1cwt9XDhwMq56T0M7UyYaJkam5L9mugz0T 53q5we03gdye9oa3IY0ZSIxcjHzBXIQ2kAVEgAPjW62jJDGCdjzAVQPGtwU2CcNJtcLNFE5Hepl E8qhDEkWLkVbVFWq/iZp6lyDnl0gyXljDUphoMpIjXYzv/knPaUbO7xukoJ9qbpPu52Y1+18SZh FXN6+cFJtf2E9dAKfNNMAAphJ1mi72/jm+StWGaDDOHr07bQBwq1PRBVwBx47GoS5ptwFSIkQzW SQfdH3p9tIeiTgR/NR2hmfZ1/ncPMjZFVXg2kn8KPk8sQ== X-Received: by 127.0.0.2 with SMTP id J9L0YY7687511xZA05x9VffI; Tue, 28 Jan 2025 14:06:44 -0800 X-Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) by mx.groups.io with SMTP id smtpd.web11.35002.1737373725012567651 for ; Mon, 20 Jan 2025 03:48:45 -0800 X-Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-aae81f4fdc4so887655766b.0 for ; Mon, 20 Jan 2025 03:48:44 -0800 (PST) X-Forwarded-Encrypted: i=1; AJvYcCWcrs4F2y60DgsViuTA6X6uQE4gejRghiX68QQOokg1iHfuuQPSVRUC36H9pOmXK3oXzFvLuA==@edk2.groups.io X-Gm-Message-State: TR0HrkzKmFxAnNlkZ6q0HVUNx7686176AA= X-Gm-Gg: ASbGncsn0nCCgXlFfjrGthJQIuj40eDT9U6cjtlK+k/s5EnN7gnqcoA1NEOQOvAxdLC 8FC1UvIrDhVZKYBDsi2i2owr6tj1I+0RQCAyket+MCYjEf9VfFbdGdJnAuWPP2M7iRKQG3510dW LB6BBshlXaNXlcL+pCRRm8GSeGTQSSKl8ClZn+n+p4i8nm8Kx8caESkACiA/4+4/yeRkEhyV7i2 CZz/vlezWNPeTnG/6UtVDJc+IKO4DVvWiKjxLGUY1AuHJWaCkBGIkMfz/eA5FP20StOQ5bkWSUM joE7XmFcfUnKY8JMepv5V3s0/hk+DGRk/HCBFx0/0w== X-Google-Smtp-Source: AGHT+IFYFn/WFKp/ftN1HulWjfWaLQ02JfyVI2i0N4djdi9JbtdvvOdvnirZWnQ0LpueoRV/zRiVxQ== X-Received: by 2002:a17:907:1c85:b0:aa6:81dc:6638 with SMTP id a640c23a62f3a-ab38b26f4cemr1152029566b.16.1737373723314; Mon, 20 Jan 2025 03:48:43 -0800 (PST) X-Received: from ?IPV6:2a03:83e0:1126:4:829:739b:3caa:6500? ([2620:10d:c092:500::4:4372]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab384f290fasm614214466b.103.2025.01.20.03.48.42 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 20 Jan 2025 03:48:42 -0800 (PST) Message-ID: Date: Mon, 20 Jan 2025 11:48:42 +0000 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [edk2-devel] [RFC 1/2] efi/memattr: Use desc_size instead of total size to check for corruption To: Ard Biesheuvel , Dave Young Cc: linux-efi@vger.kernel.org, devel@edk2.groups.io, kexec@lists.infradead.org, hannes@cmpxchg.org, x86@kernel.org, linux-kernel@vger.kernel.org, leitao@debian.org, gourry@gourry.net, kernel-team@meta.com References: <20250108215957.3437660-1-usamaarif642@gmail.com> <20250108215957.3437660-2-usamaarif642@gmail.com> <8613563a-ee7c-4271-b1f0-4d1ac365ad3a@gmail.com> <138f28ec-341e-4c48-a14b-4371a8198de8@gmail.com> <029cff22-f2e0-4796-9c27-1df056e08f8f@gmail.com> From: "Usama Arif via groups.io" In-Reply-To: Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Resent-Date: Tue, 28 Jan 2025 14:06:43 -0800 Resent-From: usamaarif642@gmail.com Reply-To: devel@edk2.groups.io,usamaarif642@gmail.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20240830 header.b=Qd78LLTX; dmarc=pass (policy=none) header.from=groups.io; spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 45.79.224.7 as permitted sender) smtp.mailfrom=bounce@groups.io On 20/01/2025 11:29, Ard Biesheuvel wrote: > On Mon, 20 Jan 2025 at 11:50, Usama Arif wrote: >> >> >> >> On 20/01/2025 10:32, Ard Biesheuvel wrote: >>> On Mon, 20 Jan 2025 at 11:27, Usama Arif wrote= : >>>> >>>> >>> ... >>>> Hi Ard, >>>> >>>> Just wanted to check how should we proceed forward? Should we try and = fix the warning >>>> and corruption during kexec as done in this series or not initialize m= emory attributes >>>> table at all in kexec boot? I would prefer fixing the issues as in thi= s series. >>>> >>> >>> I would prefer kexec boot on x86 to disregard the memory attributes >>> table entirely. >> >> Would you like Dave to send something like >> https://lore.kernel.org/all/CALu+AoS8tb=3DHgaybDw5OG4A1QbOXHvuidpu0ynmz-= nE1nBqzTA@mail.gmail.com/ >> on the mailing list (wrapped in ifdef CONFIG_X86_64) >> >=20 > I prefer this approach. and no need for the ifdef, this is x86 > specific code, and the memory attributes table is already ignored > entirely on 32-bit x86 iirc ah yes, I ignored the file name when reviewing it and just focused on the f= unction :) Will wait for Dave to send it. Thanks, Usama -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#121055): https://edk2.groups.io/g/devel/message/121055 Mute This Topic: https://groups.io/mt/110517813/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-=3D-