public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Ard Biesheuvel <ard.biesheuvel@linaro.org>, edk2-devel@lists.01.org
Cc: jens.wiklander@linaro.org
Subject: Re: [PATCH 0/3] ArmVirtPkg: ignore DT nodes with a status != 'okay'
Date: Tue, 4 Apr 2017 16:16:59 +0200	[thread overview]
Message-ID: <c609a28d-ffd2-2cb5-4462-eecb3aa6ee8b@redhat.com> (raw)
In-Reply-To: <20170404132409.20422-1-ard.biesheuvel@linaro.org>

On 04/04/17 15:24, Ard Biesheuvel wrote:
> The DT passed to us by QEMU may contain nodes that are supposed to be
> consumed by the secure world only. In some case, their status may be
> set to 'secure', but 'disabled' occurs as well, if the secure OS has
> actually modified the DT.
> 
> Since as a general rule, DT nodes should only be consumed if they lack a
> status or if their status equals 'okay', update our DT node parsing
> routines accordingly.
> 
> Ard Biesheuvel (3):
>   ArmVirtPkg/FdtClientDxe: take DT memory node 'status' property into
>     account
>   ArmVirtPkg/FdtPL011SerialPortLib: take DT node 'status' property into
>     account
>   ArmVirtPkg/PlatformPeiLib: take DT node 'status' property into account
> 
>  ArmVirtPkg/FdtClientDxe/FdtClientDxe.c                                | 8 ++++++++
>  ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c | 6 ++++++
>  ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c                    | 7 +++++++
>  3 files changed, 21 insertions(+)
> 

Please re-wrap commit messages #2 and #3 to a width of 74 characters.

The subject lines are also too long (on patches #1 and #2); please come
up with alternatives that fit into 74 characters. For example, replace

  take DT xxx node 'status' property into account

with

  honor DT xxx node 'status' property

With that, series
Reviewed-by: Laszlo Ersek <lersek@redhat.com>

Thanks,
Laszlo


  parent reply	other threads:[~2017-04-04 14:17 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-04 13:24 [PATCH 0/3] ArmVirtPkg: ignore DT nodes with a status != 'okay' Ard Biesheuvel
2017-04-04 13:24 ` [PATCH 1/3] ArmVirtPkg/FdtClientDxe: take DT memory node 'status' property into account Ard Biesheuvel
2017-04-04 13:24 ` [PATCH 2/3] ArmVirtPkg/FdtPL011SerialPortLib: take DT " Ard Biesheuvel
2017-04-04 13:24 ` [PATCH 3/3] ArmVirtPkg/PlatformPeiLib: " Ard Biesheuvel
2017-04-04 14:16 ` Laszlo Ersek [this message]
2017-04-04 14:26   ` [PATCH 0/3] ArmVirtPkg: ignore DT nodes with a status != 'okay' Ard Biesheuvel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c609a28d-ffd2-2cb5-4462-eecb3aa6ee8b@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox