From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9615621939317 for ; Tue, 4 Apr 2017 07:17:02 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id F2FF1C05490D; Tue, 4 Apr 2017 14:17:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com F2FF1C05490D Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com F2FF1C05490D Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-91.phx2.redhat.com [10.3.116.91]) by smtp.corp.redhat.com (Postfix) with ESMTP id 117A690A65; Tue, 4 Apr 2017 14:17:00 +0000 (UTC) To: Ard Biesheuvel , edk2-devel@lists.01.org References: <20170404132409.20422-1-ard.biesheuvel@linaro.org> Cc: jens.wiklander@linaro.org From: Laszlo Ersek Message-ID: Date: Tue, 4 Apr 2017 16:16:59 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170404132409.20422-1-ard.biesheuvel@linaro.org> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Tue, 04 Apr 2017 14:17:02 +0000 (UTC) Subject: Re: [PATCH 0/3] ArmVirtPkg: ignore DT nodes with a status != 'okay' X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 04 Apr 2017 14:17:02 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 04/04/17 15:24, Ard Biesheuvel wrote: > The DT passed to us by QEMU may contain nodes that are supposed to be > consumed by the secure world only. In some case, their status may be > set to 'secure', but 'disabled' occurs as well, if the secure OS has > actually modified the DT. > > Since as a general rule, DT nodes should only be consumed if they lack a > status or if their status equals 'okay', update our DT node parsing > routines accordingly. > > Ard Biesheuvel (3): > ArmVirtPkg/FdtClientDxe: take DT memory node 'status' property into > account > ArmVirtPkg/FdtPL011SerialPortLib: take DT node 'status' property into > account > ArmVirtPkg/PlatformPeiLib: take DT node 'status' property into account > > ArmVirtPkg/FdtClientDxe/FdtClientDxe.c | 8 ++++++++ > ArmVirtPkg/Library/FdtPL011SerialPortLib/EarlyFdtPL011SerialPortLib.c | 6 ++++++ > ArmVirtPkg/Library/PlatformPeiLib/PlatformPeiLib.c | 7 +++++++ > 3 files changed, 21 insertions(+) > Please re-wrap commit messages #2 and #3 to a width of 74 characters. The subject lines are also too long (on patches #1 and #2); please come up with alternatives that fit into 74 characters. For example, replace take DT xxx node 'status' property into account with honor DT xxx node 'status' property With that, series Reviewed-by: Laszlo Ersek Thanks, Laszlo