From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.129.124]) by mx.groups.io with SMTP id smtpd.web11.66698.1670908674139597475 for ; Mon, 12 Dec 2022 21:17:55 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=cEfp2P1n; spf=pass (domain: redhat.com, ip: 170.10.129.124, mailfrom: ppolawsk@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1670908673; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=vTaYSTNBU/zy0sE0N9MKavwNntTJQd9ogCI/XfhvlP4=; b=cEfp2P1n68nHzV6kNx2vqlAyL3PVOxam7MIdXotX7bjg5zrJ8rhwLVh7OhQIocOb+FdwH3 fgNYjqcoKkKCBsfe0dR58EbSsh5qCv66vQmSLCFojlVceOQ3Pu/+4N9D99pb+YVy9xiuSf v5pC/hrOQqmx+bEoOjHLeBzxeFbQ3Hg= Received: from mail-lf1-f72.google.com (mail-lf1-f72.google.com [209.85.167.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_128_GCM_SHA256) id us-mta-647-SKq7LaYYOV6z0PJbqe3mww-1; Tue, 13 Dec 2022 00:17:52 -0500 X-MC-Unique: SKq7LaYYOV6z0PJbqe3mww-1 Received: by mail-lf1-f72.google.com with SMTP id 13-20020ac2484d000000b004a22f42201eso634142lfy.17 for ; Mon, 12 Dec 2022 21:17:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:content-language:references :cc:to:from:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=vTaYSTNBU/zy0sE0N9MKavwNntTJQd9ogCI/XfhvlP4=; b=1EoDfc8qZzqpoqCUW1zzuLYb0YgrgMiNWqv1Mi8T+/FtM62+BxE1RX5aho4VRBoAym NM8sBIbiDsBfRhyKgqOESg3kdO7MZpymPEIsZB4jhuXXc7y0X3fYSQAosjGXoDRbfkZ3 9xKbIwRpV0289vbB/VfGFiW1YyZ2xEk3yiQEEgyFYnJLa/3mBVjbvGwIpAp7gruoVO29 9MLmGUEnDDXSUYdJl/x3zz+pbyQhNH2avFjEXI4RDyRPLVRqXKbrADlnzxWCYwgkj5S2 wUreZtR208KlCszJBo4f9sFg89ge3wmVQbQ66I7NYA5F5lGnYNNU3D+tu5DCndFPEXqf RvgQ== X-Gm-Message-State: ANoB5pnTeUKZ7oWIvZN01pLWqZIw/uy7mSnD9IZYgt3z4RY7YRZ6UXW1 J/pD9C/sT8f8se5xuxxZoBA6apfr/d8VW/ra2u88vuLQgIOQBwAktMYxWIU8A4HbsfbXgfxUtsO eojNqiX9/UZz/BnmOozbKWSxUrtBKwd6WFawsb8DEnxme9SA7YmsS+xOy4kbQ5g5ndA== X-Received: by 2002:a2e:918a:0:b0:27b:4879:d224 with SMTP id f10-20020a2e918a000000b0027b4879d224mr2677155ljg.25.1670908668064; Mon, 12 Dec 2022 21:17:48 -0800 (PST) X-Google-Smtp-Source: AA0mqf65mlDzg9jZbe+wWoZozinjIYk0zLvyh+d813cIMKLAm4il3B/JEJ6O+2pHUtiLYJCeadmKyA== X-Received: by 2002:a2e:918a:0:b0:27b:4879:d224 with SMTP id f10-20020a2e918a000000b0027b4879d224mr2677148ljg.25.1670908667757; Mon, 12 Dec 2022 21:17:47 -0800 (PST) Return-Path: Received: from [192.168.26.202] ([93.177.91.185]) by smtp.gmail.com with ESMTPSA id z20-20020ac24194000000b004a4731f75a5sm212835lfh.250.2022.12.12.21.17.46 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 12 Dec 2022 21:17:46 -0800 (PST) Message-ID: Date: Tue, 13 Dec 2022 06:17:44 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.5.0 Subject: Re: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover data structure From: =?UTF-8?B?UGF3ZcWCIFBvxYJhd3NraQ==?= To: devel@edk2.groups.io, michael.d.kinney@intel.com Cc: "Gao, Liming" , "Liu, Zhiguang" References: <8188524e0c39ae11baf681e3ad375e4c3c284569.1669908382.git.ppolawsk@redhat.com> <8d06266a-3781-5898-6c92-6daea0895eba@redhat.com> In-Reply-To: <8d06266a-3781-5898-6c92-6daea0895eba@redhat.com> X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Hi Mike If there is a chance you were able to check if I should introduce new PPI with a new GUID for my pull request? Or we can push forward with exiting version? In case of some changes needed - I could start implementing them right away so we could try to process everything before Christmas break. Let me know what is your opinion. Best regards, Pawel W dniu 1.12.2022 o 21:23, Paweł Poławski pisze: > Hi Mike, > > Thank you for the fast response. > I will be waiting for your guidance on this topic. > > Btw - I am too new in the EDK2 world to witness this Itanium > deprecation back in 2019. How such process looks like? > If it starts with update in documentation followed by the changes > in the code? How long is the intermediate part where both - new and old > functionality needs to be supported? > > Best regards, > Pawel > > > W dniu 1.12.2022 o 18:01, Michael D Kinney pisze: >> Hi Pawel, >> >> Thank you for the patch.  I agree this fixes the size issue. >> >> However, this structure and the associated PPI are defined in the PI Spec >> and other modules may depend on the structure layout and would have to be >> rebuilt after this structure change. >> >> It would be better to have a backwards compatible change here and I do >> not have a specific proposal yet that both reduces the size and >> preserves backwards compatibility. >> >> There have been examples in the past where we have had to introduce >> a new version of a PPI with a new GUID for this type of change. >> >> I will get back to you on this topic in a few days. >> >> Thanks, >> >> Mike >> >>> -----Original Message----- >>> From: Paweł Poławski >>> Sent: Thursday, December 1, 2022 7:36 AM >>> To: devel@edk2.groups.io >>> Cc: Kinney, Michael D ; Gao, Liming >>> ; Liu, Zhiguang >>> >>> Subject: [edk2-devel] PATCH v1 1/1 MdePkg: Remove Itanium leftover >>> data structure >>> >>> Itanium support has been removed from EDK2 aroun 2019. >>> ITANIUM_HANDOFF_STATUS data structure looks to be >>> some leftover from that process. >>> >>> There is also positive sidefect of this data structure removal. >>> Due to HOB allocation type used in PEI stage there is a limit >>> how much data about virtual CPU can be hold. This limit result >>> in only 1024 vCPU can be used by VM. >>> With Itanium related data structure removed more allocated space >>> can be used for vCPU data and with current allocation limit >>> will change from 1024 to around 8k vCPUs. >>> >>> Cc: Michael D Kinney >>> Cc: Liming Gao >>> Cc: Zhiguang Liu >>> >>> Signed-off-by: Paweł Poławski >>> --- >>>   MdePkg/Include/Ppi/SecPlatformInformation.h | 44 -------------------- >>>   1 file changed, 44 deletions(-) >>> >>> diff --git a/MdePkg/Include/Ppi/SecPlatformInformation.h >>> b/MdePkg/Include/Ppi/SecPlatformInformation.h >>> index 02b0711f189e..fbcd205acd96 100644 >>> --- a/MdePkg/Include/Ppi/SecPlatformInformation.h >>> +++ b/MdePkg/Include/Ppi/SecPlatformInformation.h >>> @@ -84,49 +84,6 @@ typedef union { >>> >>>   typedef EFI_HEALTH_FLAGS X64_HANDOFF_STATUS; >>>   typedef EFI_HEALTH_FLAGS IA32_HANDOFF_STATUS; >>> -/// >>> -/// The hand-off status structure for Itanium architecture. >>> -/// >>> -typedef struct { >>> -  /// >>> -  /// SALE_ENTRY state : 3 = Recovery_Check >>> -  /// and 0 = RESET or Normal_Boot phase. >>> -  /// >>> -  UINT8     BootPhase; >>> -  /// >>> -  /// Firmware status on entry to SALE. >>> -  /// >>> -  UINT8     FWStatus; >>> -  UINT16    Reserved1; >>> -  UINT32    Reserved2; >>> -  /// >>> -  /// Geographically significant unique processor ID assigned by PAL. >>> -  /// >>> -  UINT16    ProcId; >>> -  UINT16    Reserved3; >>> -  UINT8     IdMask; >>> -  UINT8     EidMask; >>> -  UINT16    Reserved4; >>> -  /// >>> -  /// Address to make PAL calls. >>> -  /// >>> -  UINT64    PalCallAddress; >>> -  /// >>> -  /// If the entry state is RECOVERY_CHECK, this contains the PAL_RESET >>> -  /// return address, and if entry state is RESET, this contains >>> -  /// address for PAL_authentication call. >>> -  /// >>> -  UINT64    PalSpecialAddress; >>> -  /// >>> -  /// GR35 from PALE_EXIT state. >>> -  /// >>> -  UINT64    SelfTestStatus; >>> -  /// >>> -  /// GR37 from PALE_EXIT state. >>> -  /// >>> -  UINT64    SelfTestControl; >>> -  UINT64    MemoryBufferRequired; >>> -} ITANIUM_HANDOFF_STATUS; >>> >>>   /// >>>   /// EFI_SEC_PLATFORM_INFORMATION_RECORD. >>> @@ -134,7 +91,6 @@ typedef struct { >>>   typedef union { >>>     IA32_HANDOFF_STATUS       IA32HealthFlags; >>>     X64_HANDOFF_STATUS        x64HealthFlags; >>> -  ITANIUM_HANDOFF_STATUS    ItaniumHealthFlags; >>>   } EFI_SEC_PLATFORM_INFORMATION_RECORD; >>> >>>   /** >>> -- >>> 2.38.1 >> >> >> >> >> >>