public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, shenglei.zhang@intel.com
Cc: Eric Dong <eric.dong@intel.com>, Liming Gao <liming.gao@intel.com>
Subject: Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format
Date: Mon, 23 Sep 2019 11:53:02 +0200	[thread overview]
Message-ID: <c6984c47-ee23-8744-ac9b-b1d73fbe73dc@redhat.com> (raw)
In-Reply-To: <20190906171622.25128-3-shenglei.zhang@intel.com>

On 9/6/19 7:16 PM, Zhang, Shenglei wrote:
> Remove white space in AcpiDebug.c.
> The original end of last line in DebugFeaturePkg.dsc is '/r'.
> Now update it to '/r/n'.
> 
> Cc: Eric Dong <eric.dong@intel.com>
> Cc: Liming Gao <liming.gao@intel.com>
> Signed-off-by: Shenglei Zhang <shenglei.zhang@intel.com>
> ---
> v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'.
>     The v1 patch is "DebugFeaturePkg: Remove white space and white ending line".
> 
>  Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +--
>  Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc   | 2 +-
>  2 files changed, 2 insertions(+), 3 deletions(-)
> 
> diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> index f9cd8bcb..5ad8d259 100644
> --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c
> @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm (
>    if (EFI_ERROR (Status)) {
>      return Status;
>    }
> -  
> +
>    Status = SmmBase2->InSmm (SmmBase2, &InSmm);
>    ASSERT_EFI_ERROR (Status);
>    if (EFI_ERROR (Status)) {
> @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm (
>  
>    return Status;
>  }
> -
> diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> index 30f57d5d..8e5ff4c9 100644
> --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc
> @@ -98,4 +98,4 @@
>    DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf
>  
>  [BuildOptions]
> -  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> \ No newline at end of file
> +  *_*_*_CC_FLAGS = -D DISABLE_NEW_DEPRECATED_INTERFACES
> 

Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>


  parent reply	other threads:[~2019-09-23  9:53 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-09-06 17:16 [PATCH v2] BoardModulePkg/CmosAccessLib: Update the end of last line Zhang, Shenglei
2019-09-06 17:16 ` [PATCH v2] UserInterfaceFeaturePkg: " Zhang, Shenglei
2019-09-09  1:25   ` Dandan Bi
2019-09-23  9:52   ` [edk2-devel] " Philippe Mathieu-Daudé
2019-09-06 17:16 ` [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format Zhang, Shenglei
2019-09-09  0:35   ` Dong, Eric
2019-09-23  6:58     ` Zhang, Shenglei
2019-09-23  9:53   ` Philippe Mathieu-Daudé [this message]
2019-09-09  0:35 ` [edk2-devel] [PATCH v2] BoardModulePkg/CmosAccessLib: Update the end of last line Dong, Eric

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c6984c47-ee23-8744-ac9b-b1d73fbe73dc@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox