From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LrXH4/c6; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by groups.io with SMTP; Mon, 23 Sep 2019 02:53:10 -0700 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1569232389; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:openpgp:openpgp; bh=N3HbWJtwxsM8QZCHSkKZqdCuX0H0Ogrfsp9HoUaE5Dg=; b=LrXH4/c6B1AXIZ/NbXgaP3pn2idVAiYDKCYUZlTa/0ZNwAD6gCuhIOp/UuLEWzM0gjtLnm d4fOQCg6J6DjzCrfckYXaR60n4ycj4NzLU95WDZ7BLOQtl6hkl+Q/XBKgwnsXusNr8CjE5 Uv51Rbt1Wuo02ByHmXK/sWU62NIxixw= Received: from mail-wm1-f70.google.com (mail-wm1-f70.google.com [209.85.128.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-266-Wa12696nNYuSIR26RHWwJA-1; Mon, 23 Sep 2019 05:53:04 -0400 Received: by mail-wm1-f70.google.com with SMTP id z205so6390123wmb.7 for ; Mon, 23 Sep 2019 02:53:04 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:openpgp:message-id :date:user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=iOfSIW673lCvC3OhttBGvJK93/Bct5EK+hEevRhweF4=; b=JxfAyHNLCiCWNEJvQGlcvCPf9I0C2+et+eTzpEG/e+MQgDBYh8BUkCap8ElE6p1syd ms1W03rnLF9qIBmtXD/9PkTo4VJxOjrkXjWHgG27PvPRLBv5ZXchj+0QCq8xzKoLEr8r jaXcwQvtRLvj48xaYAursRsCsm4l+s7Z4i/0eWERd+X2zAdT1TVrVX4w/eKWPNNkCWr4 ko8OHkRjwE90nc+h4xCAqkkhzQbRG8zzy9ZroBB0FyVZRZP9ZLmIi+w0HBCfa6i+D9/V l0s4j2m+3uoLV5qn8wmGVX/bArgRByvxN8EM4nB3f0uddMpd3JtBPmDi2nTPnEhcWBKr STmQ== X-Gm-Message-State: APjAAAW+WMONm7YUIvPrYVkqXF3pFHAwq8YgN5j2MPOSTBO6JDyCUx0F Q/0pz/RVay9DTEU/fgU0ihnzpRrJ+IpnlBx5rGudbK9cpW5YubevUJCefmo5tNrXxkHzwIemDnN Pzav2upnuoAqE6A== X-Received: by 2002:a1c:4886:: with SMTP id v128mr13132314wma.176.1569232383747; Mon, 23 Sep 2019 02:53:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqzMisRQwikDp+ApUl0FvlKAcA4708CsFz46a9d7+xRKf3j3z4zv6/IHrS/1l0q+UUk7WiYLUA== X-Received: by 2002:a1c:4886:: with SMTP id v128mr13132302wma.176.1569232383590; Mon, 23 Sep 2019 02:53:03 -0700 (PDT) Return-Path: Received: from [192.168.1.40] (240.red-88-21-68.staticip.rima-tde.net. [88.21.68.240]) by smtp.gmail.com with ESMTPSA id r6sm9557928wmh.38.2019.09.23.02.53.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 23 Sep 2019 02:53:03 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH v2] DebugFeaturePkg: Remove white space and update the ending format To: devel@edk2.groups.io, shenglei.zhang@intel.com Cc: Eric Dong , Liming Gao References: <20190906171622.25128-1-shenglei.zhang@intel.com> <20190906171622.25128-3-shenglei.zhang@intel.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Openpgp: id=89C1E78F601EE86C867495CBA2A3FD6EDEADC0DE; url=http://pgp.mit.edu/pks/lookup?op=get&search=0xA2A3FD6EDEADC0DE Message-ID: Date: Mon, 23 Sep 2019 11:53:02 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.7.0 MIME-Version: 1.0 In-Reply-To: <20190906171622.25128-3-shenglei.zhang@intel.com> X-MC-Unique: Wa12696nNYuSIR26RHWwJA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable On 9/6/19 7:16 PM, Zhang, Shenglei wrote: > Remove white space in AcpiDebug.c. > The original end of last line in DebugFeaturePkg.dsc is '/r'. > Now update it to '/r/n'. >=20 > Cc: Eric Dong > Cc: Liming Gao > Signed-off-by: Shenglei Zhang > --- > v2: In v1 the patch remove the '/r'. In v2 it is updated to '/r/n'. > The v1 patch is "DebugFeaturePkg: Remove white space and white ending= line". >=20 > Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c | 3 +-- > Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc | 2 +- > 2 files changed, 2 insertions(+), 3 deletions(-) >=20 > diff --git a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c b/Platf= orm/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c > index f9cd8bcb..5ad8d259 100644 > --- a/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c > +++ b/Platform/Intel/DebugFeaturePkg/AcpiDebug/AcpiDebug.c > @@ -487,7 +487,7 @@ InitializeAcpiDebugSmm ( > if (EFI_ERROR (Status)) { > return Status; > } > - =20 > + > Status =3D SmmBase2->InSmm (SmmBase2, &InSmm); > ASSERT_EFI_ERROR (Status); > if (EFI_ERROR (Status)) { > @@ -519,4 +519,3 @@ InitializeAcpiDebugSmm ( > =20 > return Status; > } > - > diff --git a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc b/Platfor= m/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > index 30f57d5d..8e5ff4c9 100644 > --- a/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > +++ b/Platform/Intel/DebugFeaturePkg/DebugFeaturePkg.dsc > @@ -98,4 +98,4 @@ > DebugFeaturePkg/AcpiDebug/AcpiDebugSmm.inf > =20 > [BuildOptions] > - *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES > \ No newline at end of file > + *_*_*_CC_FLAGS =3D -D DISABLE_NEW_DEPRECATED_INTERFACES >=20 Reviewed-by: Philippe Mathieu-Daude