From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 20 Jun 2019 07:47:03 -0700 Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id AC9005D5E6; Thu, 20 Jun 2019 14:46:57 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 1B95D6090E; Thu, 20 Jun 2019 14:46:54 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v1 1/1] CryptoPkg/OpensslLib: Exclude err_all.c in process_files.py To: devel@edk2.groups.io, dwmw2@infradead.org, xiaoyux.lu@intel.com Cc: Jian J Wang , Ting Ye , Richard Levitte References: <1560928761-1867-1-git-send-email-xiaoyux.lu@intel.com> From: "Laszlo Ersek" Message-ID: Date: Thu, 20 Jun 2019 16:46:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 20 Jun 2019 14:46:57 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 06/20/19 09:54, David Woodhouse wrote: > On Wed, 2019-06-19 at 03:19 -0400, Xiaoyu Lu wrote: >> REF: https://bugzilla.tianocore.org/show_bug.cgi?id=1881 >> >> Commit(0a1b13fd4d2210e2c3) fix VS2017 build failure >> remove useless file in OpensslLib[Crypto].inf, >> but we use process_files.py to generate files. >> So exclude err_all.c file in process_files.py >> >> Cc: Jian J Wang >> Cc: Ting Ye >> Signed-off-by: Xiaoyu Lu >> --- >> CryptoPkg/Library/OpensslLib/process_files.pl | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/CryptoPkg/Library/OpensslLib/process_files.pl b/CryptoPkg/Library/OpensslLib/process_files.pl >> index e277108f0734..2783ff54f95a 100755 >> --- a/CryptoPkg/Library/OpensslLib/process_files.pl >> +++ b/CryptoPkg/Library/OpensslLib/process_files.pl >> @@ -132,6 +132,7 @@ foreach my $product ((@{$unified_info{libraries}}, >> # So it can reduce porting time, compile time, library size. >> next if $s =~ "crypto/rand/randfile.c"; >> next if $s =~ "crypto/store/"; >> + next if $s =~ "crypto/err/err_all.c"; >> >> if ($product =~ "libssl") { >> push @sslfilelist, ' $(OPENSSL_PATH)/' . $s . "\r\n"; >> -- > > Hm, this looks like the wrong approach to me. I only ever meant the > exclusions here to be a hack, to fix up things we couldn't properly do > in OpenSSL by disabling features. > > Now if you'd fixed up the crypto/store/ exclusion properly by prodding > Richard to add an OPENSSL_NO_STORE option, then the subsequent > inclusion of ERR_load_OSSL_STORE_strings() in err_all.c wouldn't have > led to further hacks to exclude *that* file... > > Please submit a PR to OpenSSL to add 'no-store' if you really don't > want it. I actually agree about "no-store"; please see point (1) in my earlier review here: http://mid.mail-archive.com/0c5b5e95-cb2c-75af-a30b-015dac14b91c@redhat.com But I've run out of steam on this -- especially the last weeks have seen me struggle with just reading my email. :( Thanks Laszlo