Re: [edk2-devel] [PATCH v4 13/35] OvmfPkg/Library/XenPlatformLib: New library

["Laszlo Ersek" <lersek@redhat.com>]

On 07/29/19 17:39, Anthony PERARD wrote:
> The purpose of XenPlatformLib is to regroup the few functions that are
> used in several places to detect if Xen is detected, and to get the
> XenInfo HOB.
> 
> Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689
> Signed-off-by: Anthony PERARD <anthony.perard@citrix.com>
> Reviewed-by: Laszlo Ersek <lersek@redhat.com>
> ---
> 
> Notes:
>     v4:
>     - fix top-level comment style
>     - Update Maintainers.txt
>     
>     v3:
>     - use SPDX
>     - add XenPlatformLib.h to [LibraryClasses] in OvmfPkg.dec
>     - fix typos
> 
>  OvmfPkg/OvmfPkg.dec                           |  4 ++
>  OvmfPkg/OvmfXen.dsc                           |  1 +
>  .../Library/XenPlatformLib/XenPlatformLib.inf | 33 +++++++++
>  OvmfPkg/Include/Library/XenPlatformLib.h      | 53 ++++++++++++++
>  .../Library/XenPlatformLib/XenPlatformLib.c   | 69 +++++++++++++++++++
>  Maintainers.txt                               |  2 +
>  6 files changed, 162 insertions(+)
>  create mode 100644 OvmfPkg/Library/XenPlatformLib/XenPlatformLib.inf
>  create mode 100644 OvmfPkg/Include/Library/XenPlatformLib.h
>  create mode 100644 OvmfPkg/Library/XenPlatformLib/XenPlatformLib.c

[...]

> diff --git a/Maintainers.txt b/Maintainers.txt
> index 016523b401..f51731a6b6 100644
> --- a/Maintainers.txt
> +++ b/Maintainers.txt
> @@ -365,6 +365,7 @@ F: OvmfPkg/Include/Guid/XenInfo.h
>  F: OvmfPkg/Include/IndustryStandard/Xen/
>  F: OvmfPkg/Include/Library/XenHypercallLib.h
>  F: OvmfPkg/Include/Library/XenIoMmioLib.h
> +F: OvmfPkg/Include/Library/XenPlatformLib.h
>  F: OvmfPkg/Include/Protocol/XenBus.h
>  F: OvmfPkg/Include/Protocol/XenIo.h
>  F: OvmfPkg/Library/PciHostBridgeLib/XenSupport.c
> @@ -372,6 +373,7 @@ F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c
>  F: OvmfPkg/Library/XenConsoleSerialPortLib/
>  F: OvmfPkg/Library/XenHypercallLib/
>  F: OvmfPkg/Library/XenIoMmioLib/
> +F: OvmfPkg/Library/XenPlatformLib/
>  F: OvmfPkg/OvmfXen.*
>  F: OvmfPkg/OvmfXenElfHeaderGenerator.c
>  F: OvmfPkg/PlatformPei/MemDetect.c
> 

Reviewed-by: Laszlo Ersek <lersek@redhat.com>