From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Tue, 30 Jul 2019 02:57:18 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2606C30BD1C2; Tue, 30 Jul 2019 09:57:18 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (unknown [10.36.118.39]) by smtp.corp.redhat.com (Postfix) with ESMTP id B2D6519C67; Tue, 30 Jul 2019 09:57:16 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH v4 13/35] OvmfPkg/Library/XenPlatformLib: New library To: devel@edk2.groups.io, anthony.perard@citrix.com Cc: Julien Grall , xen-devel@lists.xenproject.org, Jordan Justen , Ard Biesheuvel References: <20190729153944.24239-1-anthony.perard@citrix.com> <20190729153944.24239-14-anthony.perard@citrix.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 30 Jul 2019 11:57:15 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190729153944.24239-14-anthony.perard@citrix.com> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.49]); Tue, 30 Jul 2019 09:57:18 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 07/29/19 17:39, Anthony PERARD wrote: > The purpose of XenPlatformLib is to regroup the few functions that are > used in several places to detect if Xen is detected, and to get the > XenInfo HOB. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=1689 > Signed-off-by: Anthony PERARD > Reviewed-by: Laszlo Ersek > --- > > Notes: > v4: > - fix top-level comment style > - Update Maintainers.txt > > v3: > - use SPDX > - add XenPlatformLib.h to [LibraryClasses] in OvmfPkg.dec > - fix typos > > OvmfPkg/OvmfPkg.dec | 4 ++ > OvmfPkg/OvmfXen.dsc | 1 + > .../Library/XenPlatformLib/XenPlatformLib.inf | 33 +++++++++ > OvmfPkg/Include/Library/XenPlatformLib.h | 53 ++++++++++++++ > .../Library/XenPlatformLib/XenPlatformLib.c | 69 +++++++++++++++++++ > Maintainers.txt | 2 + > 6 files changed, 162 insertions(+) > create mode 100644 OvmfPkg/Library/XenPlatformLib/XenPlatformLib.inf > create mode 100644 OvmfPkg/Include/Library/XenPlatformLib.h > create mode 100644 OvmfPkg/Library/XenPlatformLib/XenPlatformLib.c [...] > diff --git a/Maintainers.txt b/Maintainers.txt > index 016523b401..f51731a6b6 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -365,6 +365,7 @@ F: OvmfPkg/Include/Guid/XenInfo.h > F: OvmfPkg/Include/IndustryStandard/Xen/ > F: OvmfPkg/Include/Library/XenHypercallLib.h > F: OvmfPkg/Include/Library/XenIoMmioLib.h > +F: OvmfPkg/Include/Library/XenPlatformLib.h > F: OvmfPkg/Include/Protocol/XenBus.h > F: OvmfPkg/Include/Protocol/XenIo.h > F: OvmfPkg/Library/PciHostBridgeLib/XenSupport.c > @@ -372,6 +373,7 @@ F: OvmfPkg/Library/PlatformBootManagerLib/BdsPlatform.c > F: OvmfPkg/Library/XenConsoleSerialPortLib/ > F: OvmfPkg/Library/XenHypercallLib/ > F: OvmfPkg/Library/XenIoMmioLib/ > +F: OvmfPkg/Library/XenPlatformLib/ > F: OvmfPkg/OvmfXen.* > F: OvmfPkg/OvmfXenElfHeaderGenerator.c > F: OvmfPkg/PlatformPei/MemDetect.c > Reviewed-by: Laszlo Ersek