From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=66.187.233.73; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx3-rdu2.redhat.com [66.187.233.73]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9E5DE210FB9ED for ; Wed, 29 Aug 2018 06:53:43 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id A52514000783; Wed, 29 Aug 2018 13:53:42 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-221.rdu2.redhat.com [10.10.120.221]) by smtp.corp.redhat.com (Postfix) with ESMTP id 9CE0F2166BA1; Wed, 29 Aug 2018 13:53:39 +0000 (UTC) To: Jian J Wang , edk2-devel@lists.01.org Cc: Eric Dong References: <20180829032135.16156-1-jian.j.wang@intel.com> From: Laszlo Ersek Message-ID: Date: Wed, 29 Aug 2018 15:53:39 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180829032135.16156-1-jian.j.wang@intel.com> X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 29 Aug 2018 13:53:42 +0000 (UTC) X-Greylist: inspected by milter-greylist-4.5.16 (mx1.redhat.com [10.11.55.6]); Wed, 29 Aug 2018 13:53:42 +0000 (UTC) for IP:'10.11.54.6' DOMAIN:'int-mx06.intmail.prod.int.rdu2.redhat.com' HELO:'smtp.corp.redhat.com' FROM:'lersek@redhat.com' RCPT:'' Subject: Re: [PATCH] UefiCpuPkg/CpuDxe: change level of DEBUG message X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 29 Aug 2018 13:53:43 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 08/29/18 05:21, Jian J Wang wrote: > It's reported the debug message in CpuDxe driver is quite annoying in > boot and shell, and slow down the boot process. To solve this issue, > this patch changes the DEBUG_INFO to DEBUG_VERBOSE. On a typical Intel > real platform, at least 16s boot time can be saved. > > Cc: Eric Dong > Cc: Laszlo Ersek > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Jian J Wang > --- > UefiCpuPkg/CpuDxe/CpuDxe.c | 2 +- > UefiCpuPkg/CpuDxe/CpuPageTable.c | 4 ++-- > 2 files changed, 3 insertions(+), 3 deletions(-) > > diff --git a/UefiCpuPkg/CpuDxe/CpuDxe.c b/UefiCpuPkg/CpuDxe/CpuDxe.c > index cfd4c415ae..76661cbcd9 100644 > --- a/UefiCpuPkg/CpuDxe/CpuDxe.c > +++ b/UefiCpuPkg/CpuDxe/CpuDxe.c > @@ -404,7 +404,7 @@ CpuSetMemoryAttributes ( > // to avoid unnecessary computing. > // > if (mIsFlushingGCD) { > - DEBUG((DEBUG_INFO, " Flushing GCD\n")); > + DEBUG((DEBUG_VERBOSE, " Flushing GCD\n")); > return EFI_SUCCESS; > } > > diff --git a/UefiCpuPkg/CpuDxe/CpuPageTable.c b/UefiCpuPkg/CpuDxe/CpuPageTable.c > index df021798c0..609df58e3a 100644 > --- a/UefiCpuPkg/CpuDxe/CpuPageTable.c > +++ b/UefiCpuPkg/CpuDxe/CpuPageTable.c > @@ -528,7 +528,7 @@ SplitPage ( > ASSERT (SplitAttribute == Page4K); > if (SplitAttribute == Page4K) { > NewPageEntry = AllocatePagesFunc (1); > - DEBUG ((DEBUG_INFO, "Split - 0x%x\n", NewPageEntry)); > + DEBUG ((DEBUG_VERBOSE, "Split - 0x%x\n", NewPageEntry)); > if (NewPageEntry == NULL) { > return RETURN_OUT_OF_RESOURCES; > } > @@ -549,7 +549,7 @@ SplitPage ( > ASSERT (SplitAttribute == Page2M || SplitAttribute == Page4K); > if ((SplitAttribute == Page2M || SplitAttribute == Page4K)) { > NewPageEntry = AllocatePagesFunc (1); > - DEBUG ((DEBUG_INFO, "Split - 0x%x\n", NewPageEntry)); > + DEBUG ((DEBUG_VERBOSE, "Split - 0x%x\n", NewPageEntry)); > if (NewPageEntry == NULL) { > return RETURN_OUT_OF_RESOURCES; > } > Before you push this patch, please add a reference to https://bugzilla.tianocore.org/show_bug.cgi?id=1127 in the commit message. With that: Reviewed-by: Laszlo Ersek Thanks Laszlo