From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [63.128.21.124]) by mx.groups.io with SMTP id smtpd.web09.5147.1606259977934589845 for ; Tue, 24 Nov 2020 15:19:38 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=GFYehmBQ; spf=pass (domain: redhat.com, ip: 63.128.21.124, mailfrom: lersek@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1606259977; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=9HBUDn4wrn46mDhyohW3soNsuxbtR8qxu/Rnn4SMYAw=; b=GFYehmBQQPb9CFFq1KDbKYtwdzY604kPQIfQyKA3b34sfW+3l/eT1A0fvID5IN/jRH36p7 ZcxqNypneppuGjy6x0wCree/7cGrc7S27R3gT0QAk1M6VICQXRXnbnATry12JMCSQUe2BX kemB5pEd9acDp6Vgq+JrsjYKFWwQ9F0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-116-s3O8h233NEyjDJEgzOv0hg-1; Tue, 24 Nov 2020 18:19:32 -0500 X-MC-Unique: s3O8h233NEyjDJEgzOv0hg-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 069D61005E5F; Tue, 24 Nov 2020 23:19:31 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-25.ams2.redhat.com [10.36.112.25]) by smtp.corp.redhat.com (Postfix) with ESMTP id 682DF5D6AB; Tue, 24 Nov 2020 23:19:28 +0000 (UTC) Subject: Re: [PATCH v2 3/6] OvmfPkg: convert ES Reset Block structure to be guided To: jejb@linux.ibm.com, Tom Lendacky , devel@edk2.groups.io Cc: dovmurik@linux.vnet.ibm.com, Dov.Murik1@il.ibm.com, ashish.kalra@amd.com, brijesh.singh@amd.com, tobin@ibm.com, david.kaplan@amd.com, jon.grimm@amd.com, frankeh@us.ibm.com, "Dr . David Alan Gilbert" References: <20201120184521.19437-1-jejb@linux.ibm.com> <20201120184521.19437-4-jejb@linux.ibm.com> From: "Laszlo Ersek" Message-ID: Date: Wed, 25 Nov 2020 00:19:27 +0100 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 11/24/20 20:07, James Bottomley wrote: > On Tue, 2020-11-24 at 08:57 -0600, Tom Lendacky wrote: >> On 11/23/20 4:16 PM, Laszlo Ersek wrote: >>> On 11/20/20 19:45, James Bottomley wrote: >>>> Convert the current ES reset block structure to an extensible >>>> guid based structure by appending a header and length, which >>>> allow for multiple guid based data packets to be inserted. >> >> I was wondering if this patch should be submitted outside of this >> series? I'm not sure it makes any difference, other than being able >> to be merged (possibly) quicker and independent of the series. Then >> this series simply takes advantage of it. > > How about if I shuffle it to the beginning of the series? That way it > can be taken on its own or with the rest. I wouldn't mind either approach in general; however, we're in hard feature freeze now for edk2-stable202011 anyway, and I can't merge anything resembling a new feature until after 2020-Nov-27. https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning ... Moving the patch to the front could still improve the structure / build-up of the series, however. So yes, I guess please move it to the front. Cheers! Laszlo