From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Mon, 22 Jul 2019 15:56:26 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 2245485360; Mon, 22 Jul 2019 22:56:26 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-23.ams2.redhat.com [10.36.117.23]) by smtp.corp.redhat.com (Postfix) with ESMTP id B166F19C6A; Mon, 22 Jul 2019 22:56:24 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, Crypto, Embedded: list internal headers in [Sources] To: devel@edk2.groups.io, michael.d.kinney@intel.com, Leif Lindholm Cc: Ard Biesheuvel , "Wang, Jian J" , "Ye, Ting" References: <20190719164319.9070-1-lersek@redhat.com> <20190722103755.GA11541@bivouac.eciton.net> <591319a9-eceb-ab39-0ec0-ccd2530b0e58@redhat.com> From: "Laszlo Ersek" Message-ID: Date: Tue, 23 Jul 2019 00:56:23 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 22 Jul 2019 22:56:26 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Mike, On 07/22/19 20:47, Michael D Kinney wrote: > We could consider checking for these type of issues in > the ECC tool instead of build and make it an error from > ECC instead of a warning. I'm sorry, my reply to Leif was ambiguous (or worse). I meant that the issues underlying the specific warnings (emitted by the feature from TianoCore#1804) were annoying -- the reports were valid, and what "annoyed" me was that the INF files had not been in order (i.e. that they had missed some internal header files). I wasn't annoyed at the feature itself -- if it helps developers catch unlisted headers as soon as incomplete INF files are introduced, then it's not a bad feature IMO. I'd make a *light* argument for keeping the feature in "build", as opposed to ECC: - ECC performs a very deep investigation (and used to produce a number of false positives / noise). - Since commit c60377d7f9ec ("BaseTools: ECC tool Python3 adaption", 2019-02-01), ECC has been incompatible with Python2 (and requires antlr4, rather than antlr3). Thus, "build" works on more systems than ECC. - I think "unlisted internal headers in INF files" is a problem defined at the level of "build". That said, I don't feel strongly about these general questions; I just wanted to fix the actual warnings, because they were valid. Thanks Laszlo >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] >> On Behalf Of Laszlo Ersek >> Sent: Monday, July 22, 2019 10:33 AM >> To: Leif Lindholm >> Cc: edk2-devel-groups-io ; Ard >> Biesheuvel ; Wang, Jian J >> ; Ye, Ting >> Subject: Re: [edk2-devel] [PATCH 0/4] Arm, ArmPlatform, >> Crypto, Embedded: list internal headers in [Sources] >> >> On 07/22/19 12:37, Leif Lindholm wrote: >>> On Fri, Jul 19, 2019 at 06:43:15PM +0200, Laszlo Ersek >> wrote: >>>> Repo: https://github.com/lersek/edk2.git >>>> Branch: internal_hdrs >>>> >>>> The BaseTools build feature introduced for >> TianoCore#1804 / in commit >>>> 1fa6699e6cd4 ("BaseTools: Add a checking for Sources >> section in INF >>>> file", 2019-06-10) logs some (non-fatal) warnings >> about unlisted >>>> internal header files. List those files explicitly. >>> >>> Urgh. >>> Yeah. I'm still not super comfortable with this >> duplication of >>> dependency scanning (as discussed in >>> https://edk2.groups.io/g/devel/topic/31866190), but I >> have to confess >>> I also don't really care enough to do anything about >> it. >>> >>> So, while I'm tempted to keep the warnings around as a >> reminder, if >>> you prefer to get rid of them - for the pat of the >> series I was cc:d on: >>> Reviewed-by: Leif Lindholm >> >> Thanks! >> >> Yes, the warnings are an annoyance, and they are valid >> too. How the INF files are caught / reported is a >> separate question IMO. >> >> Thanks! >> Laszlo