From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 0312B1A1E02 for ; Thu, 18 Aug 2016 19:10:28 -0700 (PDT) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8169D74E; Fri, 19 Aug 2016 02:10:28 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-17.phx2.redhat.com [10.3.116.17]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u7J2APAZ020097; Thu, 18 Aug 2016 22:10:26 -0400 To: Vikas C Sajjan , edk2-devel@ml01.01.org, ard.biesheuvel@linaro.org, leif.lindholm@linaro.org References: <1471497459-4476-1-git-send-email-vikas.cha.sajjan@hpe.com> <1471497459-4476-3-git-send-email-vikas.cha.sajjan@hpe.com> Cc: dong.wei@hpe.com From: Laszlo Ersek Message-ID: Date: Fri, 19 Aug 2016 04:10:25 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <1471497459-4476-3-git-send-email-vikas.cha.sajjan@hpe.com> X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Fri, 19 Aug 2016 02:10:28 +0000 (UTC) Subject: Re: [PATCH 2/2] ArmVirtPkg: Add Ramdisk support to ArmVirtPkg platforms X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 19 Aug 2016 02:10:29 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 08/18/16 07:17, Vikas C Sajjan wrote: > Adds the RAMDisk support to ArmVirtPkg platforms. > This patch actually ports OvmfPkg commit 259d87146b07 to > ArmVirtPkg. > > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Vikas C Sajjan > --- > ArmVirtPkg/ArmVirt.dsc.inc | 7 +++++++ > ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc | 3 +++ > ArmVirtPkg/ArmVirtRules.fdf.inc | 2 ++ > ArmVirtPkg/ArmVirtXen.fdf | 3 +++ > 4 files changed, 15 insertions(+) > > diff --git a/ArmVirtPkg/ArmVirt.dsc.inc b/ArmVirtPkg/ArmVirt.dsc.inc > index 9e215c2..66068f7 100644 > --- a/ArmVirtPkg/ArmVirt.dsc.inc > +++ b/ArmVirtPkg/ArmVirt.dsc.inc > @@ -253,6 +253,10 @@ > gEfiMdePkgTokenSpaceGuid.PcdComponentName2Disable|TRUE > gEfiMdePkgTokenSpaceGuid.PcdDriverDiagnostics2Disable|TRUE > > +[PcdsFeatureFlag.AARCH64] > + # Activate AcpiSdtProtocol > + gEfiMdeModulePkgTokenSpaceGuid.PcdInstallAcpiSdtProtocol|TRUE > + > # > # Control what commands are supported from the UI > # Turn these on and off to add features or save size Similar problem to the one with the previous patch: this change restricts PcdEmbeddedMacBoot etc to AARCH64. They used to be under [PcdsFeatureFlag.common]'s scope. > @@ -382,6 +386,9 @@ > MdeModulePkg/Universal/Network/UefiPxeBcDxe/UefiPxeBcDxe.inf > MdeModulePkg/Universal/Network/IScsiDxe/IScsiDxe.inf > > + # Ramdisk support > + MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > + Looks good, this is under [Components.common]. > [Components.AARCH64] > # > # ACPI Support > diff --git a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > index ad7037f..14d06bb 100644 > --- a/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > +++ b/ArmVirtPkg/ArmVirtQemuFvMain.fdf.inc > @@ -177,3 +177,6 @@ READ_LOCK_STATUS = TRUE > FILE FREEFORM = PCD(gEfiIntelFrameworkModulePkgTokenSpaceGuid.PcdLogoFile) { > SECTION RAW = MdeModulePkg/Logo/Logo.bmp > } > + > + # Ramdisk support > + INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf The rest of the file uses a commenting style like # # Ramdisk support # Not very important, but preferable. > diff --git a/ArmVirtPkg/ArmVirtRules.fdf.inc b/ArmVirtPkg/ArmVirtRules.fdf.inc > index 8952c67..5ff3004 100644 > --- a/ArmVirtPkg/ArmVirtRules.fdf.inc > +++ b/ArmVirtPkg/ArmVirtRules.fdf.inc > @@ -85,6 +85,8 @@ > DXE_DEPEX DXE_DEPEX Optional $(INF_OUTPUT)/$(MODULE_NAME).depex > PE32 PE32 $(INF_OUTPUT)/$(MODULE_NAME).efi > UI STRING="$(MODULE_NAME)" Optional > + RAW ACPI Optional |.acpi > + RAW ASL Optional |.aml > } > > [Rule.Common.DXE_RUNTIME_DRIVER] Looks okay (modifies [Rule.Common.DXE_DRIVER]) > diff --git a/ArmVirtPkg/ArmVirtXen.fdf b/ArmVirtPkg/ArmVirtXen.fdf > index 0a97bd8..36671a8 100644 > --- a/ArmVirtPkg/ArmVirtXen.fdf > +++ b/ArmVirtPkg/ArmVirtXen.fdf > @@ -188,6 +188,9 @@ READ_LOCK_STATUS = TRUE > INF ArmVirtPkg/XenAcpiPlatformDxe/XenAcpiPlatformDxe.inf > !endif > > + # Ramdisk support > + INF MdeModulePkg/Universal/Disk/RamDiskDxe/RamDiskDxe.inf > + > [FV.FVMAIN_COMPACT] > FvAlignment = 16 > ERASE_POLARITY = 1 > This hunk looks good too. Thanks Laszlo