From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mx.groups.io with SMTP id smtpd.web08.1975.1616615406296191689
 for <devel@edk2.groups.io>;
 Wed, 24 Mar 2021 12:50:06 -0700
Authentication-Results: mx.groups.io;
 dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: jeremy.linton@arm.com)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
	by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id C37E314BF;
	Wed, 24 Mar 2021 12:50:05 -0700 (PDT)
Received: from [192.168.122.166] (unknown [172.31.20.19])
	by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 81E213F718;
	Wed, 24 Mar 2021 12:50:05 -0700 (PDT)
Subject: Re: [PATCH v2 2/2] Platform/RaspberryPi: Enable Bluetooth and UART in Windows OS
To: Sunny Wang <Sunny.Wang@arm.com>, devel@edk2.groups.io
Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>,
 Sami Mujawar <sami.mujawar@arm.com>, Pete Batard <pete@akeo.ie>,
 Ard Biesheuvel <ardb+tianocore@kernel.org>
References: <20210324094524.184-1-Sunny.Wang@arm.com>
 <20210324094524.184-2-Sunny.Wang@arm.com>
From: "Jeremy Linton" <jeremy.linton@arm.com>
Message-ID: <c737cf99-ddb1-9a02-e1f0-9dc7e8a4d1ba@arm.com>
Date: Wed, 24 Mar 2021 14:50:04 -0500
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101
 Thunderbird/78.7.0
MIME-Version: 1.0
In-Reply-To: <20210324094524.184-2-Sunny.Wang@arm.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit

Hi,

On 3/24/21 4:45 AM, Sunny Wang wrote:
> Merge changes in edk2-platforms-raspberrypi-pl011-bth-noflow.diff in
> https://github.com/worproject/RPi-Bluetooth-Testing/ for enabling
> Bluetooth and serial port (Mini UART) in Windows OS.
> 
> Testing Done:
>    - Successfully booted Windows 10 (20279.1) on SD (made by WOR) with
>      the RPi-Windows-Drivers release ver 0.5 downloaded from
>      https://github.com/worproject/RPi-Windows-Drivers/releases
>      and checked that both Bluetooth and serial port (Mini UART) can
>      work fine.
> 
> Cc: Samer El-Haj-Mahmoud <samer.el-haj-mahmoud@arm.com>
> Cc: Sami Mujawar <sami.mujawar@arm.com>
> Cc: Jeremy Linton <jeremy.linton@arm.com>
> Cc: Pete Batard <pete@akeo.ie>
> Cc: Ard Biesheuvel <ardb+tianocore@kernel.org>
> Signed-off-by: Sunny Wang <sunny.wang@arm.com>
> ---
>   Platform/RaspberryPi/AcpiTables/Uart.asl | 8 +++++++-
>   1 file changed, 7 insertions(+), 1 deletion(-)
> 
> diff --git a/Platform/RaspberryPi/AcpiTables/Uart.asl b/Platform/RaspberryPi/AcpiTables/Uart.asl
> index 8ce297078d..e3165911a6 100644
> --- a/Platform/RaspberryPi/AcpiTables/Uart.asl
> +++ b/Platform/RaspberryPi/AcpiTables/Uart.asl
> @@ -30,6 +30,12 @@ Device (URT0)
>     {
>       MEMORY32FIXED (ReadWrite, 0, BCM2836_PL011_UART_LENGTH, RMEM)
>       Interrupt (ResourceConsumer, Level, ActiveHigh, Exclusive) { BCM2836_PL011_UART_INTERRUPT }
> +
> +    PinFunction (Exclusive, PullDown, BCM_ALT3, "\\_SB.GDV0.GPI0", 0, ResourceConsumer, , ) { 32, 33 }
> +
> +    // fake the CTS signal as we don't support HW flow control yet
> +    // BCM_ALT2 is set as output (low) by default
> +    PinFunction (Exclusive, PullNone, BCM_ALT2, "\\_SB.GDV0.GPI0", 0, ResourceConsumer, , ) { 31 }
>     })
>     Method (_CRS, 0x0, Serialized)
>     {
> @@ -142,7 +148,7 @@ Device(BTH0)
>         //
>         // RPIQ connection for BT_ON/OFF
>         //
> -      GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0, ResourceConsumer, , ) { 128 }
> +      //GpioIO (Shared, PullUp, 0, 0, IoRestrictionNone, "\\_SB.GDV0.RPIQ", 0, ResourceConsumer, , ) { 128 }
>       })
>       Return (RBUF)
>     }
> 

Having come to this a bit late, its always made me a bit uncomfortable 
that some of these tables are doing blanket power/etc configuration in 
_CRS, is there are reason for continuing this rather than doing this via 
power states?