From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9C9CC21167466 for ; Sat, 13 Oct 2018 14:57:55 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 04DF8307D911; Sat, 13 Oct 2018 21:57:55 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-6.rdu2.redhat.com [10.10.120.6]) by smtp.corp.redhat.com (Postfix) with ESMTP id EBCBF7B076; Sat, 13 Oct 2018 21:57:53 +0000 (UTC) To: Sami Mujawar , edk2-devel@lists.01.org Cc: nd@arm.com, Stephanie.Hughes-Fitt@arm.com References: <20181012144009.48732-1-sami.mujawar@arm.com> <20181012144009.48732-7-sami.mujawar@arm.com> From: Laszlo Ersek Message-ID: Date: Sat, 13 Oct 2018 23:57:52 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20181012144009.48732-7-sami.mujawar@arm.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Sat, 13 Oct 2018 21:57:55 +0000 (UTC) Subject: Re: [PATCH v1 6/6] ArmVirtPkg: Support for kvmtool emulated platform X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 13 Oct 2018 21:57:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/12/18 16:40, Sami Mujawar wrote: > Kvmtool is a virtual machine manager that enables hosting > KVM guests. Kvmtool emulates certain devices like serial > port, RTC, etc. essentially providing an emulated platform. > > This patch adds support for kvmtool emulated platform. > > Contributed-under: TianoCore Contribution Agreement 1.1 > Signed-off-by: Sami Mujawar > --- > The changes can be seen at https://github.com/samimujawar/edk2/commit/f13ce7024f7216e4036459bab6ce4b1d700f6050 > > Notes: > v1: > - Add support for Kvmtool emulated platform [SAMI] > > ArmVirtPkg/ArmVirtKvmTool.dsc | 390 ++++++++++++++++++++ > ArmVirtPkg/ArmVirtKvmTool.fdf | 297 +++++++++++++++ > 2 files changed, 687 insertions(+) I'd like to see more justification for this platform (see my questions under 0/6), and once those are provided, I would like the maintainership of this new platform to be captured formally in Maintainers.txt. (There is a community topic at about this in general, "Adding more detail to Maintainers.txt". The idea is to adopt the pathname/pattern-based maintainer association from other projects, like Linux and QEMU.) Thanks Laszlo