From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 20 Jun 2019 08:30:10 -0700 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8D2D2A836; Thu, 20 Jun 2019 15:29:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-117-226.ams2.redhat.com [10.36.117.226]) by smtp.corp.redhat.com (Postfix) with ESMTP id 053A719C5B; Thu, 20 Jun 2019 15:29:56 +0000 (UTC) Subject: Re: [edk2-devel] [RFC PATCH 2/3] Maintainers.txt: add wildcard path association for Arm/AArch64 To: devel@edk2.groups.io, leif.lindholm@linaro.org Cc: "Feng, Bob C" , Liming Gao , Andrew Fish , Michael D Kinney , "Wu, Hao A" References: <20190614202121.18952-3-leif.lindholm@linaro.org> From: "Laszlo Ersek" Message-ID: Date: Thu, 20 Jun 2019 17:29:55 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190614202121.18952-3-leif.lindholm@linaro.org> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Thu, 20 Jun 2019 15:29:58 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hi Leif, On 06/14/19 22:21, Leif Lindholm wrote: > Add Ard and Leif as responsible for any path matching > F: */Arm/ > F: */AArch64/ > > Signed-off-by: Leif Lindholm > --- > Maintainers.txt | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/Maintainers.txt b/Maintainers.txt > index cd32f9b00170..e415f51468d5 100644 > --- a/Maintainers.txt > +++ b/Maintainers.txt > @@ -82,6 +82,14 @@ EDK II Releases: > W: https://github.com/tianocore/tianocore.github.io/wiki/EDK-II-Release-Planning > M: Liming Gao > > +EDK II Architectures: > +--------------------- > +ARM, AARCH64 > +F: */AArch64/ > +F: */Arm/ > +M: Leif Lindholm > +M: Ard Biesheuvel > + > EDK II Packages: > ---------------- > ArmPkg > I'm a bit confused now. * In the blurb, you write, "Wildcard support is not fully filesystem compliant except in *first* or last position in the path" (emphasis mine). That would invalidate the present patch (because I gather your intent is to match any pathname that has *any* component called Aarch64 or Arm). * Upon checking the third patch in the series, the "first position" exception doesn't seem to be implemented actually. Which should make the present patch work, in practice. And, we could ignore the statement in the blurb (given that the blurb is never captured in the git history). * However... the explanation from the first patch of the series, namely + F: */net/* all files in "any top level directory"/net conflicts with the script then! So right now, we have 6 locations: (a) the blurb (b) the "All patches CC:d here" section from Maintainers.txt (c) the "Tianocore Stewards" section from Maintainers.txt (d) the "F: */net/*" example pattern from Maintainers.txt (e) the present patch (f) the script (patch #3) Locations (a) through (d) say that "*" in the first position matches top level entries only, while (d) and (e) state "*" in the first position matches any -- possibly multi-component -- pathname prefix. It's one thing that we can make the script in patch #3 conform to what the blurb says. But, that still leaves us with the problem that patches #1 and #2, considered together, use "*" in the first position in opposite senses. Thanks, Laszlo