From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: redhat.com, ip: 209.132.183.28, mailfrom: lersek@redhat.com) Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by groups.io with SMTP; Thu, 26 Sep 2019 05:12:59 -0700 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 98A32A44AC7; Thu, 26 Sep 2019 12:12:58 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-49.rdu2.redhat.com [10.10.120.49]) by smtp.corp.redhat.com (Postfix) with ESMTP id C978B5C220; Thu, 26 Sep 2019 12:12:57 +0000 (UTC) Subject: Re: [edk2-devel] [PATCH 03/35] EmbeddedPkg/AndroidFastbootTransportTcpDxe: fix DestroyChild() call From: "Laszlo Ersek" To: edk2-devel-groups-io Cc: Ard Biesheuvel , Leif Lindholm Reply-To: devel@edk2.groups.io, lersek@redhat.com References: <20190917194935.24322-1-lersek@redhat.com> <20190917194935.24322-4-lersek@redhat.com> Message-ID: Date: Thu, 26 Sep 2019 14:12:56 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190917194935.24322-4-lersek@redhat.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.6.2 (mx1.redhat.com [10.5.110.68]); Thu, 26 Sep 2019 12:12:58 +0000 (UTC) Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Leif, Ard, On 09/17/19 21:49, Laszlo Ersek wrote: > - The 2nd parameter of EFI_SERVICE_BINDING_CREATE_CHILD is: > > IN OUT EFI_HANDLE *ChildHandle > > - The 2nd parameter of EFI_SERVICE_BINDING_DESTROY_CHILD is: > > IN EFI_HANDLE ChildHandle > > Fix the DestroyChild() call in TcpFastbootTransportStop(). > > This is an actual bugfix; I don't know why the current code doesn't crash. > Perhaps the function is never reached in practice? (It could be tied to an > error path.) > > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Laszlo Ersek > --- > > Notes: > build-tested only > > EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) can you please ACK this one too? (Apologies if it's already on your radar.) Thanks! Laszlo > diff --git a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > index 29f23a82c75f..34f9ba74e4db 100644 > --- a/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > +++ b/EmbeddedPkg/Drivers/AndroidFastbootTransportTcpDxe/FastbootTransportTcp.c > @@ -503,7 +503,7 @@ TcpFastbootTransportStop ( > Status = mTcpListener->Configure (mTcpListener, NULL); > ASSERT_EFI_ERROR (Status); > > - Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, &mTcpHandle); > + Status = mTcpServiceBinding->DestroyChild (mTcpServiceBinding, mTcpHandle); > > // Free any data the user didn't pick up > Entry = (FASTBOOT_TCP_PACKET_LIST *) GetFirstNode (&mPacketListHead); >