From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (NAM11-DM6-obe.outbound.protection.outlook.com [40.107.223.73]) by mx.groups.io with SMTP id smtpd.web10.5546.1676424801204138769 for ; Tue, 14 Feb 2023 17:33:21 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@amd.com header.s=selector1 header.b=ctOspxOH; spf=permerror, err=parse error for token &{10 18 %{i}._ip.%{h}._ehlo.%{d}._spf.vali.email}: invalid domain name (domain: amd.com, ip: 40.107.223.73, mailfrom: pankaj.gupta@amd.com) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=ll7TBqFd9XoQLH+qIo6hfJ74SML/gtM6ukem+aeNC/hVCZzK9DOeqU6N3quWkPv/ddvEo2qHzOpAZuj5Wog9Cz2yKxj68XklbfSOmv4SZNf9K/+p1Sduwdh0/h8Ww2sPxxvszIBJVzV1xl7iaEgY8/iAjsQUYwbV0rjfvE11uGOSsS+adix7Fbui2h+vc6bscKB9shvSeh4kMcCOGN7f4/qROn17cr+EKSsDvLdjDaEoiFCeTpQuKxE146SXmWQLsgwZMnuialY+BLbOInLkbLfuQX3kNuQdqWc0/BU2ZhD1HGXiKS8WvJ4u63NUbjCvhUD+0MLlYVBB2fVvN/1F/A== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/hTL2EYPgCkvtryVYDJW18N3ulevxPLNOju5dp5rj4U=; b=oflOBlLy7wPZS++tfL1di90k/+/85c4Vyyb46jreM2D5BqtxijI3nFaweWXt82F9Vy9hq7VBqMxB4ktn2ijgFm9vBLH5dgyByQ+pTPNZgWsX1i0T4eLeborJzTxLrssQjUrL0OKkK7AbtXZmO6hj/PUUYHtK1aHbJgAmrNxqgb1H11+GVD02nAgcbrfUfcJIFokTAtp5lYz6wGIfezmlypsLsZnCM4Y0aYozra3yFFLC8BWB9pKnhebe9LOQWvzQUjVKq0hC5vokV+WMHTd8yVzn1D1IwE4j1cj41Y+rGAKgXLF8FUnwD9Y32moUdQGLazCRhvbS9+Kp2IKh5zm7uA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/hTL2EYPgCkvtryVYDJW18N3ulevxPLNOju5dp5rj4U=; b=ctOspxOHB8Y6KGPxCdnSD1RtgMDW6J4F+WkIAhajwR5gt9/liByXtZcJ6gAtlLZMIBege+g3vz8iAlWEiKhAMUqv4357Bf4QIjBYXQJ4/fupD6ZPX6E4pIYdTyWHkeVvJbYJskHndrTE8xDtOS3L4QdBj0XQABj5ydrhwi9Z+rQ= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) by BL1PR12MB5144.namprd12.prod.outlook.com (2603:10b6:208:316::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6086.26; Wed, 15 Feb 2023 01:33:19 +0000 Received: from DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef]) by DM6PR12MB2810.namprd12.prod.outlook.com ([fe80::b84e:f638:fa40:27ef%6]) with mapi id 15.20.6086.024; Wed, 15 Feb 2023 01:33:19 +0000 Message-ID: Date: Wed, 15 Feb 2023 02:33:12 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.6.0 Subject: Re: [edk2-devel] [PATCH] OvmfPkg: Close mAcceptAllMemoryEvent To: devel@edk2.groups.io, dionnaglaze@google.com Cc: Ard Biesheuvel , Thomas Lendacky , Erdem Aktas , James Bottomley , Jiewen Yao , Min Xu , Michael Roth References: <20230214230719.1457783-1-dionnaglaze@google.com> From: "Gupta, Pankaj" In-Reply-To: <20230214230719.1457783-1-dionnaglaze@google.com> X-ClientProxiedBy: FR0P281CA0063.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:49::11) To DM6PR12MB2810.namprd12.prod.outlook.com (2603:10b6:5:41::21) Return-Path: Pankaj.Gupta@amd.com MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: DM6PR12MB2810:EE_|BL1PR12MB5144:EE_ X-MS-Office365-Filtering-Correlation-Id: 3248d366-56c9-46af-e858-08db0ef49e06 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: iH241UbCsw6YMW+l/EREWSc/Tn8cjCkv22aP3n49YOBJQ24FSDnhp4oYFujS3wdqp1Oh45JSIMIg5UybvtE2Em6nxhn8ufbFWUaopTng0pgcNy10Ai+aTQLtVGyPWC63gVNE05d4qt4nvkWvWlyVIGZH93vQxJyPoL4jy+vFDovsAGKas0Y+FvQXip1KeRqWxpNYvzNUSAsdiePDffnvCqgN3+64ByDfpOYGfv3+vtBhjVha7pHkHdmC8tGZ7PttVDGiCpFBlDgNU5w2OQpZ/bXM0YgpL0NVQX2nWPsQs4d+wFkcXBRFa0YJEAbDGdwfLqP6v2VO4yFxnNj7E67P0rUmIpWvpeERUDzYZP/fm091C49twJ2Z8O+65PymbNVyCid7eYDA/BUDicNaf4haMwvJUOdTBombDEAjpq0ko8A/qoGWAgNxpCMRlG3ScNiurmq1tR5l0uYVXwfmkCYdbVIqwCxeTHkX3lqyzfFbaBAMoMEapSI8w/juEH+UTxwdAb2SjXyS46Pa9MAqmQj64V099q/tcjXwIC5a3CeoXumqH50M73Jym/8ug9DsjAdKs42/2UD99+FN63hKYh9gmZGAm40/RlVH4i1qLSo3jIYrzOwejRA+T1nbTwHDBAbwp5754Ldt89X1dkDZxCMv+iuBo5pwA+siczbiTfDJD5Kz+e2NqzZeWoxcEq8eQXCyUuLJNeQbeP248As9+OpEOmk7J+ofYcKmGsMyJH16CmG3LKs5ByTfmGooLepc79WDrhPZYVe/RqLz5KnGQ48I0ExAy9cJUGnkOLgj2bQy9uA= X-Forefront-Antispam-Report: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:DM6PR12MB2810.namprd12.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230025)(4636009)(366004)(376002)(136003)(346002)(39860400002)(396003)(451199018)(316002)(478600001)(6486002)(31696002)(2906002)(86362001)(38100700002)(6506007)(53546011)(6666004)(2616005)(186003)(26005)(6512007)(54906003)(5660300002)(83380400001)(36756003)(4326008)(66946007)(41300700001)(31686004)(8676002)(66556008)(66476007)(8936002)(145543001)(145603002)(45980500001)(43740500002);DIR:OUT;SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?RUM4TkgvaHlSb1lrSnRzNTkxMWJ2ZUt1TzRsWW81RTAvcFFzVUlOeVVDWnZP?= =?utf-8?B?U3hPLytycmZmWjNLaFdGRXRjejJiYmc1dXA1VVNaQ09CaGNtWi9aVS9veU4y?= =?utf-8?B?VXlsbnZ3eWpYVkxuajR6NFlIN2J1TC85V1YwQXIwMll0ZDk1TFpucnpZc3p1?= =?utf-8?B?QjRMNHNzUkxMZjZrTmxCa2FBYWlEOWNJMVF2RXhHQTBkUVp3R1haK09lZjFB?= =?utf-8?B?YzFGemhWS2x5YmR3ajlOdk9vTVAvRVZkUXk0TjY3REZ5czBvc1Y2MmUwWXh0?= =?utf-8?B?V3hEMENmTGpQSzlmRVVwaW12Tjl1aktpbyt0elBqWUFoSmFWdnpWNXpWajFP?= =?utf-8?B?STJ2c3Axdk5vYTRjLzRhMlNwYWdpTHNSaWxFY0J2WWVkb0wzZFFHdDRSc3dE?= =?utf-8?B?bWd2Y3oxaGx2VEVBVEtKUEppZSsrZVM0WGNyWnp1MlJwcG1HOVY4UmpMTFBI?= =?utf-8?B?WDY4dVYveVI1b3I5Y1BoUXByWlhsWnQvMXJGdGNnbHdRVnpWMmZjaWl3R3Y3?= =?utf-8?B?dzRJcHBBKzlVRzA5SjFEZEw3QzhEMW96eFdCZk4rd3FWUElTOEdpVDBES211?= =?utf-8?B?TkMvV0pVWkVMZjFuVnFrRUhOSjVpWWE2UUtPQlpaU09EU1IzUDQrbElCNStN?= =?utf-8?B?Ny8ydUZiZ1pnKzV2RHJWKy9aUnZ4U214US9EYXp4QVZGM1Y2RVRJenJlOEY5?= =?utf-8?B?d0k2dllOUmZ2N3A4SnhpZ1U5a2cvejFzY2pxMWxhTDNQRTBWNGRYL2ZIYXh3?= =?utf-8?B?emg5Vnh6YTZaYUR3dUh3QStHbTlPY1dRUXBNV1U3RXkxMklZa0x4d2QwUVFl?= =?utf-8?B?bUN3amR0V2NmL3Rqd1lLemFXY2xUYUJhbllkdlA5dHNMWUNCUldGZ2xCSEZF?= =?utf-8?B?YkxUWWZCNkUramYrRHN1R0laM0hzOWdBUW54QnFlQU1JcVdsRnRnK3I1Rm4y?= =?utf-8?B?MDgrRFRJd3YyTGlMZWQzTkxpaUlGRVg4ZGhFUzhZT21CSGswVGFyTFFEazZD?= =?utf-8?B?REpSQmF2ODl2MEhFYytOR2NwTnpZcWVwRGR1RXVBcnowZ0tWOVNKdndYY2x5?= =?utf-8?B?aS9uUytsV3JkSXVUKzVLdDFZelVpQS9QM3FDWWw5cisrZFMrZXBQa21MU2JL?= =?utf-8?B?b0RvV3RpTkRHYTNDQ1hlcm5kRGpnNG1LVnYxOXE0cTZqeE0yQkRtZUpjR2lU?= =?utf-8?B?OTdQZ2pISjV3MGkva2svVi83L1NCQ0xhcjdjL1NJSmlpaThFODhzbXltMUVh?= =?utf-8?B?UGw2OUNJdXozWTVUMXhEL293c0xsb0xlWnNjTmdTMHVnREpKWG4reUhmUkdu?= =?utf-8?B?L1ZRVzhySG15d0Q5KzJ5ck05VlUvKzNKZFZkazdaTm1QWElpWGIwOWViSmc1?= =?utf-8?B?Zk5JcHBrSVgzRXhKZE9nZzFLL2JpQjdjUlhSSHA5NXlzdmpRbFpjSU1xcXFl?= =?utf-8?B?QzhnMzFqb3VUOHZIVDVmY2U2dTBCcWdhNzh4ZFU0Mk4zWThXZm96Q2xoTGFk?= =?utf-8?B?dEZEUk1lOVNJRVhVS3RMWnFXdzBnT3BtVXoyM0owbjF0Tm51NUEyeTcrVlQw?= =?utf-8?B?MzZkMmkxbnF5ZWdqWDNYQ3Avc2xmR2NKSk9FQmN6djE0M0RodHdaaXZtNEtt?= =?utf-8?B?QXNXT1JqN2Qxak1IVVBwV3BIQkx0K1piL21QcXdhdVZHSTQzdWY2T0dmdG5W?= =?utf-8?B?NEZ5ZVdUbURKWlVYWndOR0lsQUhaS0cyL2JhYXNLZXRPVlRkeThuYnNkNGU3?= =?utf-8?B?YXlEVWtKTy9tWkE0ZlRNaEROMVNOVzN6OG9Rc25vbVlnNTU3M3luUjE1amZS?= =?utf-8?B?MmQ4RDV6NmhWWlBVZzJuS1I4WDB5S2w0M0l6TTdVclh2YzNhN2tRVVczbEZm?= =?utf-8?B?UVRsV1RCc3R6U3pNUmttT2lZaVc4N1ZJY2FaZFpHNVBENWZWcmJsZlMyaDNB?= =?utf-8?B?V3dRVVV2NjNvam5pNjg0ZzJlZnFwd3NIdmV5OGhDWnpUM0RNWFozaWdWYnE1?= =?utf-8?B?Y2hCa0Q2Z1pBU3V6YURPN0RWeElJSktDV25IR3VydlVrMVJOTUpacU1aTVdI?= =?utf-8?B?c21nR296ZUIxTk5PdGNtVWFpa0xHcHZyekVaQmpQTWovTkpXdENsRlJKS1Fi?= =?utf-8?Q?T2A1YwF6vuvKlDgFixirTA1aF?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 3248d366-56c9-46af-e858-08db0ef49e06 X-MS-Exchange-CrossTenant-AuthSource: DM6PR12MB2810.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Feb 2023 01:33:19.1306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bC9CtmPYpfbjXCWQoZt7ZdL+OsFB2p/g3pG7ZnsMz+k/epucqYgeBlysrBon3AbVZRbK8sVne84u3tu5uFRQVw== X-MS-Exchange-Transport-CrossTenantHeadersStamped: BL1PR12MB5144 Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 2/15/2023 12:07 AM, Dionna Glaze via groups.io wrote: > This event should only trigger once. It should be idempotent, but the > allocation of the memory map itself is observable and can cause > ExitBootServices to fail with a modified map key. > > Cc: Ard Biesheuvel > Cc: Thomas Lendacky > Cc: Erdem Aktas > Cc: James Bottomley > Cc: Jiewen Yao > Cc: Min Xu > Cc: Michael Roth > > Signed-off-by: Dionna Glaze > --- > OvmfPkg/AmdSevDxe/AmdSevDxe.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/OvmfPkg/AmdSevDxe/AmdSevDxe.c b/OvmfPkg/AmdSevDxe/AmdSevDxe.c > index 6391d1f775..f9baca90bd 100644 > --- a/OvmfPkg/AmdSevDxe/AmdSevDxe.c > +++ b/OvmfPkg/AmdSevDxe/AmdSevDxe.c > @@ -124,6 +124,7 @@ AcceptAllMemory ( > } > > gBS->FreePool (AllDescMap); > + gBS->CloseEvent (mAcceptAllMemoryEvent); > return Status; > } Reviewed-by: Pankaj Gupta Tested-by: Pankaj Gupta Fixes: a00e2e5513 ("OvmfPkg: Add memory acceptance event in AmdSevDxe")