From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web10.1482.1602096273636664673 for ; Wed, 07 Oct 2020 11:44:33 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: ard.biesheuvel@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 4ADF11042; Wed, 7 Oct 2020 11:44:33 -0700 (PDT) Received: from [192.168.1.81] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 218133F71F; Wed, 7 Oct 2020 11:44:31 -0700 (PDT) Subject: Re: [PATCH v1 1/1] [CryptoPkg] Add CC flags for MSVC ARM on IntrinsicLib To: matthewfcarlson@gmail.com, devel@edk2.groups.io Cc: Jiewen Yao , Jian J Wang , Xiaoyu Lu , Guomin Jiang , Leif Lindholm References: <20201007184145.5232-1-matthewfcarlson@gmail.com> <20201007184145.5232-2-matthewfcarlson@gmail.com> From: "Ard Biesheuvel" Message-ID: Date: Wed, 7 Oct 2020 20:44:30 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.10.0 MIME-Version: 1.0 In-Reply-To: <20201007184145.5232-2-matthewfcarlson@gmail.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/7/20 8:41 PM, matthewfcarlson@gmail.com wrote: > From: Matthew Carlson > > This adds compiler flags for AARCH64 and ARM for the Visual Studio > compilers to the IntrinsicLib inf. > > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2821 > > Cc: Jiewen Yao > Cc: Jian J Wang > Cc: Xiaoyu Lu > Cc: Guomin Jiang > Cc: Ard Biesheuvel > Cc: Leif Lindholm > Signed-off-by: Matthew Carlson Hi Matt, Please don't put the package name in [] in the subject line. That will cause 'git am' to strip it when applying the patch. Acked-by: Ard Biesheuvel > --- > CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf b/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > index fcbb93316cf7..ad05b3a000c4 100644 > --- a/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > +++ b/CryptoPkg/Library/IntrinsicLib/IntrinsicLib.inf > @@ -64,4 +64,6 @@ > MSFT:RELEASE_*_IA32_CC_FLAGS == /nologo /c /WX /GS- /W4 /Gs32768 /D UNICODE /O1b2 /FIAutoGen.h /EHs-c- /GR- /GF > MSFT:DEBUG_*_X64_CC_FLAGS == /nologo /c /WX /GS- /X /W4 /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF /Zi /Gm > MSFT:RELEASE_*_X64_CC_FLAGS == /nologo /c /WX /GS- /X /W4 /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF > - INTEL:*_*_*_CC_FLAGS = /Oi- > + MSFT:DEBUG_*_AARCH64_CC_FLAGS == /nologo /c /WX /GS- /X /W4 /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF /Zi /Gm > + MSFT:RELEASE_*_AARCH64_CC_FLAGS == /nologo /c /WX /GS- /X /W4 /Gs32768 /D UNICODE /O1b2s /Gy /FIAutoGen.h /EHs-c- /GR- /GF > + INTEL:*_*_*_CC_FLAGS = /Oi- >