public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: Laszlo Ersek <lersek@redhat.com>
To: Hao Wu <hao.a.wu@intel.com>, edk2-devel@lists.01.org
Cc: Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@linaro.org>,
	Ray Ni <ray.ni@intel.com>,
	Michael Kinney <michael.d.kinney@intel.com>
Subject: Re: [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver
Date: Mon, 25 Mar 2019 13:00:16 +0100	[thread overview]
Message-ID: <c7e14b4a-211f-9428-a262-6116df6551f7@redhat.com> (raw)
In-Reply-To: <20190325052853.11220-3-hao.a.wu@intel.com>

Hello Hao,

(+Mike)

my apologies that I seem unable to collect my thoughts in one go... So
here's another comment:

On 03/25/19 06:28, Hao Wu wrote:

> diff --git a/OvmfPkg/SioBusDxe/SioBusDxe.inf b/OvmfPkg/SioBusDxe/SioBusDxe.inf
> new file mode 100644
> index 0000000000..5c462f1a8c
> --- /dev/null
> +++ b/OvmfPkg/SioBusDxe/SioBusDxe.inf
> @@ -0,0 +1,54 @@
> +## @file
> +#  The SioBusDxe driver is used to create child devices on the ISA bus and
> +#  installs the Super I/O protocols on them.
> +#
> +#  Copyright (c) 2019, Intel Corporation. All rights reserved.<BR>
> +#
> +#  This program and the accompanying materials
> +#  are licensed and made available under the terms and conditions of the BSD License
> +#  which accompanies this distribution.  The full text of the license may be found at
> +#  http://opensource.org/licenses/bsd-license.php
> +#
> +#  THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS,
> +#  WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED.
> +#
> +##

[...]

This patch adds 7 new instances of the 2-clause BSDL (in expanded form)
to the edk2 tree. In that it conflicts with Mike's work for
<https://bugzilla.tianocore.org/show_bug.cgi?id=1373>. Can you please
rework this patch so that the new files say

  SPDX-License-Identifier: BSD-2-Clause-Patent

instead?

Thanks,
Laszlo


  parent reply	other threads:[~2019-03-25 12:00 UTC|newest]

Thread overview: 28+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-25  5:28 [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg Hao Wu
2019-03-25  5:28 ` [PATCH v2 1/3] OvmfPkg: Drop the ISA Floppy device support Hao Wu
2019-03-25 10:42   ` Laszlo Ersek
2019-03-25  5:28 ` [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver Hao Wu
2019-03-25 11:22   ` Laszlo Ersek
2019-03-26  2:52     ` Wu, Hao A
2019-03-25 12:00   ` Laszlo Ersek [this message]
2019-03-25 17:30     ` Kinney, Michael D
2019-03-25 18:33       ` Laszlo Ersek
2019-03-25 20:02         ` Kinney, Michael D
2019-03-26 11:19           ` Laszlo Ersek
2019-03-25  5:28 ` [PATCH v2 3/3] OvmfPkg: Add a build flag to select ISA driver stack Hao Wu
2019-03-25 11:20   ` Laszlo Ersek
2019-03-25  8:28 ` [PATCH v2 0/3] Ovmf: Stop using ISA drivers within IntelFrameworkModulePkg Ard Biesheuvel
2019-03-25 10:58 ` Laszlo Ersek
2019-03-25 11:29   ` Laszlo Ersek
2019-03-26  2:49     ` Wu, Hao A
2019-03-26 10:14       ` Laszlo Ersek
2019-03-26 11:21         ` Laszlo Ersek
2019-03-26 10:09     ` Julien Grall
2019-03-26 11:53       ` Laszlo Ersek
2019-03-26 13:03     ` Anthony PERARD
2019-03-26 15:01       ` Laszlo Ersek
2019-03-26 15:14         ` Anthony PERARD
2019-03-26 15:15         ` Laszlo Ersek
2019-03-27  0:20           ` Wu, Hao A
2019-03-27  3:37             ` Laszlo Ersek
2019-03-27  5:28               ` Wu, Hao A

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7e14b4a-211f-9428-a262-6116df6551f7@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox