From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 35DE8211EABAB for ; Mon, 25 Mar 2019 05:00:33 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4DBAB7C0A5; Mon, 25 Mar 2019 12:00:23 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-188.rdu2.redhat.com [10.10.120.188]) by smtp.corp.redhat.com (Postfix) with ESMTP id AACC860C9A; Mon, 25 Mar 2019 12:00:17 +0000 (UTC) To: Hao Wu , edk2-devel@lists.01.org Cc: Jordan Justen , Ard Biesheuvel , Ray Ni , Michael Kinney References: <20190325052853.11220-1-hao.a.wu@intel.com> <20190325052853.11220-3-hao.a.wu@intel.com> From: Laszlo Ersek Message-ID: Date: Mon, 25 Mar 2019 13:00:16 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <20190325052853.11220-3-hao.a.wu@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.25]); Mon, 25 Mar 2019 12:00:32 +0000 (UTC) Subject: Re: [PATCH v2 2/3] OvmfPkg: Add an Super IO bus driver X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 25 Mar 2019 12:00:33 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Hello Hao, (+Mike) my apologies that I seem unable to collect my thoughts in one go... So here's another comment: On 03/25/19 06:28, Hao Wu wrote: > diff --git a/OvmfPkg/SioBusDxe/SioBusDxe.inf b/OvmfPkg/SioBusDxe/SioBusDxe.inf > new file mode 100644 > index 0000000000..5c462f1a8c > --- /dev/null > +++ b/OvmfPkg/SioBusDxe/SioBusDxe.inf > @@ -0,0 +1,54 @@ > +## @file > +# The SioBusDxe driver is used to create child devices on the ISA bus and > +# installs the Super I/O protocols on them. > +# > +# Copyright (c) 2019, Intel Corporation. All rights reserved.
> +# > +# This program and the accompanying materials > +# are licensed and made available under the terms and conditions of the BSD License > +# which accompanies this distribution. The full text of the license may be found at > +# http://opensource.org/licenses/bsd-license.php > +# > +# THE PROGRAM IS DISTRIBUTED UNDER THE BSD LICENSE ON AN "AS IS" BASIS, > +# WITHOUT WARRANTIES OR REPRESENTATIONS OF ANY KIND, EITHER EXPRESS OR IMPLIED. > +# > +## [...] This patch adds 7 new instances of the 2-clause BSDL (in expanded form) to the edk2 tree. In that it conflicts with Mike's work for . Can you please rework this patch so that the new files say SPDX-License-Identifier: BSD-2-Clause-Patent instead? Thanks, Laszlo