public inbox for devel@edk2.groups.io
 help / color / mirror / Atom feed
From: "Laszlo Ersek" <lersek@redhat.com>
To: Michael D Kinney <michael.d.kinney@intel.com>, devel@edk2.groups.io
Cc: Sean Brogan <sean.brogan@microsoft.com>,
	Bret Barkelew <Bret.Barkelew@microsoft.com>,
	Liming Gao <gaoliming@byosoft.com.cn>,
	Jordan Justen <jordan.l.justen@intel.com>,
	Ard Biesheuvel <ard.biesheuvel@arm.com>
Subject: Re: [Patch][edk2-stable202011 3/3] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU
Date: Wed, 25 Nov 2020 15:03:41 +0100	[thread overview]
Message-ID: <c7ff4829-1968-3038-51c2-319a63a6e5d6@redhat.com> (raw)
In-Reply-To: <20201125021137.1835-4-michael.d.kinney@intel.com>

On 11/25/20 03:11, Michael D Kinney wrote:
> Install the 2020.08.14 release of QEMU for Windows.
> 
> The QEMU release from 2020.11.20 is installed into the incorrect
> directory and is causing EDK II CI failures in the run to shell
> step.
> 
> Cc: Sean Brogan <sean.brogan@microsoft.com>
> Cc: Bret Barkelew <Bret.Barkelew@microsoft.com>
> Cc: Liming Gao <gaoliming@byosoft.com.cn>
> Cc: Jordan Justen <jordan.l.justen@intel.com>
> Cc: Laszlo Ersek <lersek@redhat.com>
> Cc: Ard Biesheuvel <ard.biesheuvel@arm.com>
> Signed-off-by: Michael D Kinney <michael.d.kinney@intel.com>
> ---
>  OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> index 02ed233fdb60..dd19fff50066 100644
> --- a/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> +++ b/OvmfPkg/PlatformCI/.azurepipelines/Windows-VS2019.yml
> @@ -132,7 +132,7 @@ jobs:
>          build_flags: $(Build.Flags)
>          run_flags: $(Run.Flags)
>          extra_install_step:
> -        - powershell: choco install qemu; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
> +        - powershell: choco install qemu --version=2020.08.14; Write-Host "##vso[task.prependpath]c:\Program Files\qemu"
>            displayName: Install QEMU and Set QEMU on path # friendly name displayed in the UI
>            condition: and(gt(variables.pkg_count, 0), succeeded())
>  
> 

Acked-by: Laszlo Ersek <lersek@redhat.com>

I agree this is eligible for edk2-stable202011.

Thanks
Laszlo


  reply	other threads:[~2020-11-25 14:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-11-25  2:11 [Patch][edk2-stable202011 0/3] Address EDK II CI Failures Michael D Kinney
2020-11-25  2:11 ` [Patch][edk2-stable202011 1/3] .azurepipelines/templates/pr-gate-steps.yml: Fetch target branch Michael D Kinney
2020-11-25  2:11 ` [Patch][edk2-stable202011 2/3] .azurepipelines/templates/platform-build-run-steps.yml: " Michael D Kinney
2020-11-25  2:11 ` [Patch][edk2-stable202011 3/3] OvmfPkg/PlatformCI/.azurepiplines: Use stable release of QEMU Michael D Kinney
2020-11-25 14:03   ` Laszlo Ersek [this message]
2020-11-25  2:17 ` [edk2-devel] [Patch][edk2-stable202011 0/3] Address EDK II CI Failures Michael D Kinney
2020-11-25  3:01   ` 回复: " gaoliming
2020-11-25  4:03     ` Michael D Kinney

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-list from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c7ff4829-1968-3038-51c2-319a63a6e5d6@redhat.com \
    --to=devel@edk2.groups.io \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox