From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail02.groups.io (mail02.groups.io [66.175.222.108]) by spool.mail.gandi.net (Postfix) with ESMTPS id C3541AC1631 for ; Wed, 23 Aug 2023 17:18:44 +0000 (UTC) DKIM-Signature: a=rsa-sha256; bh=MefQHApSTWigRu64irWXpfZeCP/fHoUM7WGbjLcKkz4=; c=relaxed/simple; d=groups.io; h=Date:From:To:Cc:Subject:Message-ID:References:MIME-Version:In-Reply-To:Precedence:List-Subscribe:List-Help:Sender:List-Id:Mailing-List:Delivered-To:Reply-To:List-Unsubscribe-Post:List-Unsubscribe:Content-Type:Content-Disposition; s=20140610; t=1692811123; v=1; b=BqvuIhrYH7fqNxeNb6KlHOqslaFrHlPZcXg27oxCDQzYm8zOWH9tBUwlNMOJ66umZ2fvv3vW VN2imtzAcPoLin+zZ7GTxx9WNiizAez4d232PeS/5htoTxJiqRk8fVNaYeG3K0xlg+AnIwibvg9 aR1/wSknrqlGVpeGub7J2UpU= X-Received: by 127.0.0.2 with SMTP id twyAYY7687511xnkHHreQqzl; Wed, 23 Aug 2023 10:18:43 -0700 X-Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by mx.groups.io with SMTP id smtpd.web11.2541.1692811122706829026 for ; Wed, 23 Aug 2023 10:18:42 -0700 X-Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-378-ZhOKsV3uPau58i5u918cNA-1; Wed, 23 Aug 2023 13:18:40 -0400 X-MC-Unique: ZhOKsV3uPau58i5u918cNA-1 X-Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.rdu2.redhat.com [10.11.54.7]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 988AD8432AF; Wed, 23 Aug 2023 17:18:39 +0000 (UTC) X-Received: from sirius.home.kraxel.org (unknown [10.39.194.126]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 625E6140E950; Wed, 23 Aug 2023 17:18:39 +0000 (UTC) X-Received: by sirius.home.kraxel.org (Postfix, from userid 1000) id 1744518009E6; Wed, 23 Aug 2023 19:18:38 +0200 (CEST) Date: Wed, 23 Aug 2023 19:18:38 +0200 From: "Gerd Hoffmann" To: Ard Biesheuvel Cc: devel@edk2.groups.io, Jiewen Yao , Michael Brown Subject: Re: [edk2-devel] [RFC/RFT PATCH] OvmfPkg/IoMmuDxe: don't rely on TPLs for re-entrancy Message-ID: References: <20230720134557.3903923-1-ardb@kernel.org> MIME-Version: 1.0 In-Reply-To: X-Scanned-By: MIMEDefang 3.1 on 10.11.54.7 X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Precedence: Bulk List-Subscribe: List-Help: Sender: devel@edk2.groups.io List-Id: Mailing-List: list devel@edk2.groups.io; contact devel+owner@edk2.groups.io Reply-To: devel@edk2.groups.io,kraxel@redhat.com List-Unsubscribe-Post: List-Unsubscribe=One-Click List-Unsubscribe: X-Gm-Message-State: ucgKfrD43BLvkHGz2Iqf79Rfx7686176AA= Content-Type: text/plain; charset=us-ascii Content-Disposition: inline X-GND-Status: LEGIT Authentication-Results: spool.mail.gandi.net; dkim=pass header.d=groups.io header.s=20140610 header.b=BqvuIhrY; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=redhat.com (policy=none); spf=pass (spool.mail.gandi.net: domain of bounce@groups.io designates 66.175.222.108 as permitted sender) smtp.mailfrom=bounce@groups.io On Wed, Aug 23, 2023 at 05:11:49PM +0200, Ard Biesheuvel wrote: > On Wed, 23 Aug 2023 at 13:08, Gerd Hoffmann wrote: > > > > On Tue, Aug 22, 2023 at 09:57:12AM +0200, Ard Biesheuvel wrote: > > > On Tue, 22 Aug 2023 at 08:25, Gerd Hoffmann wrote: > > > > > > > > Looks good to me. > > > > > > > > What is the status? Merged? Or waiting for testing still? If so I can > > > > create a test build with the patch and ask our QE department to check > > > > it. > > > > > > > > > > Still waiting for testing, so yes, please test. > > > > Hmm, QE reports back it slows down the boot alot. No boot hangs yet > > with 12 test runs so far, which isn't that much for a reproduce rate > > below 20% ... > > > > https://bugzilla.redhat.com//show_bug.cgi?id=2211060#c28 > > > > So I guess we go with the TPL version for the coming stable tag and > > leave any improvements for later ... > > > > Yeah, this was not going to make the stable tag in any case. > > The boot speed regression seems odd, though - this is effectively UP > code so there shouldn't be any contention, the only thing this patch > does is ensure that the critical section is restarted if it was > interrupted > > Are we comparing apples with apples here? Hoping for an answer tomorrow, asked QE folks the same thing in comment 30. The first test build (comment 11) essentially is stable-2023-05 with a52044a9e602 ("OvmfPkg/IoMmuDxe: add locking to IoMmuAllocateBounceBuffer") cherry-picked, the second test build (comment 27) is stable-2023-05 + a52044a9e602 + this patch. take care, Gerd -=-=-=-=-=-=-=-=-=-=-=- Groups.io Links: You receive all messages sent to this group. View/Reply Online (#107986): https://edk2.groups.io/g/devel/message/107986 Mute This Topic: https://groups.io/mt/100256049/7686176 Group Owner: devel+owner@edk2.groups.io Unsubscribe: https://edk2.groups.io/g/devel/unsub [rebecca@openfw.io] -=-=-=-=-=-=-=-=-=-=-=-