From: "Philippe Mathieu-Daudé" <philmd@redhat.com>
To: devel@edk2.groups.io, dwmw2@infradead.org,
Laszlo Ersek <lersek@redhat.com>
Cc: Antoine Coeur <coeur@gmx.fr>,
Jordan Justen <jordan.l.justen@intel.com>,
Ard Biesheuvel <ard.biesheuvel@linaro.org>
Subject: Re: [edk2-devel] [PATCH 57/79] OvmfPkg/Csm: Fix various typos
Date: Wed, 4 Dec 2019 15:07:22 +0100 [thread overview]
Message-ID: <c812834a-d277-b77b-63dc-b0ba2b045334@redhat.com> (raw)
In-Reply-To: <e1ceb92a6a1c0a226b10cc3c8793041bea74c3cc.camel@infradead.org>
On 12/4/19 12:31 AM, David Woodhouse wrote:
> On Tue, 2019-12-03 at 21:50 +0100, Laszlo Ersek wrote:
>> On 12/03/19 17:15, Philippe Mathieu-Daude wrote:
>>> From: Antoine Coeur <coeur@gmx.fr>
>>>
>>> Fix various typos in documentation, comments and strings.
>>>
>>> Cc: Jordan Justen <jordan.l.justen@intel.com>
>>> Cc: Laszlo Ersek <lersek@redhat.com>
>>> Cc: Ard Biesheuvel <ard.biesheuvel@linaro.org>
>>> Reviewed-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> Signed-off-by: Philippe Mathieu-Daude <philmd@redhat.com>
>>> ---
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 2 +-
>>> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 +++++-----
>>> OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 8 ++++----
>>> OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +-
>>> OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 2 +-
>>> OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +-
>>> OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +++---
>>> OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 4 ++--
>>> OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +-
>>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 ++++----
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 ++--
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 2 +-
>>> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 ++--
>>> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +++---
>>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +++---
>>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 ++--
>>> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 ++++----
>>> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 ++--
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++++++-------
>>> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 +++++++++---------
>>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 8 ++++----
>>> 21 files changed, 62 insertions(+), 62 deletions(-)
>>
>> CC'ing David -- David is the designated Reviewer for OvmfPkg/Csm/, based
>> on "Maintainers.txt".
>>
>> Conditional on David's R-b, you can add:
>>
>> Acked-by: Laszlo Ersek <lersek@redhat.com>
>
> Looks sane to me, except there's one line in which you make a
> correction but still leave BIOS spelled in lower case as 'bios'.
> Shouldn't that have capitals?
OK I'll update.
>
> Reviewed-by: David Woodhouse <dwmw2@infradead.org>
Thanks both!
next prev parent reply other threads:[~2019-12-04 14:07 UTC|newest]
Thread overview: 122+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-03 16:14 [PATCH 00/79] Fix a bunch of typos (part 1) Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 01/79] CryptoPkg/OpensslLib: Fix few typos Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 02/79] EmbeddedPkg/FdtLib: Fix a typo Philippe Mathieu-Daudé
2019-12-03 16:58 ` Leif Lindholm
2019-12-03 16:14 ` [PATCH 03/79] EmbeddedPkg/VirtualKeyboard: Fix a typo in EFI_INVALID_PARAMETER Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 04/79] EmbeddedPkg/VirtualKeyboard: Fix few typos Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 05/79] EmulatorPkg/Sec: Fix various typos Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 06/79] EmulatorPkg/Unix: " Philippe Mathieu-Daudé
2019-12-20 6:38 ` Ni, Ray
2019-12-03 16:14 ` [PATCH 07/79] EmulatorPkg/Win: " Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 08/79] FatPkg/EnhancedFatDxe: " Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 09/79] FatPkg/FatPei: Fix few typos Philippe Mathieu-Daudé
2019-12-20 6:37 ` Ni, Ray
2019-12-03 16:14 ` [PATCH 10/79] IntelFsp2WrapperPkg: Fix various typos Philippe Mathieu-Daudé
2019-12-04 1:14 ` [edk2-devel] " Nate DeSimone
2019-12-04 1:22 ` Chiu, Chasel
2019-12-04 1:40 ` [edk2-devel] " Michael D Kinney
2019-12-04 2:30 ` Zeng, Star
2019-12-11 1:53 ` Chiu, Chasel
2019-12-03 16:14 ` [PATCH 11/79] MdeModulePkg/Application: Improve French translation Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 12/79] MdeModulePkg/Application: Fix various typos Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 13/79] MdeModulePkg/Bus/Ata: " Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 14/79] MdeModulePkg/Bus/I2c: Fix few typos Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 15/79] MdeModulePkg/Bus/Isa: Fix various typos Philippe Mathieu-Daudé
2019-12-03 16:14 ` [PATCH 16/79] MdeModulePkg/Bus/Scsi: " Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 17/79] MdeModulePkg/Bus/Sd: " Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 18/79] MdeModulePkg/Core/Pei: " Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 19/79] MdeModulePkg/Core/PiSmmCore: " Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 20/79] MdeModulePkg/UsbBusDxe: Fix a typo Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 21/79] MdeModulePkg/UsbMass: Fix various typos Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 22/79] MdeModulePkg/UsbMouse: Fix few typos Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 23/79] MdeModulePkg/UsbBus: Fix various typos Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 24/79] MdeModulePkg/Usb: " Philippe Mathieu-Daudé
2019-12-03 16:15 ` [PATCH 25/79] MdePkg/IndustryStandard: " Philippe Mathieu-Daudé
2019-12-04 1:35 ` Michael D Kinney
2019-12-03 16:15 ` [PATCH 26/79] MdePkg/Library/Dxe: " Philippe Mathieu-Daudé
2019-12-04 1:24 ` [edk2-devel] " Michael D Kinney
2019-12-03 16:15 ` [PATCH 27/79] MdePkg/Library/Pci: " Philippe Mathieu-Daudé
2019-12-04 1:25 ` [edk2-devel] " Michael D Kinney
2019-12-03 16:15 ` [PATCH 28/79] MdePkg/Library/Smm: " Philippe Mathieu-Daudé
2019-12-04 1:28 ` Michael D Kinney
2019-12-03 16:15 ` [PATCH 29/79] MdePkg/Ppi: " Philippe Mathieu-Daudé
2019-12-04 1:29 ` [edk2-devel] " Michael D Kinney
2019-12-03 16:15 ` [PATCH 30/79] MdePkg/Register: " Philippe Mathieu-Daudé
2019-12-04 1:30 ` [edk2-devel] " Michael D Kinney
2019-12-03 16:15 ` [PATCH 31/79] NetworkPkg: Fix a typo Philippe Mathieu-Daudé
2019-12-03 17:18 ` Leif Lindholm
2019-12-03 17:20 ` Philippe Mathieu-Daudé
2019-12-04 14:02 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 32/79] NetworkPkg/ArpDxe: Fix various typos Philippe Mathieu-Daudé
2019-12-04 13:20 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 33/79] NetworkPkg/Dhcp4Dxe: " Philippe Mathieu-Daudé
2019-12-04 13:25 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 34/79] NetworkPkg/Dhcp6Dxe: " Philippe Mathieu-Daudé
2019-12-04 13:28 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 35/79] NetworkPkg/DnsDxe: Fix a typo Philippe Mathieu-Daudé
2019-12-04 13:35 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 36/79] NetworkPkg/DnsDxe: Fix various typos Philippe Mathieu-Daudé
2019-12-04 13:36 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 37/79] NetworkPkg/DpcDxe: Fix few typos Philippe Mathieu-Daudé
2019-12-04 13:37 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 38/79] NetworkPkg/HttpBootDxe: Fix a typo in variable name Philippe Mathieu-Daudé
2019-12-04 13:52 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:15 ` [PATCH 39/79] NetworkPkg/HttpBootDxe: Fix various typos Philippe Mathieu-Daudé
2019-12-04 13:53 ` [edk2-devel] " Maciej Rabeda
2019-12-03 16:26 ` [PATCH 00/79] Fix a bunch of typos (part 1) Cœur
[not found] ` <20191203161602.15969-62-philmd@redhat.com>
2019-12-03 16:56 ` [PATCH 61/79] OvmfPkg/Xen: Fix various typos Anthony PERARD
2019-12-03 21:06 ` Laszlo Ersek
2019-12-04 3:39 ` Cœur
2019-12-04 16:07 ` [edk2-devel] " Michael D Kinney
2019-12-09 13:06 ` Philippe Mathieu-Daudé
2019-12-09 17:53 ` Michael D Kinney
[not found] ` <20191203161602.15969-76-philmd@redhat.com>
2019-12-03 19:44 ` [PATCH 75/79] StandaloneMmPkg: Fix a typo Yao, Jiewen
[not found] ` <20191203161602.15969-77-philmd@redhat.com>
2019-12-03 19:45 ` [PATCH 76/79] StandaloneMmPkg: Fix few typos Yao, Jiewen
[not found] ` <20191203161602.15969-57-philmd@redhat.com>
2019-12-03 20:48 ` [PATCH 56/79] OvmfPkg/Acpi: " Laszlo Ersek
[not found] ` <20191203161602.15969-58-philmd@redhat.com>
2019-12-03 20:50 ` [PATCH 57/79] OvmfPkg/Csm: Fix various typos Laszlo Ersek
2019-12-03 23:31 ` David Woodhouse
2019-12-04 14:07 ` Philippe Mathieu-Daudé [this message]
[not found] ` <20191203161602.15969-59-philmd@redhat.com>
2019-12-03 21:00 ` [PATCH 58/79] OvmfPkg/Qemu: " Laszlo Ersek
2019-12-09 12:55 ` Philippe Mathieu-Daudé
2019-12-09 13:00 ` Philippe Mathieu-Daudé
2019-12-09 16:12 ` Laszlo Ersek
2019-12-09 15:44 ` Laszlo Ersek
[not found] ` <20191203161602.15969-60-philmd@redhat.com>
2019-12-03 21:00 ` [PATCH 59/79] OvmfPkg/Virtio: Fix few typos Laszlo Ersek
[not found] ` <20191203161602.15969-78-philmd@redhat.com>
2019-12-03 21:03 ` [PATCH 77/79] UefiCpuPkg/CpuDxe: " Laszlo Ersek
2019-12-06 7:24 ` Dong, Eric
[not found] ` <20191203161602.15969-79-philmd@redhat.com>
2019-12-03 21:04 ` [PATCH 78/79] UefiCpuPkg/PiSmm: Fix various typos Laszlo Ersek
2019-12-06 7:24 ` Dong, Eric
[not found] ` <20191203161602.15969-80-philmd@redhat.com>
2019-12-03 21:05 ` [PATCH 79/79] UefiCpuPkg/Smm: " Laszlo Ersek
2019-12-06 7:24 ` Dong, Eric
[not found] ` <20191203161602.15969-61-philmd@redhat.com>
2019-12-03 16:45 ` [PATCH 60/79] OvmfPkg/Xen: Fix a typo Anthony PERARD
2019-12-03 21:05 ` Laszlo Ersek
[not found] ` <20191203161602.15969-73-philmd@redhat.com>
2019-12-04 1:03 ` [PATCH 72/79] SourceLevelDebugPkg/DebugAgent: Fix various typos Wu, Hao A
[not found] ` <20191203161602.15969-74-philmd@redhat.com>
2019-12-04 1:03 ` [PATCH 73/79] SourceLevelDebugPkg/DebugCommunicationLib: " Wu, Hao A
[not found] ` <20191203161602.15969-75-philmd@redhat.com>
2019-12-04 1:03 ` [PATCH 74/79] SourceLevelDebugPkg: Fix few typos Wu, Hao A
2019-12-04 1:16 ` [edk2-devel] [PATCH 00/79] Fix a bunch of typos (part 1) Nate DeSimone
2019-12-04 1:27 ` Liming Gao
2019-12-04 9:09 ` Laszlo Ersek
2019-12-04 14:57 ` Maciej Rabeda
2019-12-04 16:29 ` Philippe Mathieu-Daudé
2019-12-04 16:44 ` Leif Lindholm
2019-12-04 22:15 ` Laszlo Ersek
2019-12-04 22:18 ` Philippe Mathieu-Daudé
[not found] ` <20191203161602.15969-56-philmd@redhat.com>
2019-12-06 16:01 ` [PATCH 55/79] NetworkPkg/VlanConfigDxe: Fix few typos Rabeda, Maciej
[not found] ` <20191203161602.15969-55-philmd@redhat.com>
2019-12-06 16:01 ` [PATCH 54/79] NetworkPkg/UefiPxeBcDxe: Fix various typos Rabeda, Maciej
[not found] ` <20191203161602.15969-52-philmd@redhat.com>
2019-12-06 16:01 ` [PATCH 51/79] NetworkPkg/Tls: Fix few typos Rabeda, Maciej
[not found] ` <20191203161602.15969-51-philmd@redhat.com>
2019-12-06 16:02 ` [PATCH 50/79] NetworkPkg/TcpDxe/Tcp: Fix various typos Rabeda, Maciej
[not found] ` <20191203161602.15969-47-philmd@redhat.com>
2019-12-06 16:02 ` [PATCH 46/79] NetworkPkg/Mtftp4Dxe: " Rabeda, Maciej
[not found] ` <20191203161602.15969-53-philmd@redhat.com>
2019-12-06 16:02 ` [PATCH 52/79] NetworkPkg/Udp4Dxe: " Rabeda, Maciej
[not found] ` <20191203161602.15969-54-philmd@redhat.com>
2019-12-06 16:03 ` [PATCH 53/79] NetworkPkg/Udp6Dxe: " Rabeda, Maciej
[not found] ` <20191203161602.15969-43-philmd@redhat.com>
2019-12-06 16:03 ` [PATCH 42/79] NetworkPkg/Ip6Dxe: " Rabeda, Maciej
[not found] ` <20191203161602.15969-45-philmd@redhat.com>
2019-12-06 16:04 ` [PATCH 44/79] NetworkPkg/Library: " Rabeda, Maciej
[not found] ` <20191203161602.15969-42-philmd@redhat.com>
2019-12-06 16:04 ` [PATCH 41/79] NetworkPkg/Ip4Dxe: " Rabeda, Maciej
[not found] ` <20191203161602.15969-50-philmd@redhat.com>
2019-12-06 16:04 ` [PATCH 49/79] NetworkPkg/TcpDxe/Sock: Fix few typos Rabeda, Maciej
[not found] ` <20191203161602.15969-48-philmd@redhat.com>
2019-12-06 16:05 ` [PATCH 47/79] NetworkPkg/Mtftp6Dxe: Fix various typos Rabeda, Maciej
[not found] ` <20191203161602.15969-46-philmd@redhat.com>
2019-12-06 16:05 ` [PATCH 45/79] NetworkPkg/MnpDxe: " Rabeda, Maciej
[not found] ` <20191203161602.15969-41-philmd@redhat.com>
2019-12-06 16:05 ` [PATCH 40/79] NetworkPkg/HttpDxe: " Rabeda, Maciej
[not found] ` <20191203161602.15969-49-philmd@redhat.com>
2019-12-06 16:09 ` [PATCH 48/79] NetworkPkg/SnpDxe: Fix few typos Rabeda, Maciej
2019-12-06 16:38 ` Philippe Mathieu-Daudé
2019-12-10 7:21 ` [PATCH 00/79] Fix a bunch of typos (part 1) Cœur
[not found] ` <20191203161602.15969-70-philmd@redhat.com>
2019-12-13 2:33 ` [PATCH 69/79] ShellPkg/DynamicCommand: Fix various typos Gao, Zhichao
[not found] ` <20191203161602.15969-69-philmd@redhat.com>
2019-12-13 2:33 ` [PATCH 68/79] ShellPkg/Application: " Gao, Zhichao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c812834a-d277-b77b-63dc-b0ba2b045334@redhat.com \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox