From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-1.mimecast.com (us-smtp-delivery-1.mimecast.com [205.139.110.61]) by mx.groups.io with SMTP id smtpd.web12.4504.1575468449977842331 for ; Wed, 04 Dec 2019 06:07:30 -0800 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=LhSA8Pvh; spf=pass (domain: redhat.com, ip: 205.139.110.61, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1575468449; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=5STa95Bc25OQzqcAfwfGETI+ejjGNww6/t02uRyr+DY=; b=LhSA8Pvh3sNUFEgQ5pqM6MVO11CZTpsxm+iG1Qthxw2491m1vs1aJp/RPRgAfOTyANXpbV J7lLAH8JCK6qrKqhAEeLQxzXY9LsmkbRhAIh7coMPfruV/0yP4aIfNNb+yBp1w3c85Y8q5 7HauUHs9x38gWvoTu75s19rvDzfj5ww= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-112-cSpoDf_LNM2PVzqLuarefA-1; Wed, 04 Dec 2019 09:07:25 -0500 Received: by mail-wr1-f70.google.com with SMTP id u18so3674361wrn.11 for ; Wed, 04 Dec 2019 06:07:25 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=5STa95Bc25OQzqcAfwfGETI+ejjGNww6/t02uRyr+DY=; b=CxHuos0izx5Fma3vaxBehtGYUAcZDzr2YUbj1G+f/FXbnE6NjZfMF3VfQ0Zv4YJh5s x3MV+iuQtmXqlKEK7M3hUGI3wHIy6EdctKAnYmMs3Eyqxdc1USEjZbOSwJMShj5ZYVBQ jg4Ezzhn9lUbiYEkY1tzrkaZ2CyVtxfiOJtsEycvxlal3QQHEmvyjmbVjixNuOLpVc9A WsTWElKrSefmsqRn3AAOgNBORfmdcNJKH163LYMRm5Y+TwE3OS8V42a23kR8LPVjpUEx MUrpMOrAfwj4ECERRbVtvtWLVQi1NET74zkp8Z+ZTJ5vyNSuUJGCTMbc4e+V2awnnS5L Rgqw== X-Gm-Message-State: APjAAAVxVFDy3nCY4I1s3Qu+UbKDhIrQQ4fHIEcoM0QkRocbZ19JNBGz Yfg55jpFolWMOZAK52rM9cdxfGf4UC5nBFHDCIZ59ywevHI0xW+0lhFk6vnVt7aBkyaPPNzKWD7 KGRL+hL32VmyYow== X-Received: by 2002:adf:edd0:: with SMTP id v16mr4211219wro.310.1575468444454; Wed, 04 Dec 2019 06:07:24 -0800 (PST) X-Google-Smtp-Source: APXvYqytTywBjKcX3+S/WbhehFRnzIUccBDgfqJyP8qdWdFyJSx9xHRpi0fJarXuMBCE4XrPCedrIQ== X-Received: by 2002:adf:edd0:: with SMTP id v16mr4211200wro.310.1575468444281; Wed, 04 Dec 2019 06:07:24 -0800 (PST) Return-Path: Received: from [192.168.1.35] (182.red-88-21-103.staticip.rima-tde.net. [88.21.103.182]) by smtp.gmail.com with ESMTPSA id w20sm1297558wmk.34.2019.12.04.06.07.23 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 04 Dec 2019 06:07:23 -0800 (PST) Subject: Re: [edk2-devel] [PATCH 57/79] OvmfPkg/Csm: Fix various typos To: devel@edk2.groups.io, dwmw2@infradead.org, Laszlo Ersek Cc: Antoine Coeur , Jordan Justen , Ard Biesheuvel References: <20191203161602.15969-1-philmd@redhat.com> <20191203161602.15969-58-philmd@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Wed, 4 Dec 2019 15:07:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: X-MC-Unique: cSpoDf_LNM2PVzqLuarefA-1 X-Mimecast-Spam-Score: 0 Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit On 12/4/19 12:31 AM, David Woodhouse wrote: > On Tue, 2019-12-03 at 21:50 +0100, Laszlo Ersek wrote: >> On 12/03/19 17:15, Philippe Mathieu-Daude wrote: >>> From: Antoine Coeur >>> >>> Fix various typos in documentation, comments and strings. >>> >>> Cc: Jordan Justen >>> Cc: Laszlo Ersek >>> Cc: Ard Biesheuvel >>> Reviewed-by: Philippe Mathieu-Daude >>> Signed-off-by: Philippe Mathieu-Daude >>> --- >>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.inf | 2 +- >>> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.h | 10 +++++----- >>> OvmfPkg/Csm/BiosThunk/VideoDxe/VesaBiosExtensions.h | 8 ++++---- >>> OvmfPkg/Csm/Include/Framework/BootScript.h | 2 +- >>> OvmfPkg/Csm/Include/Framework/FrameworkInternalFormRepresentation.h | 2 +- >>> OvmfPkg/Csm/Include/Protocol/IsaIo.h | 2 +- >>> OvmfPkg/Csm/Include/Protocol/LegacyBios.h | 6 +++--- >>> OvmfPkg/Csm/Include/Protocol/LegacyBiosPlatform.h | 4 ++-- >>> OvmfPkg/Csm/Include/Protocol/VgaMiniPort.h | 2 +- >>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBiosInterface.h | 8 ++++---- >>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.h | 4 ++-- >>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiVfr.h | 2 +- >>> OvmfPkg/Csm/BiosThunk/VideoDxe/BiosVideo.c | 4 ++-- >>> OvmfPkg/Csm/CsmSupportLib/LegacyPlatform.c | 6 +++--- >>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBios.c | 6 +++--- >>> OvmfPkg/Csm/LegacyBiosDxe/LegacyBootSupport.c | 4 ++-- >>> OvmfPkg/Csm/LegacyBiosDxe/LegacyPci.c | 8 ++++---- >>> OvmfPkg/Csm/LegacyBiosDxe/Thunk.c | 4 ++-- >>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUi.c | 14 +++++++------- >>> OvmfPkg/Csm/LegacyBootManagerLib/LegacyBm.c | 18 +++++++++--------- >>> OvmfPkg/Csm/LegacyBootMaintUiLib/LegacyBootMaintUiLib.uni | 8 ++++---- >>> 21 files changed, 62 insertions(+), 62 deletions(-) >> >> CC'ing David -- David is the designated Reviewer for OvmfPkg/Csm/, based >> on "Maintainers.txt". >> >> Conditional on David's R-b, you can add: >> >> Acked-by: Laszlo Ersek > > Looks sane to me, except there's one line in which you make a > correction but still leave BIOS spelled in lower case as 'bios'. > Shouldn't that have capitals? OK I'll update. > > Reviewed-by: David Woodhouse Thanks both!