From: "Pete Batard" <pete@akeo.ie>
To: GH Cao <driver1998@foxmail.com>, devel@edk2.groups.io
Cc: ard.biesheuvel@arm.com, leif@nuviainc.com
Subject: Re: [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h
Date: Tue, 28 Apr 2020 10:46:36 +0100 [thread overview]
Message-ID: <c83f3ca0-b0f1-57fd-8381-ad2acddf4c47@akeo.ie> (raw)
In-Reply-To: <20200428050840.223-1-driver1998@foxmail.com>
On 2020.04.28 06:08, GH Cao wrote:
> The original comment incorrectly named the PWM controller as Power Management
> Contoller, this commit fixes it.
>
> Signed-off-by: GH Cao <driver1998@foxmail.com>
> ---
> Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> index e2581b8..2d7da75 100644
> --- a/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> +++ b/Silicon/Broadcom/Bcm283x/Include/IndustryStandard/Bcm2836Pwm.h
> @@ -11,7 +11,7 @@
> #ifndef __BCM2836_PWM_H__
> #define __BCM2836_PWM_H__
>
> -/* Power Management constants */
> +/* PWM controller constants */
>
> #define BCM2836_PWM_DMA_OFFSET 0x00007B00
> #define BCM2836_PWM_DMA_BASE_ADDRESS (BCM2836_SOC_REGISTERS + BCM2836_PWM_DMA_OFFSET)
>
Reviewed-by: Pete Batard <pete@akeo.ie>
next prev parent reply other threads:[~2020-04-28 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-28 5:08 [edk2-platforms][PATCH] Platform/RaspberryPi: Fix comments in Bcm2836Pwm.h driver1998
2020-04-28 9:46 ` Pete Batard [this message]
2020-04-28 11:25 ` [edk2-devel] " Philippe Mathieu-Daudé
2020-04-30 7:42 ` Ard Biesheuvel
-- strict thread matches above, loose matches on Subject: below --
2020-04-28 1:21 GH Cao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-list from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=c83f3ca0-b0f1-57fd-8381-ad2acddf4c47@akeo.ie \
--to=devel@edk2.groups.io \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox