From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by mx.groups.io with SMTP id smtpd.web09.47226.1624282966250761840 for ; Mon, 21 Jun 2021 06:42:46 -0700 Authentication-Results: mx.groups.io; dkim=missing; spf=pass (domain: arm.com, ip: 217.140.110.172, mailfrom: alexandru.elisei@arm.com) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id DA77AD6E; Mon, 21 Jun 2021 06:42:44 -0700 (PDT) Received: from [192.168.0.110] (unknown [172.31.20.19]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 0C1C93F694; Mon, 21 Jun 2021 06:42:43 -0700 (PDT) Subject: Re: [edk2-devel] [PATCH RESEND v1 0/2] ArmVirtPkg: Enable PCIe support for Kvmtool To: devel@edk2.groups.io, pierre.gondois@arm.com, Laszlo Ersek , Ard Biesheuvel , Sami Mujawar Cc: Leif Lindholm References: <20210615152128.25565-1-Pierre.Gondois@arm.com> From: alexandru.elisei@arm.com Message-ID: Date: Mon, 21 Jun 2021 14:43:39 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210615152128.25565-1-Pierre.Gondois@arm.com> Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Content-Language: en-US Hi Pierre, On 6/15/21 4:21 PM, PierreGondois via groups.io wrote: > From: Pierre Gondois > > PCIe support has been added to the Kvmtool virtual machine > manager. Therefore, add a PciHostBridgeUtilityLib and enable > PCIe support for Kvmtool firmware. > > The patches were re-send as the devel@edk2.groups.io was not included. > > The patches can be seen at: https://github.com/PierreARM/edk2/tree/1413_Enable_ArmVirt_Pci_v1 > The results of the CI can be seen at: https://github.com/tianocore/edk2/pull/1718 Tested the patches with the latest version of the kvmtool PCI Express support [1], and everything worked as expected. A summary of the tests that I ran can be found at [1]. So you can add for the entire series: Tested-by: Alexandru Elisei One thing of note is that applying patch #2 of this series on top of 11b1c1d4b98b ("SecurityPkg: TcgStorageOpalLib: Initialize SupportedAttributes parameter") failed. However, building from your repo went fine, and the binary that I used for testing was built from your repo. [1] https://lore.kernel.org/kvm/20210621092128.11313-1-alexandru.elisei@arm.com/ Thanks, Alex > > Sami Mujawar (2): > ArmVirtPkg: Add PCIe host bridge utility lib for ArmVirtPkg > ArmVirtPkg: Enable PCIe support for Kvmtool > > ArmVirtPkg/ArmVirtKvmTool.dsc | 35 ++- > ArmVirtPkg/ArmVirtKvmTool.fdf | 11 +- > .../ArmVirtPciHostBridgeUtilityLib.c | 219 ++++++++++++++++++ > .../ArmVirtPciHostBridgeUtilityLib.inf | 39 ++++ > 4 files changed, 301 insertions(+), 3 deletions(-) > create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.c > create mode 100644 ArmVirtPkg/Library/ArmVirtPciHostBridgeUtilityLib/ArmVirtPciHostBridgeUtilityLib.inf >