From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by mx.groups.io with SMTP id smtpd.web11.4092.1622104380205346593 for ; Thu, 27 May 2021 01:33:00 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=G/HgWLD7; spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: philmd@redhat.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1622104379; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=d5+JallNOzri8rAm1BNasQcGRN5/joFOajOSklJrEns=; b=G/HgWLD7nydQn9nVt3mnkPt9PoJNtRAYDJHQbHl6daSpNdV4TJS+cLuSBXhdQ4GTlwCbmV gcD/iDAv01WkHpWTqGH3kjpdvAuD4bJ+NzGWQ5EDK3rL/HeoVxd0LTXOwiuWSGjYyLJcpY VVU/2ZBwlg1y0KF/Ekf5HBW+CI68nv4= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-445-JUFxlG1yPuepbYUA1oUc9g-1; Thu, 27 May 2021 04:32:57 -0400 X-MC-Unique: JUFxlG1yPuepbYUA1oUc9g-1 Received: by mail-wm1-f71.google.com with SMTP id j6-20020a1c3c060000b029017f262ba319so1675359wma.3 for ; Thu, 27 May 2021 01:32:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=d5+JallNOzri8rAm1BNasQcGRN5/joFOajOSklJrEns=; b=n/YtSWo1L0IhHfQY3GlnIAOiBZtd6Wje4PIuEsQxO5Ty9WQUjg1GVCS6y4RjypKk5+ KazsJ3hGqOF8M/SHBPMx8FJm4XlBmyEHEseDK0g/fx5CvwdkhVve0FxijPhs+7UAXV5y WQ/KaF2kfrRWc3UwvQ9Z5Bm9pBXZEt6DY+xxvk7b12drPdOCDdoP9ga15WPkQVjRYkxq TxLn2GlD1N4Nq67+dzn0p8HdO4Vnzto1xdQXT5rpDkNHUvKqqKKzknRb6XTaV/7ATGo8 Q7hCKRR30/5wkLWPhimspoQaOFut1hecE7bqztkTPXrTooal0aDkiclfINWuLfDnxic8 ZyHQ== X-Gm-Message-State: AOAM530ZfjxqSqABHhT+2fo5pU2+xIa0coL6DXbVqn+PsLvKD0nC8T7a 9UISkPBTb+6+a6dwhN4XTjuIEG6fP05zPYqwjLbgjbg8VE0Z8PEXKfCFLd6p5H3G0+Und6fT8pZ kUWmrXicmJw/T4Q== X-Received: by 2002:a05:600c:219:: with SMTP id 25mr7121784wmi.156.1622104376279; Thu, 27 May 2021 01:32:56 -0700 (PDT) X-Google-Smtp-Source: ABdhPJx6IILDNrm6cc7/lxjB7wQCXK7RVN0rf3ldLOIxoGjRAMM4M2AlQYAN5QOPWQGdmTT2umcGQw== X-Received: by 2002:a05:600c:219:: with SMTP id 25mr7121760wmi.156.1622104376031; Thu, 27 May 2021 01:32:56 -0700 (PDT) Return-Path: Received: from [192.168.1.36] (235.red-83-57-168.dynamicip.rima-tde.net. [83.57.168.235]) by smtp.gmail.com with ESMTPSA id x206sm2004030wmx.47.2021.05.27.01.32.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 27 May 2021 01:32:55 -0700 (PDT) Subject: Re: [PATCH 32/43] OvmfPkg/PciHostBridgeLib: remove Bhyve and Xen support To: Laszlo Ersek , devel@edk2.groups.io Cc: Andrew Fish , Ard Biesheuvel , Jordan Justen , Leif Lindholm , Michael D Kinney References: <20210526201446.12554-1-lersek@redhat.com> <20210526201446.12554-33-lersek@redhat.com> From: =?UTF-8?B?UGhpbGlwcGUgTWF0aGlldS1EYXVkw6k=?= Message-ID: Date: Thu, 27 May 2021 10:32:54 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: <20210526201446.12554-33-lersek@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=philmd@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit On 5/26/21 10:14 PM, Laszlo Ersek wrote: > The "OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf" instance is > used by the following platforms in edk2: > > OvmfPkg/AmdSev/AmdSevX64.dsc > OvmfPkg/OvmfPkgIa32.dsc > OvmfPkg/OvmfPkgIa32X64.dsc > OvmfPkg/OvmfPkgX64.dsc > > All these platforms statically inherit PcdPciDisableBusEnumeration=FALSE > from "MdeModulePkg.dec". Remove the the PCD and everything that depends on > it from the PciHostBridgeLib instance. Namely, remove the logic that > determines the root bridge apertures by (a) scanning the entire bus, > device and function number space, and (b) parsing the BAR values that were > pre-set by the Bhyve or Xen machinery. > > "XenSupport.c" used to be listed explicitly in "Maintainers.txt", remove > it from that spot too. > > Cc: Andrew Fish > Cc: Ard Biesheuvel > Cc: Jordan Justen > Cc: Leif Lindholm > Cc: Michael D Kinney > Cc: Philippe Mathieu-Daudé > Ref: https://bugzilla.tianocore.org/show_bug.cgi?id=2122 > Signed-off-by: Laszlo Ersek > --- > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.inf | 7 - > Maintainers.txt | 1 - > OvmfPkg/Library/PciHostBridgeLib/PciHostBridge.h | 13 - > OvmfPkg/Library/PciHostBridgeLib/PciHostBridgeLib.c | 6 - > OvmfPkg/Library/PciHostBridgeLib/XenSupport.c | 471 -------------------- > 5 files changed, 498 deletions(-) Reviewed-by: Philippe Mathieu-Daude