From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from out5-smtp.messagingengine.com (out5-smtp.messagingengine.com [66.111.4.29]) by mx.groups.io with SMTP id smtpd.web10.1631.1678816758128078222 for ; Tue, 14 Mar 2023 10:59:18 -0700 Authentication-Results: mx.groups.io; dkim=fail reason="signature has expired" header.i=@bsdio.com header.s=fm3 header.b=HZV4N67K; spf=pass (domain: bsdio.com, ip: 66.111.4.29, mailfrom: rebecca@bsdio.com) Received: from compute5.internal (compute5.nyi.internal [10.202.2.45]) by mailout.nyi.internal (Postfix) with ESMTP id 691F55C09A7; Tue, 14 Mar 2023 13:59:17 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute5.internal (MEProxy); Tue, 14 Mar 2023 13:59:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bsdio.com; h=cc :cc:content-transfer-encoding:content-type:content-type:date :date:from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to; s=fm3; t= 1678816757; x=1678903157; bh=H5YxXgU4IYxSfQ5ytNQeXXJ5VbPrqohntq2 N3W0Gp9U=; b=HZV4N67KvFHT7kZdTcDWq6lp4pjPt9yQLzKzyqNq2L8Bf+MRun6 5tD1dBmZ0SLBpj8T9PA0D0LWGegy9Dl09URQGbXdltEpFBqtyviBHwhGlYjF+vt2 prN/CtNellgTyIIfIckkaSa6up/mnM0Itog+MwC7K+NPXu93ZPGnoN7sQtw4JPxp cfSyk6qf+ag7l0lHKpjC3KjiW/qEO0oO58sFJB8vVvwC+xcRypHfy/N8v9v2+GPl Wl404mKcHJ4hFFPAPSUI6YmhWz/EFtibcJL07GcrORwMJB1T3HtMnOJnjd9iN32/ 58t/zKT0AGEBQi6F1XzFI2Ueg6J+ZUrar5g== DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:cc:content-transfer-encoding :content-type:content-type:date:date:feedback-id:feedback-id :from:from:in-reply-to:in-reply-to:message-id:mime-version :references:reply-to:sender:subject:subject:to:to:x-me-proxy :x-me-proxy:x-me-sender:x-me-sender:x-sasl-enc; s=fm2; t= 1678816757; x=1678903157; bh=H5YxXgU4IYxSfQ5ytNQeXXJ5VbPrqohntq2 N3W0Gp9U=; b=YAg4DAAjKpB7FpWgvc2BEHSWP8C+wPiMUDSUqxVh9C352gMvmqy LE/Q0K3fVuG3bRuv7mJdAzV+TvRRftBYneCCiFNR9us5MsTknMai0rctCEUjP9eT kY76pL8d9VW2eAONl6msYLtaogH8fo/4CJ3NDIJ6R+/DtPB6gjTtv64GgE/YKPk/ +kuI9T7hXzmD10pH8NMMKzVu7qkL1VBtVsS+C0OpdpzLh1S8woA7CNPGltfFaUPr 9WKBkmKx7VYsox7Atl6tjFansVzRx6L/TtX+mBgt+Rd0vFtMkb7W+O6iTv1BkTPT uusESI6YZ+5tZvE6xUfccnJvfUlKjOQNswg== X-ME-Sender: X-ME-Received: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgedvhedrvddviedguddutdcutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecunecujfgurhepkfffgggfhffuvfevfhgjtgfgse htjeertddtfeejnecuhfhrohhmpeftvggsvggttggrucevrhgrnhcuoehrvggsvggttggr segsshguihhordgtohhmqeenucggtffrrghtthgvrhhnpeeggefgtefgteekvdeigfduud eluefhgfeiteduvdetgeetteevgeelveduffejgeenucevlhhushhtvghrufhiiigvpedt necurfgrrhgrmhepmhgrihhlfhhrohhmpehrvggsvggttggrsegsshguihhordgtohhm X-ME-Proxy: Feedback-ID: i5b994698:Fastmail Received: by mail.messagingengine.com (Postfix) with ESMTPA; Tue, 14 Mar 2023 13:59:16 -0400 (EDT) Message-ID: Date: Tue, 14 Mar 2023 11:59:15 -0600 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.8.0 From: "Rebecca Cran" Subject: Re: [edk2-devel] [PATCH 1/1] ArmPkg/SmbiosMiscDxe: Adjust the priority of getting firmware version To: Leif Lindholm , devel@edk2.groups.io, tinhnguyen@os.amperecomputing.com Cc: patches@amperecomputing.com, ardb+tianocore@kernel.org, Nhi Pham References: <20230313064321.170866-1-tinhnguyen@os.amperecomputing.com> <0e962fce-d8d2-9622-94af-5f32e5a51ca4@amperemail.onmicrosoft.com> In-Reply-To: Content-Language: en-US Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 3/14/23 6:48 AM, Leif Lindholm wrote: > No objection to that. > But can we do it like this?: > > Change GetBiosVersion to SetBiosVersion and in MiscBiosVendor, only call > > SetBiosVersion (); > > and move the selection logic fully into SetBiosVersion? > > Rebecca, thoughts? > Arguably, once an OemMiscLib dependency was added, the Pcd values became > less useful in the core code. That sounds very reasonable. -- Rebecca Cran