From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 9A78980402 for ; Thu, 23 Mar 2017 11:37:12 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.11]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 002B0624CD; Thu, 23 Mar 2017 18:37:12 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 002B0624CD Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx10.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=lersek@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 002B0624CD Received: from lacos-laptop-7.usersys.redhat.com (ovpn-116-84.phx2.redhat.com [10.3.116.84]) by smtp.corp.redhat.com (Postfix) with ESMTP id E0F2B1917C; Thu, 23 Mar 2017 18:37:10 +0000 (UTC) To: Qin Long , edk2-devel@lists.01.org References: <20170323131932.6168-1-qin.long@intel.com> <20170323131932.6168-10-qin.long@intel.com> Cc: ting.ye@intel.com, jiaxin.wu@intel.com, ard.biesheuvel@linaro.org, glin@suse.com, ronald.cron@arm.com, Moso.Lee@citrix.com, thomas.palmer@hpe.com From: Laszlo Ersek Message-ID: Date: Thu, 23 Mar 2017 19:37:08 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <20170323131932.6168-10-qin.long@intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.11 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.39]); Thu, 23 Mar 2017 18:37:13 +0000 (UTC) Subject: Re: [PATCH v2 09/11] CryptoPkg: Update HMAC Wrapper with opaque HMAC_CTX object. X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Mar 2017 18:37:12 -0000 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit On 03/23/17 14:19, Qin Long wrote: > OpenSSL-1.1.xx makes most data structures opaque. > This patch updated HMAC Wrapper implementation with opaque > HMAC_CTX object. > The HmacXXGetContextSize() is marked as deprecated, and updated > to use the fixed HMAC_CTX size, which is just kept for compatibility. > New APIs (HmacXXNew(), HmacXXFree()) were added as the recommended > HMAC_CTX usage interfaces for HMAC-XXXX operations. > > Cc: Ting Ye > Cc: Laszlo Ersek > Cc: Ard Biesheuvel > Cc: Gary Lin > Cc: Ronald Cron > Contributed-under: TianoCore Contribution Agreement 1.0 > Signed-off-by: Qin Long > --- > CryptoPkg/Include/Library/BaseCryptLib.h | 93 +++++++++++++++++++++- > CryptoPkg/Library/BaseCryptLib/Hmac/CryptHmacMd5.c | 77 +++++++++++++++--- > .../Library/BaseCryptLib/Hmac/CryptHmacMd5Null.c | 40 +++++++++- > .../Library/BaseCryptLib/Hmac/CryptHmacSha1.c | 75 +++++++++++++++-- > .../Library/BaseCryptLib/Hmac/CryptHmacSha1Null.c | 40 +++++++++- > .../Library/BaseCryptLib/Hmac/CryptHmacSha256.c | 75 +++++++++++++++-- > .../BaseCryptLib/Hmac/CryptHmacSha256Null.c | 40 +++++++++- > 7 files changed, 411 insertions(+), 29 deletions(-) I think the code modified in this patch is exercised as part of Secure Boot image verification (SHA1, SHA256), so: Tested-by: Laszlo Ersek (Tested as described in .) Thanks! Laszlo