From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124])
 by mx.groups.io with SMTP id smtpd.web09.17502.1611688202385412169
 for <devel@edk2.groups.io>;
 Tue, 26 Jan 2021 11:10:02 -0800
Authentication-Results: mx.groups.io;
 dkim=pass header.i=@redhat.com header.s=mimecast20190719 header.b=eZq1japu;
 spf=pass (domain: redhat.com, ip: 216.205.24.124, mailfrom: lersek@redhat.com)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com;
	s=mimecast20190719; t=1611688201;
	h=from:from:reply-to:subject:subject:date:date:message-id:message-id:
	 to:to:cc:cc:mime-version:mime-version:content-type:content-type:
	 content-transfer-encoding:content-transfer-encoding:
	 in-reply-to:in-reply-to:references:references;
	bh=1toxc4cJO9O6oQ9neEn8scFzV4iSaBrgeGdIcbOM5RY=;
	b=eZq1japuxeeBAf75omrpv6bfVYHmQuzXCgVIBMpQXiRLGXYvx8APjbSJH9bc9/6k9/fZNU
	2+IiOj4rii2tWQSN7yNVO1rMWN7xeUsH1xTsiw8GSfgas+e1UFXfYvPBvE6kB88dCKWvnf
	oJrJMDzJEakmVBVrcV75xTQKRi2nmpo=
Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com
 [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id
 us-mta-387-vmrIVipeMBC6G7XsQTQA2Q-1; Tue, 26 Jan 2021 14:09:57 -0500
X-MC-Unique: vmrIVipeMBC6G7XsQTQA2Q-1
Received: from smtp.corp.redhat.com (int-mx03.intmail.prod.int.phx2.redhat.com [10.5.11.13])
	(using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
	(No client certificate requested)
	by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 113CA8030A0;
	Tue, 26 Jan 2021 19:09:56 +0000 (UTC)
Received: from lacos-laptop-7.usersys.redhat.com (ovpn-112-219.ams2.redhat.com [10.36.112.219])
	by smtp.corp.redhat.com (Postfix) with ESMTP id 36AB36F991;
	Tue, 26 Jan 2021 19:09:54 +0000 (UTC)
Subject: Re: [PATCH v5 1/9] OvmfPkg/CpuHotplugSmm: refactor hotplug logic
From: "Laszlo Ersek" <lersek@redhat.com>
To: Ankur Arora <ankur.a.arora@oracle.com>, devel@edk2.groups.io
Cc: imammedo@redhat.com, boris.ostrovsky@oracle.com,
 Jordan Justen <jordan.l.justen@intel.com>,
 Ard Biesheuvel <ard.biesheuvel@arm.com>, Aaron Young <aaron.young@oracle.com>
References: <20210126064440.299596-1-ankur.a.arora@oracle.com>
 <20210126064440.299596-2-ankur.a.arora@oracle.com>
 <3f3fd01d-78a9-315c-85e3-b5788b8d6489@redhat.com>
Message-ID: <c8ef2521-f8d6-8250-c728-a367d841f368@redhat.com>
Date: Tue, 26 Jan 2021 20:09:53 +0100
MIME-Version: 1.0
In-Reply-To: <3f3fd01d-78a9-315c-85e3-b5788b8d6489@redhat.com>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.13
Authentication-Results: relay.mimecast.com;
	auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=lersek@redhat.com
X-Mimecast-Spam-Score: 0
X-Mimecast-Originator: redhat.com
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit

On 01/26/21 20:01, Laszlo Ersek wrote:
> On 01/26/21 07:44, Ankur Arora wrote:

>> +  if (EFI_ERROR(Status)) {
>> +    goto Fatal;
>>    }
> 
> (13) Without having seen the rest of the patches, I think this error
> check should be nested under the same (PluggedCount > 0) condition; in
> other words, I think it only makes sense to check Status after we
> actually call ProcessHotAddedCpus().

(14) Missing space after "EFI_ERROR".

(I'll not point out further instances of this issue; please review all
the patches with regard to it.)

Thanks
Laszlo