From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-io1-f43.google.com (mail-io1-f43.google.com [209.85.166.43]) by mx.groups.io with SMTP id smtpd.web09.6021.1604015385070210392 for ; Thu, 29 Oct 2020 16:49:45 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@nuviainc-com.20150623.gappssmtp.com header.s=20150623 header.b=ye1UNYG7; spf=pass (domain: nuviainc.com, ip: 209.85.166.43, mailfrom: rebecca@nuviainc.com) Received: by mail-io1-f43.google.com with SMTP id b15so5622530iod.13 for ; Thu, 29 Oct 2020 16:49:45 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nuviainc-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-transfer-encoding:content-language; bh=pmMdatl6smARhUXh6tocjXvneg6BNbcKNsmRG0TDa2E=; b=ye1UNYG7Ndf77fEruJowzD7SJWvVfJ6TjEpy50ZVwD2phRpvySRIIjrijerS6yCSlB kPm2XSZJSqr5+rhnN+9l+2wvSn3OukSmPWXXwpbBWjNfF92A4aPB7JNfNqMBRnuFGntt WH3sRcKZPRE6flKVnNf5mdP8EZK3R3bAJzXXP10iRHi0zIpWk7id9UWlD2XjGRHrPxsu iAKg5D5gpM5DfhEs5q1aGRXaMSeMg/KHKx9Z7POtABnGrXkirU9tV3XAqunvbJ2f4mc5 xlapj+RiNIQQl+nDOz1gNQjg79VeH7nZHZx3sgIno3kPbkD9mJDKsiq85sr093Q+u59I BanQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=pmMdatl6smARhUXh6tocjXvneg6BNbcKNsmRG0TDa2E=; b=KychIGQTLg3We3VU93TJen0XCqQWE0uPJGJ2g05d0f1E9v5kTT7QQj7mLwMvafHd3i +HBljfQcv8DlLp3sTN3YDT5OunZBXkDcXObrBwuYGbrtc6iAFrNbO+ZxJc2VR8DXmiT6 jJhvmGxR3w2XGK5pw4S7vFTdlvBFyZPzIspsvWdRGZrOVZiOiUA1qQBcLpO4P3EDVjvu iGnJEI4gy3RaE4GgRZpoe/VsH40rPigYVJ2ofUQiOu+HIhk+cFW1bmrjuGnYXMeE2TfY UjDhzjeD0x+SlCpQMDJE1f21H9VZzcFbCFnnPO3WaYt6Td/2K0ikPNb8u/1BOyd2dLhw GspA== X-Gm-Message-State: AOAM530b9LnFpH2W1PCFunIoddAZpFu2NgiE+JT3Z4SKf7bHNoimwjVd Gpdd4jUm0pTrYdSjXRPn+bxsvw== X-Google-Smtp-Source: ABdhPJzQWu1HwHOLWTcdvTsaH1GrGAKnRf349tTVw2/uPzqMbVQ/SoTWgzndb2fayrewrzMN7MGDhA== X-Received: by 2002:a02:a1dc:: with SMTP id o28mr5676593jah.109.1604015384475; Thu, 29 Oct 2020 16:49:44 -0700 (PDT) Return-Path: Received: from [10.0.10.142] (muon.bluestop.org. [65.103.231.193]) by smtp.gmail.com with ESMTPSA id p17sm3399957ilh.34.2020.10.29.16.49.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Oct 2020 16:49:43 -0700 (PDT) Subject: Re: [edk2-devel] [Redfish Discover Header File PATCH] RedfishPkg/Include: EFI Redfish Discover Protocol header file To: "Chang, Abner (HPS SW/FW Technologist)" , "devel@edk2.groups.io" Cc: Jiaxin Wu , Siyuan Fu , Fan Wang , Jiewen Yao , "Wang, Nickle (HPS SW)" References: <20201013043343.21356-1-abner.chang@hpe.com> <85cf61cb-fb5b-32fe-3da8-d87c60762bcc@nuviainc.com> From: "Rebecca Cran" Message-ID: Date: Thu, 29 Oct 2020 17:49:26 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sorry, you're right - and it was pointed out to me that the leading underscore is reserved in C anyway. -- Rebecca Cran On 10/29/20 5:38 PM, Chang, Abner (HPS SW/FW Technologist) wrote: > Hi Rebecca, > We don’t need the leading underscore for the macro as it mentioned in the edk2 C coding standard (section 3.3.2). > > Thanks for reviewing this. > Abner > >> -----Original Message----- >> From: devel@edk2.groups.io [mailto:devel@edk2.groups.io] On Behalf Of >> Rebecca Cran >> Sent: Friday, October 30, 2020 5:42 AM >> To: devel@edk2.groups.io; Chang, Abner (HPS SW/FW Technologist) >> >> Cc: Jiaxin Wu ; Siyuan Fu ; Fan >> Wang ; Jiewen Yao ; Wang, >> Nickle (HPS SW) >> Subject: Re: [EXTERNAL] [edk2-devel] [Redfish Discover Header File PATCH] >> RedfishPkg/Include: EFI Redfish Discover Protocol header file >> >> I think the header include guard should have a leading underscore - e.g. >> _EFI_REDFISH_DISCOVER_PROTOCOL_H_. >> >> And it's nice if there's a comment on the #endif to say what it's for. >> >> >> -- >> Rebecca Cran >> >> >> On 10/12/20 10:33 PM, Abner Chang wrote: >>> diff --git a/RedfishPkg/Include/Protocol/RedfishDiscover.h >> b/RedfishPkg/Include/Protocol/RedfishDiscover.h >>> new file mode 100644 >>> index 0000000000..574d7a16a6 >>> --- /dev/null >>> +++ b/RedfishPkg/Include/Protocol/RedfishDiscover.h >>> @@ -0,0 +1,198 @@ >>> +/** @file >>> + This file defines the EFI Redfish Discover Protocol interface. >>> + >>> + (C) Copyright 2020 Hewlett Packard Enterprise Development LP
>>> + >>> + SPDX-License-Identifier: BSD-2-Clause-Patent >>> + >>> +**/ >>> + >>> +#ifndef EFI_REDFISH_DISCOVER_PROTOCOL_H_ >>> +#define EFI_REDFISH_DISCOVER_PROTOCOL_H_ >>> + >>> >> >> >>