From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received-SPF: Pass (sender SPF authorized) identity=mailfrom; client-ip=209.132.183.28; helo=mx1.redhat.com; envelope-from=lersek@redhat.com; receiver=edk2-devel@lists.01.org Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ml01.01.org (Postfix) with ESMTPS id 2975C2116DA2B for ; Wed, 17 Oct 2018 10:16:56 -0700 (PDT) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 3E1CE30832C2; Wed, 17 Oct 2018 17:16:56 +0000 (UTC) Received: from lacos-laptop-7.usersys.redhat.com (ovpn-120-50.rdu2.redhat.com [10.10.120.50]) by smtp.corp.redhat.com (Postfix) with ESMTP id 8466E777FE; Wed, 17 Oct 2018 17:16:52 +0000 (UTC) To: "Gao, Liming" , "Kinney, Michael D" Cc: edk2-devel-01 , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= References: <20180929222312.32150-1-lersek@redhat.com> <89c5af5b-a4a9-1e54-d982-f99feb7d449f@redhat.com> <9bac7fc8-532e-0b40-a11d-01a4092b731d@redhat.com> <4A89E2EF3DFEDB4C8BFDE51014F606A14E33A7CB@SHSMSX104.ccr.corp.intel.com> From: Laszlo Ersek Message-ID: Date: Wed, 17 Oct 2018 19:16:51 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <4A89E2EF3DFEDB4C8BFDE51014F606A14E33A7CB@SHSMSX104.ccr.corp.intel.com> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.44]); Wed, 17 Oct 2018 17:16:56 +0000 (UTC) Subject: Re: [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, cleanups X-BeenThere: edk2-devel@lists.01.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: EDK II Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 17 Oct 2018 17:16:57 -0000 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit On 10/16/18 03:32, Gao, Liming wrote: > Laszlo: > Sorry for the delay. Your change is good. > > Reviewed-by: Liming Gao > > Thanks > Liming >> -----Original Message----- >> From: Kinney, Michael D >> Sent: Tuesday, October 16, 2018 3:29 AM >> To: Laszlo Ersek ; Gao, Liming ; >> Kinney, Michael D >> Cc: edk2-devel-01 >> Subject: RE: [edk2] [PATCH 0/5] MdePkg/BaseSynchronizationLib GCC: fixes, >> cleanups >> >> Laszlo, >> >> Thanks for the reminder. My knowledge of inline >> GCC assembly syntax is very limited, so I am not >> able to review this patch for correctness. I can >> ack it. >> >> Acked-by: Michael D Kinney >> >> Perhaps Liming can do a more complete review. Thank you both. This is a very busy time for the edk2 project & community; it's expected that reviews take longer. I didn't intend my pings as urging you, just as friendly reminders, once per week :) Series pushed as commit range b7dc8888f314..3a0329bed2a2. Thanks! Laszlo >>> -----Original Message----- >>> From: edk2-devel [mailto:edk2-devel- >>> bounces@lists.01.org] On Behalf Of Laszlo Ersek >>> Sent: Monday, October 15, 2018 11:05 AM >>> To: Kinney, Michael D ; Gao, >>> Liming >>> Cc: edk2-devel-01 >>> Subject: Re: [edk2] [PATCH 0/5] >>> MdePkg/BaseSynchronizationLib GCC: fixes, cleanups >>> >>> On 10/08/18 15:44, Laszlo Ersek wrote: >>>> On 09/30/18 00:23, Laszlo Ersek wrote: >>>>> Repo: https://github.com/lersek/edk2.git >>>>> Branch: inline_asm_rw_ops_1208 >>>>> >>>>> This series mainly fixes the operand constraints >>> (missing input-output >>>>> qualifications) in >>> "BaseSynchronizationLib/*/GccInline.c". >>>>> >>>>> (It would be better to remove these files altogether >>> in favor of the >>>>> already existing NASM implementation, but due to >>>>> , >>> we can't generally >>>>> do that in libraries yet.) >>>>> >>>>> Cc: Liming Gao >>>>> Cc: Michael D Kinney >>>>> >>>>> Thanks, >>>>> Laszlo >>>>> >>>>> Laszlo Ersek (5): >>>>> MdePkg/BaseSynchronizationLib GCC: fix whitespace >>> and comments >>>>> MdePkg/BaseSynchronizationLib GCC: fix >>> InternalSyncCompareExchange16() >>>>> MdePkg/BaseSynchronizationLib GCC: fix >>> InternalSyncCompareExchange32() >>>>> MdePkg/BaseSynchronizationLib GCC: fix X64 >>>>> InternalSyncCompareExchange64() >>>>> MdePkg/BaseSynchronizationLib GCC: simplify IA32 >>>>> InternalSyncCompareExchange64() >>>>> >>>>> >>> MdePkg/Library/BaseSynchronizationLib/Ia32/GccInline.c | >>> 42 +++++++---------- >>>>> >>> MdePkg/Library/BaseSynchronizationLib/X64/GccInline.c | >>> 47 +++++++------------- >>>>> 2 files changed, 34 insertions(+), 55 deletions(-) >>>>> >>>> >>>> Ping :) >>> >>> Ping >>> _______________________________________________ >>> edk2-devel mailing list >>> edk2-devel@lists.01.org >>> https://lists.01.org/mailman/listinfo/edk2-devel > _______________________________________________ > edk2-devel mailing list > edk2-devel@lists.01.org > https://lists.01.org/mailman/listinfo/edk2-devel >