From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from EUR05-AM6-obe.outbound.protection.outlook.com (EUR05-AM6-obe.outbound.protection.outlook.com [40.107.22.64]) by mx.groups.io with SMTP id smtpd.web10.5111.1688034211905690324 for ; Thu, 29 Jun 2023 03:23:32 -0700 Authentication-Results: mx.groups.io; dkim=pass header.i=@armh.onmicrosoft.com header.s=selector2-armh-onmicrosoft-com header.b=CKoEo1Rg; spf=pass (domain: arm.com, ip: 40.107.22.64, mailfrom: sami.mujawar@arm.com) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rfoRC2MHqN6YMhoHcUxxntwOZ9+ezd8Q+w/ikfSH0KY=; b=CKoEo1RgI4fav61dVV8TNu9NQvfKe5BzQLN8lRvshGcfqHROFEdL2UoAsAm0rhzGt3hjnxHfk4d+t9Wgabb5IVlC6rkMSNP0eipp7K2d4yxfnoIspVjIZqd9SrKc5aRYzlc9ZiC2wbG4CpYEcH7GgZDhFskGzR8Mr8zs3P4kwl4= Received: from AM0PR04CA0042.eurprd04.prod.outlook.com (2603:10a6:208:1::19) by GV2PR08MB9208.eurprd08.prod.outlook.com (2603:10a6:150:dc::14) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6521.24; Thu, 29 Jun 2023 10:23:28 +0000 Received: from AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com (2603:10a6:208:1:cafe::c3) by AM0PR04CA0042.outlook.office365.com (2603:10a6:208:1::19) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Thu, 29 Jun 2023 10:23:28 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 63.35.35.123) smtp.mailfrom=arm.com; dkim=pass (signature was verified) header.d=armh.onmicrosoft.com;dmarc=pass action=none header.from=arm.com; Received-SPF: Pass (protection.outlook.com: domain of arm.com designates 63.35.35.123 as permitted sender) receiver=protection.outlook.com; client-ip=63.35.35.123; helo=64aa7808-outbound-1.mta.getcheckrecipient.com; pr=C Received: from 64aa7808-outbound-1.mta.getcheckrecipient.com (63.35.35.123) by AM7EUR03FT023.mail.protection.outlook.com (100.127.140.73) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6544.22 via Frontend Transport; Thu, 29 Jun 2023 10:23:27 +0000 Received: ("Tessian outbound 52217515e112:v142"); Thu, 29 Jun 2023 10:23:27 +0000 X-CheckRecipientChecked: true X-CR-MTA-CID: 1f3a8639ecda3da6 X-CR-MTA-TID: 64aa7808 Received: from 1c85dba48c1c.1 by 64aa7808-outbound-1.mta.getcheckrecipient.com id CB3F793D-89C9-466A-A518-EAE887A5584C.1; Thu, 29 Jun 2023 10:23:21 +0000 Received: from EUR03-DBA-obe.outbound.protection.outlook.com by 64aa7808-outbound-1.mta.getcheckrecipient.com with ESMTPS id 1c85dba48c1c.1 (version=TLSv1.2 cipher=ECDHE-RSA-AES256-GCM-SHA384); Thu, 29 Jun 2023 10:23:21 +0000 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=Tkrfxhtp0aZ24yKDUN8MHakzcz6lLLf1slxDN2rgzKYToRws/GCyTp/CeIKRRdbGFEoh27GSL+myDOs7jaE0gjQeQA2QzR0gCqYicW32A/aqzeH/DmfS9CaPLAr/OrhFKdKU/ipNk+/HwFIldj1fZkJRVZtslrZ1FTyg9LMRGWS/u5uIRxXPqoJT/W76oeZDwdT7Bo+eZtUrtrMyzg+pWcjmf+oa/wvQtYOKm95k7lNGelJXNTYVBnFZzaOpxgGJS06ATI+1NqrAFvZT0rqd9jUtRCZk9Q1R6AHLHCH1aEbwP2HovR1RKe9l2i8/QIwLly+7F0y7kr8CDoXYs0PjvQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rfoRC2MHqN6YMhoHcUxxntwOZ9+ezd8Q+w/ikfSH0KY=; b=QG9PjWduJeVcTo2nAAd1knrBWQXK7/g8pgpukKwXDfN7O5TmbC8l0FADq/HEw+32UbJu97AYHknll6P7ahMwUEoeYTm+ILBVM9TYKV9xZnigmmqwDcK8RB6WAcvr+0QXDEBNBjfbMyJqIfe5sg5mZemSg02obhJfEMbhsXwrpKJT6mw7IZV1NDEgyJWeCD7XkqIehwVy8HNB0xB9E/Jmu0Y5+v4tDOxhuiBn50TFgWoFEGPLSgmZlv72hRlj8IGCVHy3lzcaRtlTAD9XcKpxGri/ZtPzrFzNlk2RpIevNmV8yTOoqpv5iuc9LWA7Cz8e581tqFcMp+L/TlOVbo0OmA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=arm.com; dmarc=pass action=none header.from=arm.com; dkim=pass header.d=arm.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=armh.onmicrosoft.com; s=selector2-armh-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rfoRC2MHqN6YMhoHcUxxntwOZ9+ezd8Q+w/ikfSH0KY=; b=CKoEo1RgI4fav61dVV8TNu9NQvfKe5BzQLN8lRvshGcfqHROFEdL2UoAsAm0rhzGt3hjnxHfk4d+t9Wgabb5IVlC6rkMSNP0eipp7K2d4yxfnoIspVjIZqd9SrKc5aRYzlc9ZiC2wbG4CpYEcH7GgZDhFskGzR8Mr8zs3P4kwl4= Authentication-Results-Original: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Received: from AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) by PAWPR08MB9996.eurprd08.prod.outlook.com (2603:10a6:102:35a::11) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6500.37; Thu, 29 Jun 2023 10:23:17 +0000 Received: from AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::8ef4:aa57:6248:7850]) by AS8PR08MB6806.eurprd08.prod.outlook.com ([fe80::8ef4:aa57:6248:7850%4]) with mapi id 15.20.6544.019; Thu, 29 Jun 2023 10:23:17 +0000 Message-ID: Date: Thu, 29 Jun 2023 11:23:15 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.12.0 Subject: Re: [PATCH v1 1/8] MdePkg/ArmTrngLib: Remove ASSERTs in Null implementation To: pierre.gondois@arm.com, devel@edk2.groups.io Cc: Michael D Kinney , Liming Gao , Zhiguang Liu , Jiewen Yao , Jian J Wang , Ard Biesheuvel , Jose Marinho , Samer El-Haj-Mahmoud , "nd@arm.com" References: <20230509074042.1523428-1-pierre.gondois@arm.com> <20230509074042.1523428-2-pierre.gondois@arm.com> From: "Sami Mujawar" In-Reply-To: <20230509074042.1523428-2-pierre.gondois@arm.com> X-ClientProxiedBy: LNXP123CA0016.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:d2::28) To AS8PR08MB6806.eurprd08.prod.outlook.com (2603:10a6:20b:39b::12) MIME-Version: 1.0 X-MS-TrafficTypeDiagnostic: AS8PR08MB6806:EE_|PAWPR08MB9996:EE_|AM7EUR03FT023:EE_|GV2PR08MB9208:EE_ X-MS-Office365-Filtering-Correlation-Id: 20de8638-a53a-4004-0580-08db788ae105 x-checkrecipientrouted: true NoDisclaimer: true X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam-Untrusted: BCL:0; X-Microsoft-Antispam-Message-Info-Original: I90hv5eDKE9Yx2W/lvXQkSiO63HvBPxM0H+rkdIO+OTIJ4nvz3F09gPhPE4OGoJzV+jSvT90GpWo2fdjqNahcou2tvLTSl1Wb2Oxty9VCFYLEgXZ2u6YiVRJfGpYRrzGU0v27XCfijUKg2zOaH5iuiWG5mAUtfENG7+F4peaXVTzlyZ40HG6ybBgd9hBm1TVQDDqBTd7DaVCl0bVbK0KK+VQwPXIezhVDGpI38WCEL5h6qlR8L0lmkwMkBBi6dGJvKTrJ99T43ysJrzxXVOpMr2BJqVG9rsZ/u4QAGnR9AqcsNRGxvxJVix1/kba75gBNtmYqMamJdKcsFZNj+AoWG25wGWrk7h/QRo/i8ld8FG6TdDHCrjbjtXdOINMlDjEfR4tG6UYRUtsQ8amKlI4bMtFRoPDS0Ty5CP/RozKXSP1dtIrUuHF8EsECyZxYxqiMFhgAMC3IvDSIFk8UC/7PY7rGnpPd1RZv54hJ89LJoBwMJtC/s8kzz+ikP6NKlN+ZHtAWA5cuFGPVZjS07A2J+lAJjZvKCvM8WxyO3cEK9OudYDPLbEODxCEioP8GGd6Dj8nNnKjUhubbLUl3B2REkDpJBdvr62XutLlKk+JsHdEPfrcKP0gXx+Q0a72VK3Zf1nkHwiyqYtxkXzHPRDlwQ== X-Forefront-Antispam-Report-Untrusted: CIP:255.255.255.255;CTRY:;LANG:en;SCL:1;SRV:;IPV:NLI;SFV:NSPM;H:AS8PR08MB6806.eurprd08.prod.outlook.com;PTR:;CAT:NONE;SFS:(13230028)(4636009)(346002)(366004)(39860400002)(376002)(396003)(136003)(451199021)(36756003)(6486002)(26005)(2616005)(38100700002)(186003)(53546011)(6512007)(83380400001)(6506007)(86362001)(31696002)(478600001)(5660300002)(2906002)(31686004)(8676002)(316002)(4326008)(8936002)(41300700001)(66476007)(66946007)(66556008)(44832011)(54906003)(43740500002)(45980500001);DIR:OUT;SFP:1101; X-MS-Exchange-Transport-CrossTenantHeadersStamped: PAWPR08MB9996 Original-Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=arm.com; Return-Path: Sami.Mujawar@arm.com X-EOPAttributedMessage: 0 X-MS-Exchange-Transport-CrossTenantHeadersStripped: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id-Prvs: 6f8134c0-be42-4d19-23ca-08db788ada27 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: tMooUSbu4vQo8de5P11yljVDJh36ykyRp9vFT/Hzl2gYRAbGLVlXTTck+ChyTjEOscMOAyhqENU5DoZ2bXrAA/ilzOa6DFA+ncbHR8b5HtG+Nun3yBiANlaEwIFHmI22z8S+C47HUJMTosiqk7q+z1K1cE/pFEk2KQEakrBrjRs7E0XN1z2Xqz37gQJprWhW1WORtkIyv/gsyyWfyM/iJtnsiCKSodT0zG7hFjcYJSUI7xq7YpbdiLle2RN/fx1c23SldcjXlWpmSuj5Nm3mB7yFADJyWj0FoLPPSzwVk0i6gsBtcdkOKZoPohYntN8Q/UqZ3q+0ZkH/5zcwT0R6Y3w2beI1UN4Nt7s0ogyoSmV8rSbnBYfaJwyS/mpH639Nwpvr8mfx7kWZxMr9LGuJvmsV254AXUodHoDw/uh7RF9kvOhkhHPDPr5G10QJfmZq1RM28NM9vuRzRXAcXorCnAwUjfoC1lKjVCdy9Lm2jOgs2iKhv8arEN9llufGMV66kondcht0KipzaRQx5DvvWxUOnO0pRdNzvZijoPUdll/DAIG1zDFzrKjFoq9U/zBp7D/OpxrFi/eo/Qed9kxImM+duLp8viD4BKntNjzFT8cp38qffe9hQqFwWgolo8mXcT3/P10ls9x9Woc6aJr12TGextPTZXxX9YeChLrnCk9SY9wVJJ30pFtsjftNENbbqOuQ1/aO8RZ7zXo6UGYebFM+1Onqhsl/Dr8BjOGYq/pzf/vH5K1aNwI+WSD/f+aakxnGSifOvYU7T87z5UB7hA== X-Forefront-Antispam-Report: CIP:63.35.35.123;CTRY:IE;LANG:en;SCL:1;SRV:;IPV:CAL;SFV:NSPM;H:64aa7808-outbound-1.mta.getcheckrecipient.com;PTR:ec2-63-35-35-123.eu-west-1.compute.amazonaws.com;CAT:NONE;SFS:(13230028)(4636009)(376002)(136003)(346002)(39860400002)(396003)(451199021)(36840700001)(40470700004)(46966006)(8936002)(8676002)(478600001)(70206006)(5660300002)(44832011)(4326008)(36860700001)(86362001)(31696002)(41300700001)(316002)(82740400003)(70586007)(2906002)(40480700001)(356005)(81166007)(36756003)(40460700003)(82310400005)(47076005)(53546011)(83380400001)(6512007)(186003)(6506007)(2616005)(26005)(54906003)(336012)(31686004)(6486002)(43740500002);DIR:OUT;SFP:1101; X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 29 Jun 2023 10:23:27.8298 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 20de8638-a53a-4004-0580-08db788ae105 X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[63.35.35.123];Helo=[64aa7808-outbound-1.mta.getcheckrecipient.com] X-MS-Exchange-CrossTenant-AuthSource: AM7EUR03FT023.eop-EUR03.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: GV2PR08MB9208 Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Pierre, Thank you for this patch. This change looks good to me. Reviewed-by: Sami Mujawar Regards, Sami Mujawar On 09/05/2023 08:40 am, pierre.gondois@arm.com wrote: > From: Pierre Gondois > > Remove ASSERTs to allow RngDxe probing the Null implementation > of the TrngLib. > > Signed-off-by: Pierre Gondois > --- > MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c | 4 ---- > 1 file changed, 4 deletions(-) > > diff --git a/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c b/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c > index 316d78bf5e83..0ea9aafa59f1 100644 > --- a/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c > +++ b/MdePkg/Library/BaseArmTrngLibNull/BaseArmTrngLibNull.c > @@ -41,7 +41,6 @@ GetArmTrngVersion ( > OUT UINT16 *MinorRevision > ) > { > - ASSERT (FALSE); > return RETURN_UNSUPPORTED; > } > > @@ -67,7 +66,6 @@ GetArmTrngUuid ( > OUT GUID *Guid > ) > { > - ASSERT (FALSE); > return RETURN_UNSUPPORTED; > } > > @@ -83,7 +81,6 @@ GetArmTrngMaxSupportedEntropyBits ( > VOID > ) > { > - ASSERT (FALSE); > return 0; > } > > @@ -116,6 +113,5 @@ GetArmTrngEntropy ( > OUT UINT8 *Buffer > ) > { > - ASSERT (FALSE); > return RETURN_UNSUPPORTED; > }